Code Review
/
apps
/
low-level-can-service.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
8ca422e
)
Add a TODO about flipping byte order.
author
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Sun, 5 Jan 2014 23:56:37 +0000
(18:56 -0500)
committer
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Sun, 5 Jan 2014 23:56:37 +0000
(18:56 -0500)
src/obd2/obd2.c
patch
|
blob
|
history
diff --git
a/src/obd2/obd2.c
b/src/obd2/obd2.c
index
f8b4a37
..
402cc2f
100644
(file)
--- a/
src/obd2/obd2.c
+++ b/
src/obd2/obd2.c
@@
-37,7
+37,8
@@
DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims,
uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE];
payload[MODE_BYTE_INDEX] = request->mode;
if(request->pid_length > 0) {
- // TODO may need to flip the byte order
+ // TODO need a set bit field that's more natural and checks endianness
+ // becauase we DO need to flip it
copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid),
PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload));
}