Add a TODO about flipping byte order.
authorChristopher Peplin <chris.peplin@rhubarbtech.com>
Sun, 5 Jan 2014 23:56:37 +0000 (18:56 -0500)
committerChristopher Peplin <chris.peplin@rhubarbtech.com>
Sun, 5 Jan 2014 23:56:37 +0000 (18:56 -0500)
src/obd2/obd2.c

index f8b4a37..402cc2f 100644 (file)
@@ -37,7 +37,8 @@ DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims,
     uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE];
     payload[MODE_BYTE_INDEX] = request->mode;
     if(request->pid_length > 0) {
-        // TODO may need to flip the byte order
+        // TODO need a set bit field that's more natural and checks endianness
+        // becauase we DO need to flip it
         copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid),
                 PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload));
     }