Possible uninitialized variable returned.
authorRomain Forlot <romain.forlot@iot.bzh>
Wed, 7 Jun 2017 13:41:40 +0000 (15:41 +0200)
committerRomain Forlot <romain.forlot@iot.bzh>
Wed, 7 Jun 2017 13:41:40 +0000 (15:41 +0200)
Change-Id: Id6ffed520aa238304afdddcd37a64e93002196aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
CAN-binder/low-can-binding/binding/low-can-cb.cpp

index 5a877af..fbe6e19 100644 (file)
@@ -134,7 +134,7 @@ static int create_event_handle(std::shared_ptr<low_can_subscription_t>& can_subs
 /// against the application framework using that event handle.
 static int subscribe_unsubscribe_signal(struct afb_req request, bool subscribe, std::shared_ptr<low_can_subscription_t>& can_subscription, std::map<int, std::shared_ptr<low_can_subscription_t> >& s)
 {
-       int ret;
+       int ret = -1;
        int sub_index = can_subscription->get_index();
 
        if (can_subscription && s.find(sub_index) != s.end())
@@ -144,6 +144,7 @@ static int subscribe_unsubscribe_signal(struct afb_req request, bool subscribe,
                        NOTICE(binder_interface, "%s: Event isn't valid, no need to unsubscribed.", __FUNCTION__);
                        ret = -1;
                }
+               ret = 0;
        }
        else
        {