all: format typo 45/23245/7
authorRomain Forlot <romain.forlot@iot.bzh>
Fri, 29 Nov 2019 14:42:55 +0000 (15:42 +0100)
committerRomain Forlot <romain.forlot@iot.bzh>
Thu, 9 Jan 2020 15:25:36 +0000 (16:25 +0100)
Bug-AGL: SPEC-2988

Change-Id: I81c01a817cd31d577068350d8445a1df2751bff7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
low-can-binding/binding/low-can-hat.cpp
low-can-binding/can/can-bus.cpp
low-can-binding/can/message-definition.cpp
low-can-binding/utils/converter.cpp
low-can-binding/utils/socketcan-j1939/socketcan-j1939.cpp

index 5a26874..7e0d94a 100644 (file)
@@ -71,7 +71,9 @@ int read_message(sd_event_source *event_source, int fd, uint32_t revents, void *
                                std::shared_ptr<message_t> message = s->read_message();
 
                                // Sure we got a valid CAN message ?
-                               if (message->get_id() && message->get_length() && !(message->get_flags() & INVALID_FLAG))
+                               if (message->get_id() &&
+                                   message->get_length() &&
+                                   ! (message->get_flags() & INVALID_FLAG) )
                                        push_n_notify(message);
                        }
                }
index cbe3cda..0510998 100644 (file)
@@ -181,9 +181,7 @@ void can_bus_t::can_decode_message()
                                std::lock_guard<std::mutex> subscribed_signals_lock(sm.get_subscribed_signals_mutex());
                                map_subscription& s = sm.get_subscribed_signals();
                                if(application_t::instance().get_diagnostic_manager().is_diagnostic_response(message))
-                               {
                                        process_diagnostic_signals(application_t::instance().get_diagnostic_manager(), message, s);
-                               }
                                else
                                        process_signals(message, s);
                        }
index e6fd862..5977fb4 100644 (file)
@@ -87,7 +87,7 @@ bool message_definition_t::is_j1939() const
 
 bool message_definition_t::is_isotp() const
 {
-       return (flags_&ISOTP_PROTOCOL);
+       return (flags_ & ISOTP_PROTOCOL);
 }
 
 vect_ptr_signal_t& message_definition_t::get_signals()
index 1d7abde..0a09125 100644 (file)
@@ -58,12 +58,12 @@ void converter_t::signal_to_bits_bytes(unsigned int bit_position, unsigned int b
 
 
 /**
- * @brief      This is to use when you have a big endian CAN frame layout.
- *                     It converts the bit position so it matches with little endiant CAN frame layout.
+ * @brief      This is to use when you have a big endian CAN frame layout.
+ *             It converts the bit position so it matches with little endiant CAN frame layout.
  *
  * @param bit_position         Original bit position.
  * @param bit_size             Size of the data.
- * @return uint32_t    New little endian bit position.
+ * @return uint32_t    New bit position.
  */
 uint32_t converter_t::bit_position_swap(uint32_t bit_position,uint32_t bit_size)
 {
index 660dffe..e8d85b5 100644 (file)
@@ -211,8 +211,6 @@ namespace utils
                if(nbytes < 0)
                        return nullptr;
 
-               //AFB_DEBUG("Data available: %i bytes read", (int)nbytes);
-
                struct timeval tv;
                ioctl(socket(), SIOCGSTAMP, &tv);
                uint64_t timestamp = 1000000 * tv.tv_sec + tv.tv_usec;