Code Review
/
apps
/
agl-service-can-low-level.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
|
inline
| side by side (parent:
fed7c4c
)
Don't try and rx broadcast response on all handles after one completes.
author
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Tue, 21 Jan 2014 02:41:25 +0000
(21:41 -0500)
committer
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Tue, 21 Jan 2014 02:41:25 +0000
(21:41 -0500)
src/uds/uds.c
patch
|
blob
|
history
diff --git
a/src/uds/uds.c
b/src/uds/uds.c
index
b3f2cda
..
5d41582
100644
(file)
--- a/
src/uds/uds.c
+++ b/
src/uds/uds.c
@@
-204,8
+204,6
@@
DiagnosticResponse diagnostic_receive_can_frame(DiagnosticShims* shims,
IsoTpMessage message = isotp_continue_receive(&handle->isotp_shims,
&handle->isotp_receive_handles[i], arbitration_id, data, size);
IsoTpMessage message = isotp_continue_receive(&handle->isotp_shims,
&handle->isotp_receive_handles[i], arbitration_id, data, size);
- // TODO as of now we're completing the handle as soon as one
- // broadcast response is received....need to hang on for 100ms
if(message.completed) {
if(message.size > 0) {
response.mode = message.payload[0];
if(message.completed) {
if(message.size > 0) {
response.mode = message.payload[0];
@@
-237,6
+235,10
@@
DiagnosticResponse diagnostic_receive_can_frame(DiagnosticShims* shims,
if(handle->completed && handle->callback != NULL) {
handle->callback(&response);
}
if(handle->completed && handle->callback != NULL) {
handle->callback(&response);
}
+
+ // TODO as of now we're completing the handle as soon as one
+ // broadcast response is received....need to hang on for 100ms
+ break;
}
}
}
}
}
}