summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
bee892b)
In some case, dlopen raise a segmentation fault.
This commit takes care of this.
Change-Id: I6cbe59de2422dafcdf3714d0539b1757511c100b
Bug-AGL: SPEC-662
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
#include "afb-api-so-v1.h"
#include "afb-api-so-v2.h"
#include "verbose.h"
#include "afb-api-so-v1.h"
#include "afb-api-so-v2.h"
#include "verbose.h"
+#include "sig-monitor.h"
+
+struct safe_dlopen
+{
+ const char *path;
+ void *handle;
+ int flags;
+};
+
+static void safe_dlopen_cb(int sig, void *closure)
+{
+ struct safe_dlopen *sd = closure;
+ if (!sig)
+ sd->handle = dlopen(sd->path, sd->flags);
+ else {
+ ERROR("dlopen of %s raised signal %s", sd->path, strsignal(sig));
+ sd->handle = NULL;
+ }
+}
+
+static void *safe_dlopen(const char *filename, int flags)
+{
+ struct safe_dlopen sd;
+ sd.path = filename;
+ sd.flags = flags;
+ sd.handle = NULL;
+ sig_monitor(0, safe_dlopen_cb, &sd);
+ return sd.handle;
+}
static int load_binding(const char *path, int force, struct afb_apiset *apiset)
{
static int load_binding(const char *path, int force, struct afb_apiset *apiset)
{
// This is a loadable library let's check if it's a binding
rc = -!!force;
// This is a loadable library let's check if it's a binding
rc = -!!force;
- handle = dlopen(path, RTLD_NOW | RTLD_LOCAL);
+ handle = safe_dlopen(path, RTLD_NOW | RTLD_LOCAL);
if (handle == NULL) {
if (force)
ERROR("binding [%s] not loadable: %s", path, dlerror());
if (handle == NULL) {
if (force)
ERROR("binding [%s] not loadable: %s", path, dlerror());
/* case of directories */
if (dent->d_name[0] == '.') {
if (len == 1)
/* case of directories */
if (dent->d_name[0] == '.') {
if (len == 1)
if (dent->d_name[1] == '.' && len == 2)
if (dent->d_name[1] == '.' && len == 2)
}
memcpy(&path[end], dent->d_name, len+1);
rc = adddirs(path, end+len, apiset, failstops);
}
memcpy(&path[end], dent->d_name, len+1);
rc = adddirs(path, end+len, apiset, failstops);