revised comments sandbox/ydimitrov/revised_comments
authorydimitrov <y.dimitrov.14@gmail.com>
Sat, 12 May 2018 10:39:16 +0000 (11:39 +0100)
committerydimitrov <y.dimitrov.14@gmail.com>
Sat, 12 May 2018 10:39:16 +0000 (11:39 +0100)
commit5ccf0b8ec909e040483f05ee37dbd47ae73ac456
tree7446570d3e33688e081d62739fc6d26d5ca9dc08
parent3cfd664359834d95d86e0477dbbd57d7f7c5bc17
revised comments

Signed-off-by: ydimitrov <y.dimitrov.14@gmail.com>
455 files changed:
.gitignore
.gitmodules
.gitreview
CMakeLists.txt
Doxyfile
LICENSE
README.md
book.json
can_samples/citroen/citroen_c5_highway_1
can_samples/citroen/citroen_c5_highway_2
can_samples/ford/focus/accel
can_samples/ford/focus/alldoors_lock
can_samples/ford/focus/alldoors_open
can_samples/ford/focus/brake
can_samples/ford/focus/handbrake
can_samples/ford/focus/ignition
can_samples/ford/focus/lights
can_samples/ford/focus/turnleft
can_samples/ford/focus/turnright
can_samples/init_can.sh
can_samples/init_vcan.sh
can_samples/toyota/auris/accel
can_samples/toyota/auris/alldoors_lock
can_samples/toyota/auris/alldoors_unlock
can_samples/toyota/auris/brake
can_samples/toyota/auris/engineoff
can_samples/toyota/auris/handbrake
can_samples/toyota/auris/ignition
can_samples/toyota/auris/keydisengage
can_samples/toyota/auris/keyengage
can_samples/toyota/auris/keyin
can_samples/toyota/auris/keyout
can_samples/toyota/auris/lights
can_samples/toyota/auris/ok
can_samples/toyota/auris/trip_test_with_obd2_vehicle_speed_requests
can_samples/toyota/auris/turnleft
can_samples/toyota/auris/turnright
conf.d/autobuild/agl/autobuild
conf.d/autobuild/linux/autobuild
conf.d/cmake/config.cmake
conf.d/wgt/config.xml.in
docs/1-Architecture.md
docs/2-Installation.md
docs/3-Usage.md
docs/Doc-Revisions.md
docs/README.md
docs/SUMMARY.md
docs/_layouts/ebook/page.html
docs/_layouts/ebook/pdf_footer.html
docs/_layouts/ebook/pdf_header.html
docs/_layouts/ebook/summary.html
docs/_layouts/layout.html
docs/images/logo_iot_bzh.svg
docs/resources/cover.svg
docs/resources/ebook.css
docs/resources/make_cover.sh
examples/OBD2/application-generated.cpp
examples/OBD2/signals.json
examples/agl-vcar/application-generated.cpp
examples/agl-vcar/signals.json
examples/basic/application-generated.cpp
examples/basic/handlers.cpp
examples/basic/signals.json
examples/engine/application-generated.cpp
examples/engine/signals.json
examples/hvac/application-generated.cpp
examples/hvac/signals.json
examples/toyota/auris/application-generated.cpp
examples/toyota/auris/signals.json
gendocs.sh
libs/CMakeLists.txt
libs/bitfield-c/.gitignore
libs/bitfield-c/.travis.yml
libs/bitfield-c/CHANGELOG.mkd
libs/bitfield-c/CMakeLists.txt
libs/bitfield-c/LICENSE
libs/bitfield-c/README.mkd
libs/bitfield-c/runtests.sh
libs/bitfield-c/src/bitfield/8byte.c
libs/bitfield-c/src/bitfield/8byte.h
libs/bitfield-c/src/bitfield/bitarray.c
libs/bitfield-c/src/bitfield/bitfield.c
libs/bitfield-c/src/bitfield/bitfield.h
libs/bitfield-c/src/canutil/read.c
libs/bitfield-c/src/canutil/read.h
libs/bitfield-c/src/canutil/write.c
libs/bitfield-c/src/canutil/write.h
libs/bitfield-c/tests/8byte_tests.c
libs/bitfield-c/tests/bitfield_tests.c
libs/bitfield-c/tests/read_tests.c
libs/bitfield-c/tests/write_tests.c
libs/ini-config/CMakeLists.txt
libs/ini-config/ini-config.cpp
libs/ini-config/ini-config.hpp
libs/isotp-c/.gitignore
libs/isotp-c/.travis.yml
libs/isotp-c/CHANGELOG.mkd
libs/isotp-c/CMakeLists.txt
libs/isotp-c/LICENSE
libs/isotp-c/README.mkd
libs/isotp-c/runtests.sh
libs/isotp-c/src/isotp/isotp.c
libs/isotp-c/src/isotp/isotp.h
libs/isotp-c/src/isotp/isotp_types.h
libs/isotp-c/src/isotp/receive.c
libs/isotp-c/src/isotp/receive.h
libs/isotp-c/src/isotp/send.c
libs/isotp-c/src/isotp/send.h
libs/isotp-c/tests/common.c
libs/isotp-c/tests/test_core.c
libs/isotp-c/tests/test_receive.c
libs/isotp-c/tests/test_send.c
libs/nanopb/.gitignore
libs/nanopb/.travis.yml
libs/nanopb/AUTHORS
libs/nanopb/BUILD
libs/nanopb/CHANGELOG.txt
libs/nanopb/CONTRIBUTING.md
libs/nanopb/LICENSE.txt
libs/nanopb/README.md
libs/nanopb/docs/Makefile
libs/nanopb/docs/concepts.rst
libs/nanopb/docs/generator_flow.svg
libs/nanopb/docs/index.rst
libs/nanopb/docs/logo/logo.svg
libs/nanopb/docs/lsr.css
libs/nanopb/docs/menu.rst
libs/nanopb/docs/migration.rst
libs/nanopb/docs/reference.rst
libs/nanopb/docs/security.rst
libs/nanopb/examples/cmake_simple/CMakeLists.txt
libs/nanopb/examples/cmake_simple/README.txt
libs/nanopb/examples/cmake_simple/simple.c
libs/nanopb/examples/cmake_simple/simple.proto
libs/nanopb/examples/network_server/Makefile
libs/nanopb/examples/network_server/README.txt
libs/nanopb/examples/network_server/client.c
libs/nanopb/examples/network_server/common.c
libs/nanopb/examples/network_server/common.h
libs/nanopb/examples/network_server/fileproto.options
libs/nanopb/examples/network_server/fileproto.proto
libs/nanopb/examples/network_server/server.c
libs/nanopb/examples/simple/Makefile
libs/nanopb/examples/simple/README.txt
libs/nanopb/examples/simple/simple.c
libs/nanopb/examples/simple/simple.proto
libs/nanopb/examples/using_double_on_avr/Makefile
libs/nanopb/examples/using_double_on_avr/README.txt
libs/nanopb/examples/using_double_on_avr/decode_double.c
libs/nanopb/examples/using_double_on_avr/double_conversion.c
libs/nanopb/examples/using_double_on_avr/double_conversion.h
libs/nanopb/examples/using_double_on_avr/doubleproto.proto
libs/nanopb/examples/using_double_on_avr/encode_double.c
libs/nanopb/examples/using_double_on_avr/test_conversions.c
libs/nanopb/examples/using_union_messages/Makefile
libs/nanopb/examples/using_union_messages/README.txt
libs/nanopb/examples/using_union_messages/decode.c
libs/nanopb/examples/using_union_messages/encode.c
libs/nanopb/examples/using_union_messages/unionproto.proto
libs/nanopb/extra/FindNanopb.cmake
libs/nanopb/extra/nanopb.mk
libs/nanopb/extra/pb_syshdr.h
libs/nanopb/generator/nanopb/options.proto
libs/nanopb/generator/nanopb_generator.py
libs/nanopb/generator/proto/Makefile
libs/nanopb/generator/proto/google/protobuf/descriptor.proto
libs/nanopb/generator/proto/nanopb.proto
libs/nanopb/generator/proto/plugin.proto
libs/nanopb/generator/protoc-gen-nanopb
libs/nanopb/generator/protoc-gen-nanopb.bat
libs/nanopb/library.json
libs/nanopb/pb.h
libs/nanopb/pb_common.c
libs/nanopb/pb_common.h
libs/nanopb/pb_decode.c
libs/nanopb/pb_decode.h
libs/nanopb/pb_encode.c
libs/nanopb/pb_encode.h
libs/nanopb/tests/Makefile
libs/nanopb/tests/SConstruct
libs/nanopb/tests/alltypes/SConscript
libs/nanopb/tests/alltypes/alltypes.options
libs/nanopb/tests/alltypes/alltypes.proto
libs/nanopb/tests/alltypes/decode_alltypes.c
libs/nanopb/tests/alltypes/encode_alltypes.c
libs/nanopb/tests/alltypes_callback/SConscript
libs/nanopb/tests/alltypes_callback/alltypes.options
libs/nanopb/tests/alltypes_callback/decode_alltypes_callback.c
libs/nanopb/tests/alltypes_callback/encode_alltypes_callback.c
libs/nanopb/tests/alltypes_pointer/SConscript
libs/nanopb/tests/alltypes_pointer/alltypes.options
libs/nanopb/tests/alltypes_pointer/decode_alltypes_pointer.c
libs/nanopb/tests/alltypes_pointer/encode_alltypes_pointer.c
libs/nanopb/tests/alltypes_proto3/SConscript
libs/nanopb/tests/alltypes_proto3/alltypes.options
libs/nanopb/tests/alltypes_proto3/alltypes.proto
libs/nanopb/tests/alltypes_proto3/decode_alltypes.c
libs/nanopb/tests/alltypes_proto3/encode_alltypes.c
libs/nanopb/tests/alltypes_proto3_callback/SConscript
libs/nanopb/tests/alltypes_proto3_callback/alltypes.options
libs/nanopb/tests/alltypes_proto3_callback/decode_alltypes_callback.c
libs/nanopb/tests/alltypes_proto3_callback/encode_alltypes_callback.c
libs/nanopb/tests/anonymous_oneof/SConscript
libs/nanopb/tests/anonymous_oneof/decode_oneof.c
libs/nanopb/tests/anonymous_oneof/oneof.proto
libs/nanopb/tests/backwards_compatibility/SConscript
libs/nanopb/tests/backwards_compatibility/alltypes_legacy.c
libs/nanopb/tests/backwards_compatibility/alltypes_legacy.h
libs/nanopb/tests/backwards_compatibility/alltypes_legacy.options
libs/nanopb/tests/backwards_compatibility/alltypes_legacy.proto
libs/nanopb/tests/backwards_compatibility/decode_legacy.c
libs/nanopb/tests/backwards_compatibility/encode_legacy.c
libs/nanopb/tests/basic_buffer/SConscript
libs/nanopb/tests/basic_buffer/decode_buffer.c
libs/nanopb/tests/basic_buffer/encode_buffer.c
libs/nanopb/tests/basic_stream/SConscript
libs/nanopb/tests/basic_stream/decode_stream.c
libs/nanopb/tests/basic_stream/encode_stream.c
libs/nanopb/tests/buffer_only/SConscript
libs/nanopb/tests/callbacks/SConscript
libs/nanopb/tests/callbacks/callbacks.proto
libs/nanopb/tests/callbacks/decode_callbacks.c
libs/nanopb/tests/callbacks/encode_callbacks.c
libs/nanopb/tests/common/SConscript
libs/nanopb/tests/common/malloc_wrappers.c
libs/nanopb/tests/common/malloc_wrappers.h
libs/nanopb/tests/common/malloc_wrappers_syshdr.h
libs/nanopb/tests/common/person.proto
libs/nanopb/tests/common/test_helpers.h
libs/nanopb/tests/common/unittestproto.proto
libs/nanopb/tests/common/unittests.h
libs/nanopb/tests/cxx_main_program/SConscript
libs/nanopb/tests/cyclic_messages/SConscript
libs/nanopb/tests/cyclic_messages/cyclic.proto
libs/nanopb/tests/cyclic_messages/cyclic_callback.options
libs/nanopb/tests/cyclic_messages/encode_cyclic_callback.c
libs/nanopb/tests/decode_unittests/SConscript
libs/nanopb/tests/decode_unittests/decode_unittests.c
libs/nanopb/tests/encode_unittests/SConscript
libs/nanopb/tests/encode_unittests/encode_unittests.c
libs/nanopb/tests/enum_sizes/SConscript
libs/nanopb/tests/enum_sizes/enumsizes.proto
libs/nanopb/tests/enum_sizes/enumsizes_unittests.c
libs/nanopb/tests/enum_to_string/SConscript
libs/nanopb/tests/enum_to_string/enum.proto
libs/nanopb/tests/enum_to_string/enum_to_string.c
libs/nanopb/tests/extensions/SConscript
libs/nanopb/tests/extensions/decode_extensions.c
libs/nanopb/tests/extensions/encode_extensions.c
libs/nanopb/tests/extensions/extensions.options
libs/nanopb/tests/extensions/extensions.proto
libs/nanopb/tests/extra_fields/SConscript
libs/nanopb/tests/extra_fields/person_with_extra_field.expected
libs/nanopb/tests/field_size_16/SConscript
libs/nanopb/tests/field_size_16/alltypes.options
libs/nanopb/tests/field_size_16/alltypes.proto
libs/nanopb/tests/field_size_16_proto3/SConscript
libs/nanopb/tests/field_size_16_proto3/alltypes.options
libs/nanopb/tests/field_size_16_proto3/alltypes.proto
libs/nanopb/tests/field_size_16_proto3/decode_alltypes.c
libs/nanopb/tests/field_size_16_proto3/encode_alltypes.c
libs/nanopb/tests/field_size_32/SConscript
libs/nanopb/tests/field_size_32/alltypes.options
libs/nanopb/tests/field_size_32/alltypes.proto
libs/nanopb/tests/fuzztest/SConscript
libs/nanopb/tests/fuzztest/alltypes_pointer.options
libs/nanopb/tests/fuzztest/alltypes_static.options
libs/nanopb/tests/fuzztest/fuzzstub.c
libs/nanopb/tests/fuzztest/fuzztest.c
libs/nanopb/tests/fuzztest/generate_message.c
libs/nanopb/tests/fuzztest/run_radamsa.sh
libs/nanopb/tests/inline/SConscript
libs/nanopb/tests/inline/inline.expected
libs/nanopb/tests/inline/inline.proto
libs/nanopb/tests/inline/inline_unittests.c
libs/nanopb/tests/intsizes/SConscript
libs/nanopb/tests/intsizes/intsizes.proto
libs/nanopb/tests/intsizes/intsizes_unittests.c
libs/nanopb/tests/io_errors/SConscript
libs/nanopb/tests/io_errors/alltypes.options
libs/nanopb/tests/io_errors/io_errors.c
libs/nanopb/tests/io_errors_pointers/SConscript
libs/nanopb/tests/io_errors_pointers/alltypes.options
libs/nanopb/tests/mem_release/SConscript
libs/nanopb/tests/mem_release/mem_release.c
libs/nanopb/tests/mem_release/mem_release.proto
libs/nanopb/tests/message_sizes/SConscript
libs/nanopb/tests/message_sizes/dummy.c
libs/nanopb/tests/message_sizes/messages1.proto
libs/nanopb/tests/message_sizes/messages2.proto
libs/nanopb/tests/missing_fields/SConscript
libs/nanopb/tests/missing_fields/missing_fields.c
libs/nanopb/tests/missing_fields/missing_fields.proto
libs/nanopb/tests/multiple_files/SConscript
libs/nanopb/tests/multiple_files/multifile1.options
libs/nanopb/tests/multiple_files/multifile1.proto
libs/nanopb/tests/multiple_files/multifile2.proto
libs/nanopb/tests/multiple_files/subdir/multifile2.proto
libs/nanopb/tests/multiple_files/test_multiple_files.c
libs/nanopb/tests/no_errmsg/SConscript
libs/nanopb/tests/no_messages/SConscript
libs/nanopb/tests/no_messages/no_messages.proto
libs/nanopb/tests/oneof/SConscript
libs/nanopb/tests/oneof/decode_oneof.c
libs/nanopb/tests/oneof/encode_oneof.c
libs/nanopb/tests/oneof/oneof.proto
libs/nanopb/tests/options/SConscript
libs/nanopb/tests/options/options.expected
libs/nanopb/tests/options/options.proto
libs/nanopb/tests/options/proto3_options.expected
libs/nanopb/tests/options/proto3_options.proto
libs/nanopb/tests/package_name/SConscript
libs/nanopb/tests/regression/issue_118/SConscript
libs/nanopb/tests/regression/issue_118/enumdef.proto
libs/nanopb/tests/regression/issue_118/enumuse.proto
libs/nanopb/tests/regression/issue_125/SConscript
libs/nanopb/tests/regression/issue_125/extensionbug.expected
libs/nanopb/tests/regression/issue_125/extensionbug.options
libs/nanopb/tests/regression/issue_125/extensionbug.proto
libs/nanopb/tests/regression/issue_141/SConscript
libs/nanopb/tests/regression/issue_141/testproto.expected
libs/nanopb/tests/regression/issue_141/testproto.proto
libs/nanopb/tests/regression/issue_145/SConscript
libs/nanopb/tests/regression/issue_145/comments.expected
libs/nanopb/tests/regression/issue_145/comments.options
libs/nanopb/tests/regression/issue_145/comments.proto
libs/nanopb/tests/regression/issue_166/SConscript
libs/nanopb/tests/regression/issue_166/enum_encoded_size.c
libs/nanopb/tests/regression/issue_166/enums.proto
libs/nanopb/tests/regression/issue_172/SConscript
libs/nanopb/tests/regression/issue_172/msg_size.c
libs/nanopb/tests/regression/issue_172/submessage/submessage.options
libs/nanopb/tests/regression/issue_172/submessage/submessage.proto
libs/nanopb/tests/regression/issue_172/test.proto
libs/nanopb/tests/regression/issue_188/SConscript
libs/nanopb/tests/regression/issue_188/oneof.proto
libs/nanopb/tests/regression/issue_195/SConscript
libs/nanopb/tests/regression/issue_195/test.expected
libs/nanopb/tests/regression/issue_195/test.proto
libs/nanopb/tests/regression/issue_203/SConscript
libs/nanopb/tests/regression/issue_203/file1.proto
libs/nanopb/tests/regression/issue_203/file2.proto
libs/nanopb/tests/regression/issue_205/SConscript
libs/nanopb/tests/regression/issue_205/size_corruption.c
libs/nanopb/tests/regression/issue_205/size_corruption.proto
libs/nanopb/tests/regression/issue_227/SConscript
libs/nanopb/tests/regression/issue_227/unaligned_uint64.c
libs/nanopb/tests/regression/issue_227/unaligned_uint64.proto
libs/nanopb/tests/regression/issue_229/SConscript
libs/nanopb/tests/regression/issue_229/multiple_oneof.c
libs/nanopb/tests/regression/issue_229/multiple_oneof.proto
libs/nanopb/tests/regression/issue_242/SConscript
libs/nanopb/tests/regression/issue_242/zero_value.c
libs/nanopb/tests/regression/issue_242/zero_value.proto
libs/nanopb/tests/regression/issue_247/SConscript
libs/nanopb/tests/regression/issue_247/padding.c
libs/nanopb/tests/regression/issue_247/padding.proto
libs/nanopb/tests/regression/issue_249/SConscript
libs/nanopb/tests/regression/issue_249/test.c
libs/nanopb/tests/regression/issue_249/test.proto
libs/nanopb/tests/regression/issue_253/SConscript
libs/nanopb/tests/regression/issue_253/short_array.c
libs/nanopb/tests/regression/issue_253/short_array.proto
libs/nanopb/tests/regression/issue_256/SConscript
libs/nanopb/tests/regression/issue_256/submsg_array.c
libs/nanopb/tests/regression/issue_256/submsg_array.proto
libs/nanopb/tests/site_scons/site_init.py
libs/nanopb/tests/site_scons/site_tools/nanopb.py
libs/nanopb/tests/special_characters/SConscript
libs/nanopb/tests/special_characters/funny-proto+name has.characters.proto
libs/nanopb/tests/splint/SConscript
libs/nanopb/tests/splint/splint.rc
libs/nanopb/tools/make_linux_package.sh
libs/nanopb/tools/make_mac_package.sh
libs/nanopb/tools/make_windows_package.sh
libs/nanopb/tools/set_version.sh
libs/openxc-message-format/.gitignore
libs/openxc-message-format/CHANGELOG.md
libs/openxc-message-format/CMakeLists.txt
libs/openxc-message-format/JSON.mkd
libs/openxc-message-format/LICENSE
libs/openxc-message-format/README.md
libs/openxc-message-format/benchmark/proto/.gitignore
libs/openxc-message-format/benchmark/proto/compare_sizes.py
libs/openxc-message-format/gen/README.mkd
libs/openxc-message-format/gen/cpp/openxc.pb.c
libs/openxc-message-format/gen/cpp/openxc.pb.h
libs/openxc-message-format/gen/java/com/openxc/BinaryMessages.java
libs/openxc-message-format/gen/python/openxc_pb2.py
libs/openxc-message-format/openxc.options
libs/openxc-message-format/openxc.proto
libs/openxc-message-format/pip-requirements.txt
libs/openxc-message-format/script/bootstrap.sh
libs/uds-c/.gitignore
libs/uds-c/.travis.yml
libs/uds-c/CHANGELOG.mkd
libs/uds-c/CMakeLists.txt
libs/uds-c/LICENSE
libs/uds-c/README.mkd
libs/uds-c/runtests.sh
libs/uds-c/src/uds/extras.c
libs/uds-c/src/uds/extras.h
libs/uds-c/src/uds/uds.c
libs/uds-c/src/uds/uds.h
libs/uds-c/src/uds/uds_types.h
libs/uds-c/tests/common.c
libs/uds-c/tests/test_core.c
low-can-binding/CMakeLists.txt
low-can-binding/binding/application-generated.cpp
low-can-binding/binding/application.cpp
low-can-binding/binding/application.hpp
low-can-binding/binding/low-can-apidef.h
low-can-binding/binding/low-can-apidef.json
low-can-binding/binding/low-can-cb.cpp
low-can-binding/binding/low-can-hat.hpp
low-can-binding/binding/low-can-socket.cpp
low-can-binding/binding/low-can-socket.hpp
low-can-binding/binding/low-can-subscription.cpp
low-can-binding/binding/low-can-subscription.hpp
low-can-binding/can/can-bus-device.hpp
low-can-binding/can/can-bus.cpp
low-can-binding/can/can-bus.hpp
low-can-binding/can/can-command.hpp
low-can-binding/can/can-decoder.cpp
low-can-binding/can/can-decoder.hpp
low-can-binding/can/can-encoder.cpp
low-can-binding/can/can-encoder.hpp
low-can-binding/can/can-message-definition.cpp
low-can-binding/can/can-message-definition.hpp
low-can-binding/can/can-message-set.cpp
low-can-binding/can/can-message-set.hpp
low-can-binding/can/can-message.cpp
low-can-binding/can/can-message.hpp
low-can-binding/can/can-signals.cpp
low-can-binding/can/can-signals.hpp
low-can-binding/diagnostic/active-diagnostic-request.cpp
low-can-binding/diagnostic/active-diagnostic-request.hpp
low-can-binding/diagnostic/diagnostic-manager.cpp
low-can-binding/diagnostic/diagnostic-manager.hpp
low-can-binding/diagnostic/diagnostic-message.cpp
low-can-binding/diagnostic/diagnostic-message.hpp
low-can-binding/utils/config-parser.cpp
low-can-binding/utils/config-parser.hpp
low-can-binding/utils/openxc-utils.cpp
low-can-binding/utils/openxc-utils.hpp
low-can-binding/utils/signals.cpp
low-can-binding/utils/signals.hpp
low-can-binding/utils/socketcan-bcm.cpp
low-can-binding/utils/socketcan-bcm.hpp
low-can-binding/utils/socketcan-raw.cpp
low-can-binding/utils/socketcan-raw.hpp
low-can-binding/utils/socketcan.cpp
low-can-binding/utils/socketcan.hpp
low-can-binding/utils/timer.cpp
low-can-binding/utils/timer.hpp