Code Review / apps / agl-service-can-low-level.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 3f50479) | patch
socketcan-bcm: Fix wrongly opened socket 33/23233/6
authorRomain Forlot <romain.forlot@iot.bzh>
Mon, 25 Nov 2019 14:04:07 +0000 (15:04 +0100)
committerRomain Forlot <romain.forlot@iot.bzh>
Thu, 9 Jan 2020 14:55:03 +0000 (15:55 +0100)
commitd1530f94446bf69599664b0341be35317e18b8b5
tree101a0e86b4b4fc73843c7338698acedecc363f6ftree | snapshot
parent3f5047992019f9c1d436deb13447a010f0295f02commit | diff
socketcan-bcm: Fix wrongly opened socket

This commit fixes a problem once a bcm socket has been opened
but the following ioctl failed. Before we still return the socket
number instead of returning a negative value as error.
This resulted in problem because the subscription was considered as valid
and binding was continuing using the closed file descriptor.

Bug-AGL: SPEC-2988

Change-Id: Iaa64e7bb00980cb8c0e7080aca238cfb57d628b6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
low-can-binding/utils/socketcan-bcm.cpp diff | blob | history
Low level CAN service made to decode and write on CAN bus.