Code Review / apps / agl-service-can-low-level.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 453a681) | patch
decoder/encoder: simplification of code.
authorRomain Forlot <romain.forlot@iot.bzh>
Sat, 23 Nov 2019 11:42:01 +0000 (12:42 +0100)
committerRomain Forlot <romain.forlot@iot.bzh>
Tue, 3 Dec 2019 18:46:26 +0000 (19:46 +0100)
commitb77ee60ae34430fb25b05361ddde33565ab65678
treeecaae7ec4e8e2f84e8a681999bfac32a4a3e740etree | snapshot
parent453a68145bc28a8464efedc055dd43359dd8a8a7commit | diff
decoder/encoder: simplification of code.

- Useless tests removed
- Bit operation changed to more readable ones
- Handle correctly mask to decode signal on 1 byte or in-between bytes more clearly.
- using static_cast now instead of C casting method.
- Avoid manual vector initialization and using default constructors instead.
- Avoid using intermediate variables when this isn't necessary.

Change-Id: I049d65f460109772b57df7572bdac8e6500242e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
low-can-binding/can/can-decoder.cpp diff | blob | history
low-can-binding/can/can-encoder.cpp diff | blob | history
Low level CAN service made to decode and write on CAN bus.