X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=test%2Fexec_test.go;h=e7992d60870112fd7906deb87b73bfab25a93c44;hb=5dc2ff003106f0ced38caadb06033f24c792f9b9;hp=ff67322021399d10a9241ea0e92a69f03d684f36;hpb=83fad88204387d196f755c718de40828c08dc7ac;p=src%2Fxds%2Fxds-server.git

diff --git a/test/exec_test.go b/test/exec_test.go
index ff67322..e7992d6 100644
--- a/test/exec_test.go
+++ b/test/exec_test.go
@@ -22,37 +22,32 @@ import (
 	"os/exec"
 	"path"
 	"testing"
-	"time"
 
-	"gerrit.automotivelinux.org/gerrit/src/xds/xds-server/lib/xsapiv1"
-	"github.com/stretchr/testify/assert"
+	"gerrit.automotivelinux.org/gerrit/src/xds/xds-server.git/lib/xsapiv1"
+	"github.com/stretchr/testify/require"
 )
 
 func InitExec(t *testing.T) string {
+	Debugf(t, "Create helloworld directory with app-templates")
+	/*copy helloworld from fixtures to envRootCfgDir*/
 	helloworldDir := path.Join(os.Getenv(envRootCfgDir), "helloworld")
 	cmd := exec.Command("cp", "-r", helloworldFixturesDir, helloworldDir)
 	var out bytes.Buffer
 	cmd.Stdout = &out
-	assert.Nil(t, cmd.Run())
+	require.Nil(t, cmd.Run())
+
+	/*clone submodules app templates into helloworld*/
 	subHelloworldAppTemplateDir := path.Join(helloworldDir, "conf.d", "app-templates")
-	cmd = exec.Command("git", "clone", "https://gerrit.automotivelinux.org/gerrit/p/apps/app-templates.git", subHelloworldAppTemplateDir)
-	assert.Nil(t, cmd.Run())
+	cmd = exec.Command("git", "clone", "-b", "flounder",
+		"https://gerrit.automotivelinux.org/gerrit/p/apps/app-templates.git",
+		subHelloworldAppTemplateDir)
+	require.Nil(t, cmd.Run())
 	return helloworldDir
 }
 
-/*flush channel with timeout*/
-func flushChannelExec(channel chan xsapiv1.ExecOutMsg, ms time.Duration) {
-	timeoutB := false
-	for !timeoutB {
-		select {
-		case <-channel:
-		case <-time.After(ms * time.Millisecond):
-			timeoutB = true
-		}
-	}
-}
 func TestExec(t *testing.T) {
 	helloworldDir := InitExec(t)
+	/*channel for SDK events*/
 	chSdks := make(chan xsapiv1.SDK)
 	defer close(chSdks)
 	sdk := xsapiv1.SDKInstallArgs{
@@ -63,9 +58,10 @@ func TestExec(t *testing.T) {
 	ConnectSDKStateChange(t, sCli, chSdks)
 	sdkRes := installFakeSdk(t, sdk, chSdks)
 
+	/*check there is no project*/
 	var cfgArray []xsapiv1.FolderConfig
-	assert.Nil(t, HTTPCli.Get("/folders", &cfgArray))
-	assert.Equal(t, len(cfgArray), 0)
+	require.Nil(t, HTTPCli.Get("/folders", &cfgArray))
+	require.Equal(t, len(cfgArray), 0)
 
 	fPrj := xsapiv1.FolderConfig{
 		Label:      "testproject",
@@ -76,22 +72,50 @@ func TestExec(t *testing.T) {
 			ServerPath: helloworldDir,
 		},
 	}
+	/*create project*/
 	var cfg xsapiv1.FolderConfig
-	assert.Nil(t, HTTPCli.Post("/folders", fPrj, &cfg))
-	assert.NotNil(t, cfg)
+	require.Nil(t, HTTPCli.Post("/folders", fPrj, &cfg))
+	require.NotNil(t, cfg)
 
-	chExec := make(chan xsapiv1.ExecOutMsg)
+	/*channel for ExecExitMsg*/
+	chExec := make(chan xsapiv1.ExecExitMsg)
 	defer close(chExec)
-	sCli.Conn.On(xsapiv1.ExecOutEvent, func(ev xsapiv1.ExecOutMsg) {
+	sCli.Conn.On(xsapiv1.ExecExitEvent, func(ev xsapiv1.ExecExitMsg) {
 		chExec <- ev
 	})
 
-	sdkSourceFile := path.Join(sdkRes.Path, "environment-setup-corei7-64-native-linux")
-	cmd := "source " + sdkSourceFile
-	cmd = cmd + " && "
-	cmd = cmd + "unset SDKTARGETSYSROOT"
-	cmd = cmd + " && "
-	cmd = cmd + "cd " + fPrj.ClientPath
+	/*Collect commands output in */
+	cmdOut := ""
+	sCli.Conn.On(xsapiv1.ExecOutEvent, func(ev xsapiv1.ExecOutMsg) {
+		cmdOut += ev.Stdout + ev.Stderr
+	})
+	/*error when exec with fakeid*/
+	var execRes xsapiv1.ExecArgs
+	cmd := "pwd && echo \"SDKTARGETSYSROOT=<$SDKTARGETSYSROOT>\""
+	exec := xsapiv1.ExecArgs{
+		ID:    cfg.ID,
+		Cmd:   cmd,
+		SdkID: "11111-invalid",
+	}
+	Debugf(t, "exec cmake cmd(%v)", cmd)
+	cmdOut = ""
+	require.NotNil(t, HTTPCli.Post("/exec", exec, &execRes))
+
+	/*basic check: verify that environment is set correctly (use the right sdk)*/
+	cmd = "pwd && echo \"SDKTARGETSYSROOT=<$SDKTARGETSYSROOT>\""
+	exec = xsapiv1.ExecArgs{
+		ID:    cfg.ID,
+		Cmd:   cmd,
+		SdkID: sdkRes.ID,
+	}
+	Debugf(t, "exec cmake cmd(%v)", cmd)
+	cmdOut = ""
+	require.Nil(t, HTTPCli.Post("/exec", exec, &execRes))
+	exitMsg := <-chExec
+	require.Equal(t, exitMsg.Code, 0)
+
+	/*cmake helloworld project with fake sdk*/
+	cmd = "cd " + fPrj.ClientPath
 	cmd = cmd + " && "
 	cmd = cmd + "mkdir -p build"
 	cmd = cmd + " && "
@@ -99,33 +123,36 @@ func TestExec(t *testing.T) {
 	cmd = cmd + " && "
 	cmd = cmd + "cmake .."
 
-	exec := xsapiv1.ExecArgs{
+	/*post exec cmd cmake*/
+	exec = xsapiv1.ExecArgs{
 		ID:  cfg.ID,
 		Cmd: cmd,
 	}
-	var execRes xsapiv1.ExecArgs
-	assert.Nil(t, HTTPCli.Post("/exec", exec, &execRes))
-	flushChannelExec(chExec, 1000)
+	Debugf(t, "exec cmake cmd(%v)", cmd)
+	require.Nil(t, HTTPCli.Post("/exec", exec, &execRes))
+	exitMsg = <-chExec
+	require.Equal(t, exitMsg.Code, 0)
 
-	cmd = "source " + sdkSourceFile
-	cmd = cmd + " && "
-	cmd = cmd + "unset SDKTARGETSYSROOT"
-	cmd = cmd + " && "
-	cmd = cmd + "cd " + fPrj.ClientPath
+	/*make helloworld project with fake sdk*/
+	cmd = "cd " + fPrj.ClientPath
 	cmd = cmd + "&&"
 	cmd = cmd + "cd build"
 	cmd = cmd + "&&"
 	cmd = cmd + "make"
 	exec.Cmd = cmd
-	assert.Nil(t, HTTPCli.Post("/exec", exec, &execRes))
-	flushChannelExec(chExec, 1000)
+	/*post exec cmd make*/
+	Debugf(t, "exec make cmd(%v)", cmd)
+	require.Nil(t, HTTPCli.Post("/exec", exec, &execRes))
+	exitMsg = <-chExec
+	require.Equal(t, exitMsg.Code, 0)
 
-	/*check afb-helloworld.so exists*/
+	/*check if helloworld.so exists*/
+	Debug(t, "check that helloworld.so exists")
 	_, err := os.Stat(path.Join(fPrj.ClientPath, "build/helloworld/helloworld.so"))
-	assert.Nil(t, err)
-
-	assert.Nil(t, HTTPCli.Delete("/folders/"+cfg.ID, &cfg))
+	require.Nil(t, err)
 
+	/*deinit*/
+	require.Nil(t, HTTPCli.Delete("/folders/"+cfg.ID, &cfg))
 	RemoveSdk(t, sdkRes, chSdks)
 	DisconnectSDKStateChange(t, sCli)
 }