X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fwgtpkg-install.c;h=b5f0a402d4d543e8b3c9d33587e4e9f773d755e5;hb=5dfdd50634783bc9174d0ed0287e1f673b02f2ac;hp=264606a118e144202f8026fa68de8ce84bdb949b;hpb=2c6fcae14552ab6e7addc82516617a135f86b5ca;p=src%2Fapp-framework-main.git

diff --git a/src/wgtpkg-install.c b/src/wgtpkg-install.c
index 264606a..b5f0a40 100644
--- a/src/wgtpkg-install.c
+++ b/src/wgtpkg-install.c
@@ -38,6 +38,10 @@
 #include "secmgr-wrap.h"
 #include "utils-dir.h"
 
+static const char permission_required[] = "required";
+static const char permission_optional[] = "optional";
+static const char feature_required_permissions[] = FWK_PREFIX "required-permissions";
+
 static int check_defined(const void *data, const char *name)
 {
 	if (data)
@@ -56,14 +60,19 @@ static int check_valid_string(const char *value, const char *name)
 		return -1;
 	pos = 0;
 	c = value[pos];
-	while(c) {
+	if (c == 0) {
+		ERROR("empty string forbidden in '%s' (temporary constraints)", name);
+		errno = EINVAL;
+		return -1;			
+	}
+	do {
 		if (!isalnum(c) && !strchr(".-_", c)) {
 			ERROR("forbidden char %c in '%s' -> '%s' (temporary constraints)", c, name, value);
 			errno = EINVAL;
 			return -1;			
 		}
 		c = value[++pos];
-	}
+	} while(c);
 	return 0;
 }
 
@@ -84,20 +93,34 @@ static int check_temporary_constraints(const struct wgt_desc *desc)
 	return 0;
 }
 
-static int check_permissions(const char *name, int required)
+static int set_required_permissions(struct wgt_desc_param *params, int required)
 {
-	if (permission_exists(name)) {
-		if (request_permission(name)) {
-			DEBUG("granted permission: %s", name);
-		} else if (required) {
-			ERROR("ungranted permission required: %s", name);
+	int optional;
+
+	while (params) {
+		/* check the value */
+		if (!strcmp(params->value, permission_required))
+			optional = !required;
+		else if (!strcmp(params->value, permission_optional))
+			optional = 1;
+		else {
+			ERROR("unexpected parameter value: %s found for %s", params->value, params->name);
 			errno = EPERM;
-			return 0;
+			return -1;
+		}
+		/* set the permission */
+		if (request_permission(params->name)) {
+			DEBUG("granted permission: %s", params->name);
+		} else if (optional) {
+			INFO("optional permission ungranted: %s", params->name);
 		} else {
-			INFO("ungranted permission optional: %s", name);
+			ERROR("ungranted permission required: %s", params->name);
+			errno = EPERM;
+			return -1;
 		}
+		params = params->next;
 	}
-	return 1;
+	return 0;
 }
 
 static int check_widget(const struct wgt_desc *desc)
@@ -107,9 +130,9 @@ static int check_widget(const struct wgt_desc *desc)
 
 	result = check_temporary_constraints(desc);
 	feature = desc->features;
-	while(feature) {
-		if (!check_permissions(feature->name, feature->required))
-			result = -1;
+	while(result >= 0 && feature) {
+		if (!strcmp(feature->name, feature_required_permissions))
+			result = set_required_permissions(feature->params, feature->required);
 		feature = feature->next;
 	}
 	return result;
@@ -248,6 +271,7 @@ struct wgt_info *install_widget(const char *wgtfile, const char *root, int force
 	if (!ifo)
 		goto error2;
 
+	reset_requested_permissions();
 	desc = wgt_info_desc(ifo);
 	if (check_widget(desc))
 		goto error3;