X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fwgtpkg-install.c;h=b3e4603f0e75aab29a24ded2ac79ee19edfbc681;hb=c0fc18e47e49dd4e3cc2f09452a19297dad63f9c;hp=dc746c283a7e2d8e26ed4eb16d8a30a575b2b857;hpb=7e1027342a3cff95635ba2107f283321cf0efa08;p=src%2Fapp-framework-main.git

diff --git a/src/wgtpkg-install.c b/src/wgtpkg-install.c
index dc746c2..b3e4603 100644
--- a/src/wgtpkg-install.c
+++ b/src/wgtpkg-install.c
@@ -1,6 +1,8 @@
 /*
  Copyright 2015 IoT.bzh
 
+ author: José Bollo <jose.bollo@iot.bzh>
+
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at
@@ -17,21 +19,23 @@
 #define _GNU_SOURCE
 
 #include <errno.h>
-#include <syslog.h>
 #include <string.h>
 #include <ctype.h>
+#include <assert.h>
+#include <unistd.h>
 
 #include "verbose.h"
 #include "wgtpkg.h"
 #include "wgt.h"
 #include "wgt-info.h"
 #include "secmgr-wrap.h"
+#include "utils-dir.h"
 
 static int check_defined(const void *data, const char *name)
 {
 	if (data)
 		return 0;
-	syslog(LOG_ERR, "widget has no defined '%s' (temporary constraints)", name);
+	ERROR("widget has no defined '%s' (temporary constraints)", name);
 	errno = EINVAL;
 	return -1;
 }
@@ -47,7 +51,7 @@ static int check_valid_string(const char *value, const char *name)
 	c = value[pos];
 	while(c) {
 		if (!isalnum(c) && !strchr(".-_", c)) {
-			syslog(LOG_ERR, "forbidden char %c in '%s' -> '%s' (temporary constraints)", c, name, value);
+			ERROR("forbidden char %c in '%s' -> '%s' (temporary constraints)", c, name, value);
 			errno = EINVAL;
 			return -1;			
 		}
@@ -65,7 +69,7 @@ static int check_temporary_constraints(const struct wgt_desc *desc)
 	if (result)
 		return result;
 	if (desc->icons->next) {
-		syslog(LOG_ERR, "widget has more than one icon defined (temporary constraints)");
+		ERROR("widget has more than one icon defined (temporary constraints)");
 		errno = EINVAL;
 		result = -1;
 	}
@@ -76,13 +80,13 @@ static int check_permissions(const char *name, int required)
 {
 	if (permission_exists(name)) {
 		if (request_permission(name)) {
-			debug("granted permission: %s", name);
+			DEBUG("granted permission: %s", name);
 		} else if (required) {
-			syslog(LOG_ERR, "ungranted permission required: %s", name);
+			ERROR("ungranted permission required: %s", name);
 			errno = EPERM;
 			return 0;
 		} else {
-			notice("ungranted permission optional: %s", name);
+			INFO("ungranted permission optional: %s", name);
 		}
 	}
 	return 1;
@@ -110,7 +114,7 @@ static int move_widget(const char *root, const struct wgt_desc *desc, int force)
 
 	rc = snprintf(newdir, sizeof newdir, "%s/%s/%s", root, desc->id, desc->version);
 	if (rc >= sizeof newdir) {
-		syslog(LOG_ERR, "path to long: %s/%s/%s", root, desc->id, desc->version);
+		ERROR("path to long in move_widget");
 		errno = EINVAL;
 		return -1;
 	}
@@ -118,11 +122,97 @@ static int move_widget(const char *root, const struct wgt_desc *desc, int force)
 	return move_workdir(newdir, 1, force);
 }
 
-static int install_security(struct wgt_info *ifo)
+static int install_icon(const struct wgt_desc *desc)
 {
+	char link[PATH_MAX];
+	char target[PATH_MAX];
 	int rc;
 
-	rc = secmgr_init(wgt_info_desc(ifo)->
+	create_directory(FWK_ICON_DIR, 0755, 1);
+	rc = snprintf(link, sizeof link, "%s/%s@%s", FWK_ICON_DIR, desc->id, desc->version);
+	if (rc >= sizeof link) {
+		ERROR("link to long in install_icon");
+		errno = EINVAL;
+		return -1;
+	}
+
+	rc = snprintf(target, sizeof target, "%s/%s", workdir, desc->icons->src);
+	if (rc >= sizeof target) {
+		ERROR("target to long in install_icon");
+		errno = EINVAL;
+		return -1;
+	}
+
+	unlink(link);
+	rc = symlink(target, link);
+	if (rc)
+		ERROR("can't create link %s -> %s", link, target);
+	return rc;
+}
+
+static int install_security(const struct wgt_desc *desc)
+{
+	char path[PATH_MAX], *head;
+	const char *icon, *perm;
+	int rc, len, lic, lf;
+	unsigned int i, n;
+	struct filedesc *f;
+
+	rc = secmgr_init(desc->id);
+	if (rc)
+		goto error;
+
+	rc = secmgr_path_public_read_only(workdir);
+	if (rc)
+		goto error2;
+
+	/* instal the files */
+	head = stpcpy(path, workdir);
+	assert(sizeof path > (head - path));
+	len = (int)(sizeof path - (head - path));
+	if (!len) {
+		ERROR("root path too long in install_security");
+		errno = ENAMETOOLONG;
+		goto error2;
+	}
+	len--;
+	*head++ = '/';
+	icon = desc->icons->src;
+	lic = (int)strlen(icon);
+	n = file_count();
+	i = 0;
+	while(i < n) {
+		f = file_of_index(i++);
+		lf = (int)strlen(f->name);
+		if (lf >= len) {
+			ERROR("path too long in install_security");
+			errno = ENAMETOOLONG;
+			goto error2;
+		}
+		strcpy(head, f->name);
+		if (lf <= lic && !memcmp(f->name, icon, lf) && (!f->name[lf] || f->name[lf] == '/'))
+			rc = secmgr_path_public_read_only(path);
+		else
+			rc = secmgr_path_read_only(path);
+		if (rc)
+			goto error2;
+	}
+
+	/* install the permissions */
+	perm = first_usable_permission();
+	while(perm) {
+		rc = secmgr_permit(perm);
+		if (rc)
+			goto error2;
+		perm = next_usable_permission();
+	}
+
+	rc = secmgr_install();
+	return rc;
+error2:
+	secmgr_cancel();
+error:
+	return -1;
 }
 
 /* install the widget of the file */
@@ -131,11 +221,12 @@ void install_widget(const char *wgtfile, const char *root, int force)
 	struct wgt_info *ifo;
 	const struct wgt_desc *desc;
 
-	notice("-- INSTALLING widget %s --", wgtfile);
+	NOTICE("-- INSTALLING widget %s --", wgtfile);
 
 	/* workdir */
-	if (make_workdir_base(root, "UNPACK", 0)) {
-		syslog(LOG_ERR, "failed to create a working directory");
+	create_directory(root, 0755, 1);
+	if (make_workdir_base(root, "TMP", 0)) {
+		ERROR("failed to create a working directory");
 		goto error1;
 	}
 
@@ -156,7 +247,11 @@ void install_widget(const char *wgtfile, const char *root, int force)
 	if (move_widget(root, desc, force))
 		goto error3;
 
-	
+	if (install_icon(desc))
+		goto error3;
+
+	if (install_security(desc))
+		goto error3;
 	
 	return;