X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fwgtpkg-install.c;h=096903b5d5776820a492be50d9e724229188c591;hb=6c6177fcf8fdcc62c42a18407e95c7577897e10c;hp=ee21d8fb57d533dacc54d137698dd116d6afbb5b;hpb=9ab266df6642c6e930e03b3024d7c3d53ef88bbc;p=src%2Fapp-framework-main.git diff --git a/src/wgtpkg-install.c b/src/wgtpkg-install.c index ee21d8f..096903b 100644 --- a/src/wgtpkg-install.c +++ b/src/wgtpkg-install.c @@ -19,33 +19,58 @@ #include #include #include +#include +#include +#include #include "verbose.h" #include "wgtpkg.h" #include "wgt.h" #include "wgt-info.h" +#include "secmgr-wrap.h" +#include "utils-dir.h" -static int check_temporary_constraints(const struct wgt_desc *desc) +static int check_defined(const void *data, const char *name) { - if (!desc->icons) { - syslog(LOG_ERR, "widget has not icon defined (temporary constraints)"); - errno = EINVAL; + if (data) + return 0; + ERROR("widget has no defined '%s' (temporary constraints)", name); + errno = EINVAL; + return -1; +} + +static int check_valid_string(const char *value, const char *name) +{ + int pos; + char c; + + if (check_defined(value, name)) return -1; + pos = 0; + c = value[pos]; + while(c) { + if (!isalnum(c) && !strchr(".-_", c)) { + ERROR("forbidden char %c in '%s' -> '%s' (temporary constraints)", c, name, value); + errno = EINVAL; + return -1; + } + c = value[++pos]; } + return 0; +} + +static int check_temporary_constraints(const struct wgt_desc *desc) +{ + int result = check_valid_string(desc->id, "id"); + result |= check_valid_string(desc->version, "version"); + result |= check_defined(desc->icons, "icon"); + result |= check_defined(desc->content_src, "content"); + if (result) + return result; if (desc->icons->next) { - syslog(LOG_ERR, "widget has more than one icon defined (temporary constraints)"); + ERROR("widget has more than one icon defined (temporary constraints)"); errno = EINVAL; - return -1; - } - if (!desc->content_src) { - syslog(LOG_ERR, "widget has not content defined (temporary constraints)"); - errno = EINVAL; - return -1; - } - if (!desc->content_type) { - syslog(LOG_ERR, "widget has not type for its content (temporary constraints)"); - errno = EINVAL; - return -1; + result = -1; } return 0; } @@ -54,13 +79,13 @@ static int check_permissions(const char *name, int required) { if (permission_exists(name)) { if (request_permission(name)) { - debug("granted permission: %s", name); + DEBUG("granted permission: %s", name); } else if (required) { - syslog(LOG_ERR, "ungranted permission required: %s", name); + ERROR("ungranted permission required: %s", name); errno = EPERM; return 0; } else { - notice("ungranted permission optional: %s", name); + INFO("ungranted permission optional: %s", name); } } return 1; @@ -70,37 +95,123 @@ static int check_widget(const struct wgt_desc *desc) { int result; const struct wgt_desc_feature *feature; - const char *name; result = check_temporary_constraints(desc); feature = desc->features; while(feature) { - name = feature->name; - if (0 == strcmp(name, AGLWIDGET)) { - - } else { - if (!check_permissions(feature->name, feature->required)) - result = -1; - } + if (!check_permissions(feature->name, feature->required)) + result = -1; feature = feature->next; } return result; } -static int place(const char *root, const char *appid, const char *version, int force) +static int move_widget(const char *root, const struct wgt_desc *desc, int force) { char newdir[PATH_MAX]; int rc; - rc = snprintf(newdir, sizeof newdir, "%s/%s/%s", root, appid, version); + rc = snprintf(newdir, sizeof newdir, "%s/%s/%s", root, desc->id, desc->version); if (rc >= sizeof newdir) { - syslog(LOG_ERR, "path to long: %s/%s/%s", root, appid, version); + ERROR("path to long in move_widget"); errno = EINVAL; return -1; } - rc = move_workdir(newdir, 1, force); + return move_workdir(newdir, 1, force); +} + +static int install_icon(const struct wgt_desc *desc) +{ + char link[PATH_MAX]; + char target[PATH_MAX]; + int rc; + + create_directory(FWK_ICON_DIR, 0755, 1); + rc = snprintf(link, sizeof link, "%s/%s@%s", FWK_ICON_DIR, desc->id, desc->version); + if (rc >= sizeof link) { + ERROR("link to long in install_icon"); + errno = EINVAL; + return -1; + } + + rc = snprintf(target, sizeof target, "%s/%s", workdir, desc->icons->src); + if (rc >= sizeof target) { + ERROR("target to long in install_icon"); + errno = EINVAL; + return -1; + } + + unlink(link); + rc = symlink(target, link); + if (rc) + ERROR("can't create link %s -> %s", link, target); + return rc; +} + +static int install_security(const struct wgt_desc *desc) +{ + char path[PATH_MAX], *head; + const char *icon, *perm; + int rc, len, lic, lf; + unsigned int i, n; + struct filedesc *f; + + rc = secmgr_init(desc->id); + if (rc) + goto error; + + rc = secmgr_path_public_read_only(workdir); + if (rc) + goto error2; + + /* instal the files */ + head = stpcpy(path, workdir); + assert(sizeof path > (head - path)); + len = (int)(sizeof path - (head - path)); + if (!len) { + ERROR("root path too long in install_security"); + errno = ENAMETOOLONG; + goto error2; + } + len--; + *head++ = '/'; + icon = desc->icons->src; + lic = (int)strlen(icon); + n = file_count(); + i = 0; + while(i < n) { + f = file_of_index(i++); + lf = (int)strlen(f->name); + if (lf >= len) { + ERROR("path too long in install_security"); + errno = ENAMETOOLONG; + goto error2; + } + strcpy(head, f->name); + if (lf <= lic && !memcmp(f->name, icon, lf) && (!f->name[lf] || f->name[lf] == '/')) + rc = secmgr_path_public_read_only(path); + else + rc = secmgr_path_read_only(path); + if (rc) + goto error2; + } + + /* install the permissions */ + perm = first_usable_permission(); + while(perm) { + rc = secmgr_permit(perm); + if (rc) + goto error2; + perm = next_usable_permission(); + } + + rc = secmgr_install(); return rc; +error2: + secmgr_cancel(); +error: + return -1; } /* install the widget of the file */ @@ -109,11 +220,12 @@ void install_widget(const char *wgtfile, const char *root, int force) struct wgt_info *ifo; const struct wgt_desc *desc; - notice("-- INSTALLING widget %s --", wgtfile); + NOTICE("-- INSTALLING widget %s --", wgtfile); /* workdir */ - if (make_workdir_base(root, "UNPACK", 0)) { - syslog(LOG_ERR, "failed to create a working directory"); + create_directory(root, 0755, 1); + if (make_workdir_base(root, "TMP", 0)) { + ERROR("failed to create a working directory"); goto error1; } @@ -131,10 +243,15 @@ void install_widget(const char *wgtfile, const char *root, int force) if (check_widget(desc)) goto error3; -/* - if (check_and_place()) - goto error2; -*/ + if (move_widget(root, desc, force)) + goto error3; + + if (install_icon(desc)) + goto error3; + + if (install_security(desc)) + goto error3; + return; error3: