X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Flow-can-binding.cpp;h=8ecf74243ee89deac7c4b40d83a8b42e6de43029;hb=63d31e29e366fb9dd85debc897fdbc91d9cb2e42;hp=0c418fe8c3d97b1ab26db778bbef591f69104836;hpb=b606db2b74d5c92d33a126071062c9eb2a548beb;p=apps%2Fagl-service-can-low-level.git

diff --git a/src/low-can-binding.cpp b/src/low-can-binding.cpp
index 0c418fe8..8ecf7424 100644
--- a/src/low-can-binding.cpp
+++ b/src/low-can-binding.cpp
@@ -132,7 +132,7 @@ static int subscribe_unsubscribe_signals(struct afb_req request, bool subscribe,
 	for(const std::string& sig : signals)
 	{
 		int ret;
-		if (obd2_signal_t::is_obd2_signal(sig))
+		if (active_diagnostic_request_t::is_diagnostic_signal(sig))
 		{
 			std::vector<obd2_signal_t*> found;
 			configuration_t::instance().find_obd2_signals(build_DynamicField(sig), found);
@@ -252,9 +252,10 @@ extern "C"
 			return 0;
 		}
 
-		/// Initialize Diagnostic manager that will handle obd2 requests
-		diagnostic_manager_t& diag_manager = configuration_t::instance().get_diagnostic_manager();
-		diag_manager.initialize(can_bus_manager.get_can_devices().front());
+		/// Initialize Diagnostic manager that will handle obd2 requests.
+		/// We pass by default the first CAN bus device to its Initialization.
+		/// TODO: be able to choose the CAN bus device that will be use as Diagnostic bus.
+		configuration_t::instance().get_diagnostic_manager().initialize(can_bus_manager.get_can_devices().front());
 
 		ERROR(binder_interface, "There was something wrong with CAN device Initialization. Check your config file maybe");
 		return 1;