X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fhs-clientmanager.cpp;h=7d1407e16b24eec3884cb08fe583ae0ba89d19d6;hb=refs%2Ftags%2Fmarlin_12.90.0;hp=1355c99517c25169311f0e9987a97ce052739423;hpb=b730d31a7e5e23756ab1b076de21d41369a500c5;p=apps%2Fagl-service-homescreen.git

diff --git a/src/hs-clientmanager.cpp b/src/hs-clientmanager.cpp
index 1355c99..7d1407e 100644
--- a/src/hs-clientmanager.cpp
+++ b/src/hs-clientmanager.cpp
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018 TOYOTA MOTOR CORPORATION
+ * Copyright (C) 2020 Konsulko Group
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,9 +14,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+#include <cstring>
 #include <algorithm>
+#include <cassert>
+#include "hs-proxy.h"
 #include "hs-clientmanager.h"
-#include "hmi-debug.h"
 
 static const char _homescreen[] = "homescreen";
 
@@ -70,7 +74,7 @@ HS_ClientManager* HS_ClientManager::instance(void)
  */
 int HS_ClientManager::init(void)
 {
-    HMI_NOTICE("homescreen-service","called.");
+    return 0;
 }
 
 /**
@@ -88,11 +92,14 @@ HS_ClientCtxt* HS_ClientManager::createClientCtxt(afb_req_t req, std::string app
     HS_ClientCtxt *ctxt = (HS_ClientCtxt *)afb_req_context_get(req);
     if (!ctxt)
     {
-        HMI_NOTICE("homescreen-service", "create new session for %s", appid.c_str());
-        HS_ClientCtxt *ctxt = new HS_ClientCtxt(appid.c_str());
+        AFB_INFO( "create new session for %s", appid.c_str());
+        ctxt = new HS_ClientCtxt(appid);
         afb_req_session_set_LOA(req, 1);
         afb_req_context_set(req, ctxt, cbRemoveClientCtxt);
+
+	appid2ctxt[appid] = ctxt;
     }
+
     return ctxt;
 }
 
@@ -142,324 +149,136 @@ void HS_ClientManager::removeClientCtxt(void *data)
     HS_ClientCtxt *ctxt = (HS_ClientCtxt *)data;
     if(ctxt == nullptr)
     {
-        HMI_ERROR("homescreen-service", "data is nullptr");
+        AFB_WARNING( "data is nullptr");
         return;
     }
 
-    HMI_NOTICE("homescreen-service", "remove app %s", ctxt->id.c_str());
+    AFB_INFO( "remove app %s", ctxt->id.c_str());
     std::lock_guard<std::mutex> lock(this->mtx);
     removeClient(ctxt->id);
     delete appid2ctxt[ctxt->id];
     appid2ctxt.erase(ctxt->id);
 }
 
-/**
- * tap_shortcut
- *
- * #### Parameters
- *  - request: the request to bindings
- *
- * #### Return
- * result
- *
- */
-int HS_ClientManager::tap_shortcut(afb_req_t request)
+static int
+is_application_running(std::string appid, std::unordered_map<std::string, HS_Client*> client_list)
 {
-    int ret = 0;
-    const char* value = afb_req_value(request, _application_id);
-    if (value) {
-        HMI_NOTICE("homescreen-service","request params = %s.", value);
-        std::lock_guard<std::mutex> lock(this->mtx);
-        auto ip = client_list.find(std::string(value));
-        if(ip != client_list.end()) {
-            ip->second->tap_shortcut(value);
-        }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input application_id");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
-}
+    bool app_still_running = false;
 
-/**
- * on_screen_message
- *
- * #### Parameters
- *  - request: the request to bindings
- *
- * #### Return
- * result
- *
- */
-int HS_ClientManager::on_screen_message(afb_req_t request)
-{
-    int ret = 0;
-    const char* value = afb_req_value(request, _display_message);
-    if (value) {
-        HMI_NOTICE("homescreen-service","request params = %s.", value);
-        std::lock_guard<std::mutex> lock(this->mtx);
-        for(auto m : client_list) {
-            m.second->on_screen_message(request, value);
-        }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input display_message");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
-}
+    std::string id(appid);
+    auto ip = client_list.find(id);
 
-/**
- * on_screen_reply
- *
- * #### Parameters
- *  - request: the request to bindings
- *
- * #### Return
- * result
- *
- */
-int HS_ClientManager::on_screen_reply(afb_req_t request)
-{
-    int ret = 0;
-    const char* value = afb_req_value(request, _reply_message);
-    if (value) {
-      HMI_NOTICE("homescreen-service","request params = %s.", value);
-      std::lock_guard<std::mutex> lock(this->mtx);
-      for(auto m : client_list) {
-        m.second->on_screen_reply(request, value);
-      }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input reply_message");
-        ret = AFB_EVENT_BAD_REQUEST;
+    // this will always be case as the removeClientCtxt() is never called as
+    // clients do not handle the subscribe at all at this point. Not only that
+    // but is redudant but we keep at as it to highlight the fact that we're
+    // missing a feature to check if applications died or not (legitimate or not).
+    //
+    // Using ps (HS_AfmMainProxy::ps -- a sync version of checking if running
+    // applications) seem to block in afm-system-daemon (see SPEC-3902), and
+    // doing w/ it with an async version of ps doesn't work because we don't
+    // have a valid clientCtx (required, and only possible if the application
+    // subscribed themselves, which no longer happens)
+    //
+    // FIXME: We need another way of handling this would be necessary to correctly
+    // handle the case where the app died.
+    if (ip != client_list.end()) {
+        app_still_running = true;
     }
-    return ret;
-}
-
-/**
- * subscribe
- *
- * #### Parameters
- *  - request: the request to bindings
- *
- * #### Return
- * result
- *
- */
-int HS_ClientManager::subscribe(afb_req_t request)
-{
-    int ret = 0;
-    const char *value = afb_req_value(request, "event");
-    HMI_NOTICE("homescreen-service","value is %s", value);
-    if(value) {
-        std::string appid =std::move(get_application_id(request));
-        if(appid.empty()) {
-            HMI_NOTICE("homescreen-service","can't get application identifier");
-            return AFB_REQ_GETAPPLICATIONID_ERROR;
-        }
 
-        std::lock_guard<std::mutex> lock(this->mtx);
-        HS_Client* client = nullptr;
-        auto ip = client_list.find(appid);
-        if(ip != client_list.end()) {
-            client = client_list[appid];
-        }
-        else {
-            appid2ctxt[appid] = createClientCtxt(request, appid);
-            client = addClient(request, appid);
-        }
-
-        if(client->subscribe(request, value) != 0) {
-            HMI_NOTICE("homescreen-service","subscribe failed");
-            ret = AFB_REQ_SUBSCRIBE_ERROR;
-        }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input event name");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
+    // > 0 means err
+    return app_still_running != true;
 }
 
 /**
- * unsubscribe
- *
- * #### Parameters
- *  - request: the request to bindings
- *
- * #### Return
- * result
- *
- */
-int HS_ClientManager::unsubscribe(afb_req_t request)
-{
-    const char *value = afb_req_value(request, "event");
-    HMI_NOTICE("homescreen-service","value is %s", value);
-    int ret = 0;
-    if(value) {
-        std::string appid = std::move(get_application_id(request));
-        if(appid.empty()) {
-            HMI_NOTICE("homescreen-service","can't get application identifier");
-            return AFB_REQ_GETAPPLICATIONID_ERROR;
-        }
-
-        std::lock_guard<std::mutex> lock(this->mtx);
-        auto ip = client_list.find(appid);
-        if(ip != client_list.end()
-        && ip->second->unsubscribe(request, value) != 0) {
-            HMI_NOTICE("homescreen-service","unsubscribe failed");
-            ret = AFB_REQ_UNSUBSCRIBE_ERROR;
-        }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input event name");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
-}
-
-/**
- * showWindow event
+ * handle homescreen request
  *
  * #### Parameters
  *  - request : the request
+ *  - verb : the verb name
+ *  - appid : to which application
  *
  * #### Return
  * 0 : success
  * others : fail
  *
  */
-int HS_ClientManager::showWindow(afb_req_t request)
+int HS_ClientManager::handleRequest(afb_req_t request, const char *verb, const char *appid)
 {
+    AFB_INFO("verb=[%s],appid=[%s].", verb, appid);
     int ret = 0;
-    const char* value = afb_req_value(request, _application_id);
-    if (value) {
-        HMI_NOTICE("homescreen-service","request params = %s.", value);
-        std::lock_guard<std::mutex> lock(this->mtx);
-        auto ip = client_list.find(std::string(value));
-        if(ip != client_list.end()) {
-            ret = ip->second->showWindow(request, value);
+    std::lock_guard<std::mutex> lock(this->mtx);
+    if(appid == nullptr) {
+        for(auto m : client_list) {
+            m.second->handleRequest(request, verb);
         }
     }
     else {
-        HMI_NOTICE("homescreen-service","Please input application_id");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
-}
-
-/**
- * hideWindow event
- *
- * #### Parameters
- *  - request : the request
- *
- * #### Return
- * 0 : success
- * others : fail
- *
- */
-int HS_ClientManager::hideWindow(afb_req_t request)
-{
-    int ret = 0;
-    const char* value = afb_req_value(request, _application_id);
-    if (value) {
-        HMI_NOTICE("homescreen-service","request params = %s.", value);
-        std::lock_guard<std::mutex> lock(this->mtx);
-        auto ip = client_list.find(std::string(value));
-        if(ip != client_list.end()) {
-            ret = ip->second->hideWindow(request);
+        std::string id(appid);
+        auto ip = client_list.find(id);
+	if(ip != client_list.end()) {
+	    // for showWindow verb we need to verify if the app is (still)
+	    // running, and return the appropriate value to attempt to start it
+	    // again. This 'problem' is avoided if the application itself
+	    // subscribes and with that process, to install a callback that
+	    // automatically removes the application from client_list.
+	    // That is exactly how "subscribe" verb is handled below.
+            if (strcasecmp(verb, "showWindow") == 0) {
+                ret = is_application_running(id, client_list);
+                if (ret == AFB_REQ_NOT_STARTED_APPLICATION) {
+                    AFB_INFO("%s is not running. Will attempt to start it", appid);
+                    return ret;
+                }
+            }
+            AFB_INFO("%s found to be running. Forwarding request to the client", appid);
+            ret = ip->second->handleRequest(request, verb);
         }
-    }
-    else {
-        HMI_NOTICE("homescreen-service","Please input application_id");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
-    return ret;
-}
-
-/**
- * replyShowWindow event
- *
- * #### Parameters
- *  - request : the request
- *
- * #### Return
- * 0 : success
- * others : fail
- *
- */
-int HS_ClientManager::replyShowWindow(afb_req_t request)
-{
-    int ret = 0;
-    const char* value = afb_req_value(request, _application_id);
-    if (value) {
-        HMI_NOTICE("homescreen-service","request params = %s.", value);
-        std::lock_guard<std::mutex> lock(this->mtx);
-        auto ip = client_list.find(std::string(value));
-        if(ip != client_list.end()) {
-            ret = ip->second->replyShowWindow(request, value);
+        else {
+            if(!strcasecmp(verb, "subscribe")) {
+                createClientCtxt(request, id);
+                HS_Client* client = addClient(request, id);
+                ret = client->handleRequest(request, "subscribe");
+            }
+            else {
+                AFB_NOTICE("not exist session");
+                ret = AFB_REQ_NOT_STARTED_APPLICATION;
+            }
         }
     }
-    else {
-        HMI_NOTICE("homescreen-service","Please input application_id");
-        ret = AFB_EVENT_BAD_REQUEST;
-    }
     return ret;
 }
 
 /**
- * showNotification event
+ * push event
  *
  * #### Parameters
- *  - request : the request
+ *  - event : the event want to push
+ *  - param : the parameter contents of event
+ *  - appid : the destination application's id
  *
  * #### Return
  * 0 : success
  * others : fail
  *
  */
-int HS_ClientManager::showNotification(afb_req_t request)
+int HS_ClientManager::pushEvent(const char *event, struct json_object *param, std::string appid)
 {
-    int ret = 0;
-    std::lock_guard<std::mutex> lock(this->mtx);
-    auto ip = client_list.find(_homescreen);
-    if(ip != client_list.end()) {
-        ret = ip->second->showNotification(request);
+    if(event == nullptr) {
+        AFB_WARNING("event name is null.");
+        return -1;
     }
-    else {
-        HMI_NOTICE("homescreen-service","not exist sessiion with homescreen");
-        ret = AFB_REQ_SHOWNOTIFICATION_ERROR;
-    }
-
-    return ret;
-}
 
-/**
- * showInformation event
- *
- * #### Parameters
- *  - request : the request
- *
- * #### Return
- * 0 : success
- * others : fail
- *
- */
-int HS_ClientManager::showInformation(afb_req_t request)
-{
-    int ret = 0;
     std::lock_guard<std::mutex> lock(this->mtx);
-    auto ip = client_list.find(_homescreen);
-    if(ip != client_list.end()) {
-        ret = ip->second->showInformation(request);
+    if(appid.empty()) { // broadcast event to clients who subscribed this event
+        for(auto m : client_list) {
+            m.second->pushEvent(event, param);
+        }
     }
-    else {
-        HMI_NOTICE("homescreen-service","not exist sessiion with homescreen");
-        ret = AFB_REQ_SHOWINFORMATION_ERROR;
+    else {  // push event to specific client
+        auto ip = client_list.find(appid);
+        if(ip != client_list.end()) {
+            ip->second->pushEvent(event, param);
+        }
     }
 
-    return ret;
+    return 0;
 }