X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fapp.cpp;h=f925e3da50544d7c7bb0fd8df6144a0e35ff764c;hb=d2fe9e8e49a0970986282162b04d335c57845ac3;hp=353557e7dc5209d0ae6dce3bdbb0a2ffe6c06490;hpb=75524b385a2b3adaa5feabf547b80d412f3a1c56;p=staging%2Fwindowmanager.git

diff --git a/src/app.cpp b/src/app.cpp
index 353557e..f925e3d 100644
--- a/src/app.cpp
+++ b/src/app.cpp
@@ -86,17 +86,17 @@ struct result<layouts_type> load_layout(char const *filename) {
    return Ok(layouts);
 }
 
-struct result<surface_id_to_layer_map>
+struct result<layer_map>
    load_layer_ids(char const *filename) {
    DB("loading IDs from " << filename);
 
    auto j = file_to_json(filename);
    if (j.is_err()) {
-      return Err<surface_id_to_layer_map>(j.unwrap_err());
+      return Err<layer_map>(j.unwrap_err());
    }
    json jids = j.unwrap();
 
-   return to_surface_id_to_layer_map(jids);
+   return to_layer_map(jids);
 }
 
 }  // namespace
@@ -113,19 +113,27 @@ App::App(wl::display *d)
      display{d},
      controller{},
      outputs(),
-     layouts(),  // load_layout("../layout.json").unwrap()),
-     surface2layer(load_layer_ids("../ids.json").unwrap()) {
-   // layouts(load_layout("../layout.json").unwrap()) {
+     layouts(),
+     layers() {
    assert(g_app == nullptr);
    g_app = this;
 
-   try {
+   {
+      auto l = load_layer_ids("../ids.json");
+      if (l.is_ok()) {
+         this->layers = l.unwrap();
+      } else {
+         logerror("%s", l.err().value());
+      }
+   }
+
+   {
       auto l = load_layout("../layout.json");
-      if (l.is_err()) {
-         logerror("Coult not load layout configuration: %s", l.err().value());
+      if (l.is_ok()) {
+         this->layouts = l.unwrap();
+      } else {
+         logerror("%s", l.err().value());
       }
-   } catch (std::exception &e) {
-      logerror("Coult not load layout configuration: %s", e.what());
    }
 }
 
@@ -136,6 +144,11 @@ int App::init() {
       return -1;
    }
 
+   if (this->layers.mapping.empty()) {
+      logerror("No surface -> layer mapping loaded");
+      return -1;
+   }
+
    this->display->add_global_handler(
       "wl_output", [this](wl_registry *r, uint32_t name, uint32_t v) {
          this->outputs.emplace_back(std::make_unique<wl::output>(r, name, v));
@@ -217,7 +230,7 @@ int App::init_layout() {
    // Quick and dirty setup of layers
    // XXX: This likely needs to be sorted by order (note, we don't (yet?)
    // do any zorder arrangement).
-   for (auto const &i : this->surface2layer.mapping) {
+   for (auto const &i : this->layers.mapping) {
       c->layer_create(i.layer_id, o->width, o->height);
       auto &l = layers[i.layer_id];
       l->set_destination_rectangle(0, 0, o->width, o->height);
@@ -227,7 +240,7 @@ int App::init_layout() {
    }
 
    // Add layers to screen (XXX: are they sorted correctly?)
-   s->set_render_order(this->surface2layer.layers);
+   s->set_render_order(this->layers.layers);
 
    c->commit_changes();
 
@@ -244,13 +257,12 @@ int App::init_layout() {
 // |_|
 void App::surface_created(uint32_t surface_id) {
    DB("surface_id is " << surface_id);
-   int layer_id =
-      this->surface2layer.get_layer_for_surface(surface_id).value_or(-1);
+   int layer_id = this->layers.get_layer_id(surface_id).value_or(-1);
    if (layer_id == -1) {
       logerror("Surface %d (0x%x) is not part of any layer!", surface_id,
                surface_id);
    } else {
-      auto rect = this->surface2layer.get_rect_for_surface(surface_id).value();
+      auto rect = this->layers.get_layer_rect(surface_id).value();
       this->controller->add_task(
          "fullscreen surface",
          [layer_id, surface_id, rect](struct genivi::controller *c) {
@@ -261,6 +273,8 @@ void App::surface_created(uint32_t surface_id) {
             int w = rect.w;
             int h = rect.h;
 
+            // less-than-0 values refer to MAX + 1 - $VALUE
+            // e.g. MAX is either screen width or height
             if (w < 0) {
                w = c->output_size.w + 1 + w;
             }
@@ -269,8 +283,11 @@ void App::surface_created(uint32_t surface_id) {
             }
             logdebug("Computed rect={ %d, %d, %d, %d }", x, y, w, h);
 
+            // configure surface to wxh dimensions
             s->set_configuration(w, h);
+            // set source rect to "entire surface"
             s->set_source_rectangle(0, 0, w, h);
+            // set destination to the display rectangle
             s->set_destination_rectangle(x, y, w, h);
 
             s->set_visibility(1);