X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fafb-hsrv.c;h=577ef8540a1789b7b8a11f880ff5a0064a53098b;hb=63c32ff0f0ee13b505d252821fe1fd55816699e1;hp=6bc8ffa3fec779f45c5b75bbe61e13303d419688;hpb=a38382e89710db2c298f7f101e3ba0cf3681287c;p=src%2Fapp-framework-binder.git

diff --git a/src/afb-hsrv.c b/src/afb-hsrv.c
index 6bc8ffa3..577ef854 100644
--- a/src/afb-hsrv.c
+++ b/src/afb-hsrv.c
@@ -118,6 +118,7 @@ static int access_handler(
 		method = get_method(methodstr);
 		method &= afb_method_get | afb_method_post;
 		if (method == afb_method_none) {
+			WARNING("Unsupported HTTP operation %s", methodstr);
 			reply_error(connection, MHD_HTTP_BAD_REQUEST);
 			return MHD_YES;
 		}
@@ -125,6 +126,7 @@ static int access_handler(
 		/* create the request */
 		hreq = calloc(1, sizeof *hreq);
 		if (hreq == NULL) {
+			ERROR("Can't allocate 'hreq'");
 			reply_error(connection, MHD_HTTP_INTERNAL_SERVER_ERROR);
 			return MHD_YES;
 		}
@@ -153,12 +155,15 @@ static int access_handler(
 				hreq->method = afb_method_get;
 			} else if (strcasestr(type, FORM_CONTENT) != NULL) {
 				hreq->postform = MHD_create_post_processor (connection, 65500, postproc, hreq);
-				if (hreq->postform == NULL)
+				if (hreq->postform == NULL) {
+					ERROR("Can't create POST processor");
 					afb_hreq_reply_error(hreq, MHD_HTTP_INTERNAL_SERVER_ERROR);
+				}
 				return MHD_YES;
 			} else if (strcasestr(type, JSON_CONTENT) != NULL) {
 				return MHD_YES;
                         } else {
+				WARNING("Unsupported media type %s", type);
 				afb_hreq_reply_error(hreq, MHD_HTTP_UNSUPPORTED_MEDIA_TYPE);
 				return MHD_YES;
 			}
@@ -169,6 +174,7 @@ static int access_handler(
 	if (*upload_data_size) {
 		if (hreq->postform != NULL) {
 			if (!MHD_post_process (hreq->postform, upload_data, *upload_data_size)) {
+				ERROR("error in POST processor");
 				afb_hreq_reply_error(hreq, MHD_HTTP_INTERNAL_SERVER_ERROR);
 				return MHD_YES;
 			}
@@ -187,6 +193,7 @@ static int access_handler(
 		rc = MHD_destroy_post_processor(hreq->postform);
 		hreq->postform = NULL;
 		if (rc == MHD_NO) {
+			ERROR("error detected in POST processing");
 			afb_hreq_reply_error(hreq, MHD_HTTP_BAD_REQUEST);
 			return MHD_YES;
 		}
@@ -219,6 +226,7 @@ static int access_handler(
 	}
 
 	/* no handler */
+	WARNING("Unhandled request to %s", hreq->url);
 	afb_hreq_reply_error(hreq, MHD_HTTP_NOT_FOUND);
 	return MHD_YES;
 }
@@ -230,9 +238,11 @@ static void end_handler(void *cls, struct MHD_Connection *connection, void **rec
 	struct afb_hreq *hreq;
 
 	hreq = *recordreq;
-	if (hreq->upgrade)
-		MHD_suspend_connection (connection);
-	afb_hreq_unref(hreq);
+	if (hreq) {
+		if (hreq->upgrade)
+			MHD_suspend_connection (connection);
+		afb_hreq_unref(hreq);
+	}
 }
 
 void run_micro_httpd(struct afb_hsrv *hsrv)