X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fafb-api-so-v2.c;h=ba53223f2cf9deca79339f9614ecbca199b170d4;hb=a0bcdbcab352e311f320ded7af2205eec632296a;hp=7df83dd8fc05a37f81959fc2dd086da848bff5b0;hpb=e62227977bbc161d2d0ae49951f9a4fbf02a354e;p=src%2Fapp-framework-binder.git

diff --git a/src/afb-api-so-v2.c b/src/afb-api-so-v2.c
index 7df83dd8..ba53223f 100644
--- a/src/afb-api-so-v2.c
+++ b/src/afb-api-so-v2.c
@@ -16,19 +16,21 @@
  */
 
 #define _GNU_SOURCE
-#define NO_BINDING_VERBOSE_MACRO
 
+#include <stdlib.h>
 #include <string.h>
 #include <dlfcn.h>
 #include <assert.h>
 
-#include <afb/afb-binding.h>
+#include <afb/afb-binding-v2.h>
+#include <json-c/json.h>
 
-#include "afb-apis.h"
-#include "afb-svc.h"
-#include "afb-ditf.h"
+#include "afb-api.h"
+#include "afb-api-so-v2.h"
+#include "afb-apiset.h"
+#include "afb-auth.h"
+#include "afb-export.h"
 #include "afb-evt.h"
-#include "afb-common.h"
 #include "afb-context.h"
 #include "afb-api-so.h"
 #include "afb-xreq.h"
@@ -38,25 +40,26 @@
  * names of symbols
  */
 static const char afb_api_so_v2_descriptor[] = "afbBindingV2";
+static const char afb_api_so_v2_data[] = "afbBindingV2data";
 
 /*
  * Description of a binding
  */
 struct api_so_v2 {
-	struct afb_binding_v2 *binding;	/* descriptor */
-	void *handle;			/* context of dlopen */
-	struct afb_svc *service;	/* handler for service started */
-	struct afb_ditf ditf;		/* daemon interface */
+	const struct afb_binding_v2 *binding;	/* descriptor */
+	void *handle;				/* context of dlopen */
+	struct afb_export *export;		/* exportations */
 };
 
-static const struct afb_verb_v2 *search(struct api_so_v2 *desc, const char *verb)
+static const struct afb_verb_v2 *search(struct api_so_v2 *desc, const char *name)
 {
-	const struct afb_verb_v2 *result;
+	const struct afb_verb_v2 *verb;
 
-	result = desc->binding->verbs;
-	while (result->verb && strcasecmp(result->verb, verb))
-		result++;
-	return result->verb ? result : NULL;
+	verb = desc->binding->verbs;
+	while (verb->verb && strcasecmp(verb->verb, name))
+		verb++;
+	return verb->verb ? verb : NULL;
+	return NULL;
 }
 
 static void call_cb(void *closure, struct afb_xreq *xreq)
@@ -64,124 +67,187 @@ static void call_cb(void *closure, struct afb_xreq *xreq)
 	struct api_so_v2 *desc = closure;
 	const struct afb_verb_v2 *verb;
 
-	verb = search(desc, xreq->verb);
-	if (!verb)
-		afb_xreq_fail_f(xreq, "unknown-verb", "verb %s unknown within api %s", xreq->verb, desc->binding->api);
-	else
-		afb_xreq_call(xreq, verb->session, verb->callback);
+	xreq->request.dynapi = (void*)desc->export; /* hack: this avoids to export afb_export structure */
+	verb = search(desc, xreq->request.verb);
+	afb_xreq_call_verb_v2(xreq, verb);
 }
 
-static int service_start_cb(void *closure, int share_session, int onneed)
+static int service_start_cb(void *closure, int share_session, int onneed, struct afb_apiset *apiset)
 {
-	int (*start)(const struct afb_binding_interface *interface, struct afb_service service);
-	void (*onevent)(const char *event, struct json_object *object);
+	struct api_so_v2 *desc = closure;
+	return afb_export_start(desc->export, share_session, onneed, apiset);
+}
 
+static void update_hooks_cb(void *closure)
+{
 	struct api_so_v2 *desc = closure;
+	afb_export_update_hook(desc->export);
+}
 
-	/* check state */
-	if (desc->service != NULL) {
-		/* not an error when onneed */
-		if (onneed != 0)
-			return 0;
+static int get_verbosity_cb(void *closure)
+{
+	struct api_so_v2 *desc = closure;
+	return afb_export_verbosity_get(desc->export);
+}
 
-		/* already started: it is an error */
-		ERROR("Service %s already started", desc->binding->api);
-		return -1;
+static void set_verbosity_cb(void *closure, int level)
+{
+	struct api_so_v2 *desc = closure;
+	afb_export_verbosity_set(desc->export, level);
+}
+
+static struct json_object *make_description_openAPIv3(struct api_so_v2 *desc)
+{
+	char buffer[256];
+	const struct afb_verb_v2 *verb;
+	struct json_object *r, *f, *a, *i, *p, *g;
+
+	r = json_object_new_object();
+	json_object_object_add(r, "openapi", json_object_new_string("3.0.0"));
+
+	i = json_object_new_object();
+	json_object_object_add(r, "info", i);
+	json_object_object_add(i, "title", json_object_new_string(afb_export_apiname(desc->export)));
+	json_object_object_add(i, "version", json_object_new_string("0.0.0"));
+	json_object_object_add(i, "description", json_object_new_string(desc->binding->info ?: afb_export_apiname(desc->export)));
+
+	p = json_object_new_object();
+	json_object_object_add(r, "paths", p);
+	verb = desc->binding->verbs;
+	while (verb->verb) {
+		buffer[0] = '/';
+		strncpy(buffer + 1, verb->verb, sizeof buffer - 1);
+		buffer[sizeof buffer - 1] = 0;
+		f = json_object_new_object();
+		json_object_object_add(p, buffer, f);
+		g = json_object_new_object();
+		json_object_object_add(f, "get", g);
+
+		a = afb_auth_json_v2(verb->auth, verb->session);
+		if (a)
+			json_object_object_add(g, "x-permissions", a);
+
+		a = json_object_new_object();
+		json_object_object_add(g, "responses", a);
+		f = json_object_new_object();
+		json_object_object_add(a, "200", f);
+		json_object_object_add(f, "description", json_object_new_string(verb->info?:verb->verb));
+		verb++;
 	}
+	return r;
+}
+
+static struct json_object *describe_cb(void *closure)
+{
+	struct api_so_v2 *desc = closure;
+	struct json_object *r = desc->binding->specification ? json_tokener_parse(desc->binding->specification) : NULL;
+	if (!r)
+		r = make_description_openAPIv3(desc);
+	return r;
+}
 
-	/* get the initialisation */
-	start = desc->binding->start;
-	if (start == NULL) {
-		/* not an error when onneed */
-		if (onneed != 0)
-			return 0;
+static struct afb_api_itf so_v2_api_itf = {
+	.call = call_cb,
+	.service_start = service_start_cb,
+	.update_hooks = update_hooks_cb,
+	.get_verbosity = get_verbosity_cb,
+	.set_verbosity = set_verbosity_cb,
+	.describe = describe_cb
+};
+
+int afb_api_so_v2_add_binding(const struct afb_binding_v2 *binding, void *handle, struct afb_apiset *apiset, struct afb_binding_data_v2 *data)
+{
+	int rc;
+	struct api_so_v2 *desc;
+	struct afb_api afb_api;
+	struct afb_export *export;
+
+	/* basic checks */
+	assert(binding);
+	assert(binding->api);
+	assert(binding->verbs);
+	assert(data);
+
+	/* allocates the description */
+	export = afb_export_create_v2(apiset, binding->api, data, binding->init, binding->onevent);
+	desc = calloc(1, sizeof *desc);
+	if (!desc || !export) {
+		ERROR("out of memory");
+		goto error;
+	}
+	desc->binding = binding;
+	desc->handle = handle;
+	desc->export = export;
 
-		/* no initialisation method */
-		ERROR("Binding %s is not a service", desc->binding->api);
-		return -1;
+	/* init the binding */
+	if (binding->preinit) {
+		INFO("binding %s calling preinit function", binding->api);
+		rc = binding->preinit();
+		if (rc < 0) {
+			ERROR("binding %s preinit function failed...", afb_export_apiname(desc->export));
+			goto error;
+		}
 	}
 
-	/* get the event handler if any */
-	onevent = desc->binding->onevent;
-	desc->service = afb_svc_create_v2(share_session, onevent, start, &desc->ditf.interface);
-	if (desc->service == NULL) {
-		/* starting error */
-		ERROR("Starting service %s failed", desc->binding->api);
-		return -1;
+	/* records the binding */
+	afb_api.closure = desc;
+	afb_api.itf = &so_v2_api_itf;
+	afb_api.group = binding->noconcurrency ? export : NULL;
+	if (afb_apiset_add(apiset, afb_export_apiname(desc->export), afb_api) < 0) {
+		ERROR("binding %s can't be registered to set %s...", afb_export_apiname(desc->export), afb_apiset_name(apiset));
+		goto error;
 	}
+	INFO("binding %s added to set %s", afb_export_apiname(desc->export), afb_apiset_name(apiset));
+	return 1;
+
+error:
+	afb_export_destroy(export);
+	free(desc);
 
-	return 0;
+	return -1;
 }
 
-int afb_api_so_v2_add(const char *path, void *handle)
+int afb_api_so_v2_add(const char *path, void *handle, struct afb_apiset *apiset)
 {
-	int rc;
-	struct api_so_v2 *desc;
-	struct afb_binding_v2 *binding;
+	const struct afb_binding_v2 *binding;
+	struct afb_binding_data_v2 *data;
 
 	/* retrieves the register function */
 	binding = dlsym(handle, afb_api_so_v2_descriptor);
-	if (!binding)
+	data = dlsym(handle, afb_api_so_v2_data);
+	if (!binding && !data)
 		return 0;
 
 	INFO("binding [%s] looks like an AFB binding V2", path);
 
 	/* basic checks */
+	if (!binding || !data) {
+		ERROR("binding [%s] incomplete symbol set: %s is missing",
+			path, binding ? afb_api_so_v2_data : afb_api_so_v2_descriptor);
+		goto error;
+	}
 	if (binding->api == NULL || *binding->api == 0) {
 		ERROR("binding [%s] bad api name...", path);
 		goto error;
 	}
-	if (!afb_apis_is_valid_api_name(binding->api)) {
+	if (!afb_api_is_valid_name(binding->api)) {
 		ERROR("binding [%s] invalid api name...", path);
 		goto error;
 	}
+#if 0
 	if (binding->specification == NULL || *binding->specification == 0) {
 		ERROR("binding [%s] bad specification...", path);
 		goto error;
 	}
+#endif
 	if (binding->verbs == NULL) {
 		ERROR("binding [%s] no verbs...", path);
 		goto error;
 	}
 
-	/* allocates the description */
-	desc = calloc(1, sizeof *desc);
-	if (desc == NULL) {
-		ERROR("out of memory");
-		goto error;
-	}
-	desc->binding = binding;
-	desc->handle = handle;
-
-	/* init the interface */
-	afb_ditf_init(&desc->ditf, binding->api);
+	return afb_api_so_v2_add_binding(binding, handle, apiset, data);
 
-	/* for log purpose, a fake binding is needed here */
-
-	/* init the binding */
-	if (binding->init) {
-		NOTICE("binding %s [%s] calling init function", binding->api, path);
-		rc = binding->init(&desc->ditf.interface);
-		if (rc < 0) {
-			ERROR("binding %s [%s] initialisation function failed...", binding->api, path);
-			goto error2;
-		}
-	}
-
-	/* records the binding */
-	if (afb_apis_add(binding->api, (struct afb_api){
-			.closure = desc,
-			.call = call_cb,
-			.service_start = service_start_cb }) < 0) {
-		ERROR("binding [%s] can't be registered...", path);
-		goto error2;
-	}
-	NOTICE("binding %s loaded with API prefix %s", path, binding->api);
-	return 1;
-
-error2:
-	free(desc);
-error:
+ error:
 	return -1;
 }