X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=src%2Fafb-api-so-v2.c;h=092fd31a70b72321531e479546eef1cb4f7f9eae;hb=8a5d14c58817b7ee03f8e22ba734fdd8cc2bc780;hp=0c8079c4526a484fa63a2b32856d955a3364cef1;hpb=c9ba2ce49808a19a4ef982280a46256797b830ae;p=src%2Fapp-framework-binder.git

diff --git a/src/afb-api-so-v2.c b/src/afb-api-so-v2.c
index 0c8079c4..092fd31a 100644
--- a/src/afb-api-so-v2.c
+++ b/src/afb-api-so-v2.c
@@ -23,14 +23,18 @@
 #include <assert.h>
 
 #include <afb/afb-binding.h>
+#include <json-c/json.h>
 
-#include "afb-apis.h"
+#include "afb-api.h"
+#include "afb-apiset.h"
 #include "afb-svc.h"
+#include "afb-ditf.h"
 #include "afb-evt.h"
 #include "afb-common.h"
 #include "afb-context.h"
 #include "afb-api-so.h"
-#include "afb-thread.h"
+#include "afb-xreq.h"
+#include "afb-perm.h"
 #include "verbose.h"
 
 /*
@@ -38,155 +42,57 @@
  */
 static const char afb_api_so_v2_descriptor[] = "afbBindingV2";
 
+/**
+ * structure for memorizing verbs sorted with permissions
+ */
+struct verb_v2 {
+	const struct afb_verb_v2 *verb;
+	struct afb_perm *perm;
+};
+
 /*
  * Description of a binding
  */
 struct api_so_v2 {
-	struct afb_binding_v2 *binding;	/* descriptor */
-	size_t apilength;		/* length of the API name */
+	const struct afb_binding_v2 *binding;	/* descriptor */
 	void *handle;			/* context of dlopen */
 	struct afb_svc *service;	/* handler for service started */
-	struct afb_binding_interface interface;	/* interface for the binding */
+	struct afb_ditf ditf;		/* daemon interface */
+	int count;
+	struct verb_v2 verbs[1];
 };
 
-static struct afb_event afb_api_so_event_make_cb(void *closure, const char *name);
-static int afb_api_so_event_broadcast_cb(void *closure, const char *name, struct json_object *object);
-static void afb_api_so_vverbose_cb(void *closure, int level, const char *file, int line, const char *fmt, va_list args);
-static int afb_api_so_rootdir_get_fd(void *closure);
-static int afb_api_so_rootdir_open_locale(void *closure, const char *filename, int flags, const char *locale);
-
-static const struct afb_daemon_itf daemon_itf = {
-	.event_broadcast = afb_api_so_event_broadcast_cb,
-	.get_event_loop = afb_common_get_event_loop,
-	.get_user_bus = afb_common_get_user_bus,
-	.get_system_bus = afb_common_get_system_bus,
-	.vverbose = afb_api_so_vverbose_cb,
-	.event_make = afb_api_so_event_make_cb,
-	.rootdir_get_fd = afb_api_so_rootdir_get_fd,
-	.rootdir_open_locale = afb_api_so_rootdir_open_locale
-};
-
-static struct afb_event afb_api_so_event_make_cb(void *closure, const char *name)
+static const struct afb_verb_v2 *search(struct api_so_v2 *desc, const char *verb)
 {
-	size_t length;
-	char *event;
-	struct api_so_v2 *desc = closure;
-
-	/* makes the event name */
-	assert(desc->binding != NULL);
-	length = strlen(name);
-	event = alloca(length + 2 + desc->apilength);
-	memcpy(event, desc->binding->api, desc->apilength);
-	event[desc->apilength] = '/';
-	memcpy(event + desc->apilength + 1, name, length + 1);
-
-	/* crate the event */
-	return afb_evt_create_event(event);
-}
-
-static int afb_api_so_event_broadcast_cb(void *closure, const char *name, struct json_object *object)
-{
-	size_t length;
-	char *event;
-	struct api_so_v2 *desc = closure;
-
-	/* makes the event name */
-	assert(desc->binding != NULL);
-	length = strlen(name);
-	event = alloca(length + 2 + desc->apilength);
-	memcpy(event, desc->binding->api, desc->apilength);
-	event[desc->apilength] = '/';
-	memcpy(event + desc->apilength + 1, name, length + 1);
-
-	return afb_evt_broadcast(event, object);
-}
-
-static void afb_api_so_vverbose_cb(void *closure, int level, const char *file, int line, const char *fmt, va_list args)
-{
-	char *p;
-	struct api_so_v2 *desc = closure;
-
-	if (vasprintf(&p, fmt, args) < 0)
-		vverbose(level, file, line, fmt, args);
-	else {
-		verbose(level, file, line, "%s {binding %s}", p, desc->binding->api);
-		free(p);
+	const struct afb_verb_v2 *v;
+	int i, l, u, c;
+
+	l = 0;
+	u = desc->count;
+	while (l < u) {
+		i = (l + u) >> 1;
+		v = desc->verbs[i].verb;
+		c = strcasecmp(v->verb, verb);
+		if (c == 0)
+			return v;
+		if (c < 0)
+			l = i + 1;
+		else
+			u = i;
 	}
+	return NULL;
 }
 
-static int afb_api_so_rootdir_get_fd(void *closure)
-{
-	return afb_common_rootdir_get_fd();
-}
-
-static int afb_api_so_rootdir_open_locale(void *closure, const char *filename, int flags, const char *locale)
-{
-	return afb_common_rootdir_open_locale(filename, flags, locale);
-}
-
-static int call_check(struct afb_req req, struct afb_context *context, const struct afb_verb_v2 *verb)
+static void call_cb(void *closure, struct afb_xreq *xreq)
 {
-	int stag = (int)verb->session;
-
-	if ((stag & (AFB_SESSION_CREATE|AFB_SESSION_CLOSE|AFB_SESSION_RENEW|AFB_SESSION_CHECK|AFB_SESSION_LOA_EQ)) != 0) {
-		if (!afb_context_check(context)) {
-			afb_context_close(context);
-			afb_req_fail(req, "failed", "invalid token's identity");
-			return 0;
-		}
-	}
-
-	if ((stag & AFB_SESSION_CREATE) != 0) {
-		if (afb_context_check_loa(context, 1)) {
-			afb_req_fail(req, "failed", "invalid creation state");
-			return 0;
-		}
-		afb_context_change_loa(context, 1);
-		afb_context_refresh(context);
-	}
-
-	if ((stag & (AFB_SESSION_CREATE | AFB_SESSION_RENEW)) != 0)
-		afb_context_refresh(context);
-
-	if ((stag & AFB_SESSION_CLOSE) != 0) {
-		afb_context_change_loa(context, 0);
-		afb_context_close(context);
-	}
-
-	if ((stag & AFB_SESSION_LOA_GE) != 0) {
-		int loa = (stag >> AFB_SESSION_LOA_SHIFT) & AFB_SESSION_LOA_MASK;
-		if (!afb_context_check_loa(context, loa)) {
-			afb_req_fail(req, "failed", "invalid LOA");
-			return 0;
-		}
-	}
-
-	if ((stag & AFB_SESSION_LOA_LE) != 0) {
-		int loa = (stag >> AFB_SESSION_LOA_SHIFT) & AFB_SESSION_LOA_MASK;
-		if (afb_context_check_loa(context, loa + 1)) {
-			afb_req_fail(req, "failed", "invalid LOA");
-			return 0;
-		}
-	}
-	return 1;
-}
-
-static void call_cb(void *closure, struct afb_req req, struct afb_context *context, const char *strverb)
-{
-	const struct afb_verb_v2 *verb;
 	struct api_so_v2 *desc = closure;
+	const struct afb_verb_v2 *verb;
 
-	verb = desc->binding->verbs;
-	while (verb->verb && strcasecmp(verb->verb, strverb))
-		verb++;
-	if (!verb->verb)
-		afb_req_fail_f(req, "unknown-verb", "verb %s unknown within api %s", strverb, desc->binding->api);
-	else if (call_check(req, context, verb)) {
-		afb_thread_req_call(req, verb->callback, afb_api_so_timeout, desc);
-	}
+	verb = search(desc, xreq->verb);
+	afb_xreq_call_verb_v2(xreq, verb);
 }
 
-static int service_start_cb(void *closure, int share_session, int onneed)
+static int service_start_cb(void *closure, int share_session, int onneed, struct afb_apiset *apiset)
 {
 	int (*start)(const struct afb_binding_interface *interface, struct afb_service service);
 	void (*onevent)(const char *event, struct json_object *object);
@@ -218,7 +124,7 @@ static int service_start_cb(void *closure, int share_session, int onneed)
 
 	/* get the event handler if any */
 	onevent = desc->binding->onevent;
-	desc->service = afb_svc_create_v2(share_session, onevent, start, &desc->interface);
+	desc->service = afb_svc_create_v2(apiset, share_session, onevent, start, &desc->ditf.interface);
 	if (desc->service == NULL) {
 		/* starting error */
 		ERROR("Starting service %s failed", desc->binding->api);
@@ -228,79 +134,160 @@ static int service_start_cb(void *closure, int share_session, int onneed)
 	return 0;
 }
 
-int afb_api_so_v2_add(const char *path, void *handle)
+static void update_hooks_cb(void *closure)
 {
-	int rc;
-	struct api_so_v2 *desc;
-	struct afb_binding_v2 *binding;
+	struct api_so_v2 *desc = closure;
+	afb_ditf_update_hook(&desc->ditf);
+}
 
-	/* retrieves the register function */
-	binding = dlsym(handle, afb_api_so_v2_descriptor);
-	if (!binding)
-		return 0;
+static int get_verbosity_cb(void *closure)
+{
+	struct api_so_v2 *desc = closure;
+	return desc->ditf.interface.verbosity;
+}
 
-	INFO("binding [%s] looks like an AFB binding V2", path);
+static void set_verbosity_cb(void *closure, int level)
+{
+	struct api_so_v2 *desc = closure;
+	desc->ditf.interface.verbosity = level;
+}
+
+static struct json_object *describe_cb(void *closure)
+{
+	struct api_so_v2 *desc = closure;
+	return desc->binding->specification ? json_tokener_parse(desc->binding->specification) : NULL;
+}
+
+static struct afb_api_itf so_v2_api_itf = {
+	.call = call_cb,
+	.service_start = service_start_cb,
+	.update_hooks = update_hooks_cb,
+	.get_verbosity = get_verbosity_cb,
+	.set_verbosity = set_verbosity_cb,
+	.describe = describe_cb
+
+};
+
+int afb_api_so_v2_add_binding(const struct afb_binding_v2 *binding, void *handle, struct afb_apiset *apiset)
+{
+	int rc;
+	struct api_so_v2 *desc;
+	struct afb_api afb_api;
+	const struct afb_verb_v2 *bv;
+	int count, i, j;
 
 	/* basic checks */
-	if (binding->api == NULL || *binding->api == 0) {
-		ERROR("binding [%s] bad api name...", path);
-		goto error;
-	}
-	if (!afb_apis_is_valid_api_name(binding->api)) {
-		ERROR("binding [%s] invalid api name...", path);
-		goto error;
-	}
-	if (binding->specification == NULL || *binding->specification == 0) {
-		ERROR("binding [%s] bad specification...", path);
-		goto error;
-	}
-	if (binding->verbs == NULL) {
-		ERROR("binding [%s] no verbs...", path);
-		goto error;
-	}
+	assert(binding->api);
+	assert(binding->specification);
+	assert(binding->verbs);
+
+	/* count the verbs */
+	count = 0;
+	while (binding->verbs[count].verb)
+		count++;
 
 	/* allocates the description */
-	desc = calloc(1, sizeof *desc);
+	desc = malloc(sizeof *desc + (count - 1) * sizeof desc->verbs);
 	if (desc == NULL) {
 		ERROR("out of memory");
 		goto error;
 	}
 	desc->binding = binding;
 	desc->handle = handle;
+	desc->service = NULL;
+	memset(&desc->ditf, 0, sizeof desc->ditf);
+	desc->count = count;
+
+	/* fill the verbs sorted */
+	for (i = 0 ; i < count ; i++) {
+		desc->verbs[i].perm = NULL;
+		j = i;
+		bv = &binding->verbs[j];
+		while (j && strcasecmp(bv->verb, desc->verbs[j-1].verb->verb) < 0) {
+			desc->verbs[j].verb = desc->verbs[j-1].verb;
+			j--;
+		}
+		desc->verbs[j].verb = bv;
+	}
 
-	/* init the interface */
-	desc->interface.verbosity = verbosity;
-	desc->interface.mode = AFB_MODE_LOCAL;
-	desc->interface.daemon.itf = &daemon_itf;
-	desc->interface.daemon.closure = desc;
+	/* makes the permissions */
+	for (i = 0 ; i < count ; i++) {
+		if (desc->verbs[i].verb->permissions) {
+			desc->verbs[i].perm = afb_perm_parse(desc->verbs[i].verb->permissions);
+			if (!desc->verbs[i].perm) {
+				ERROR("Bad permission specification for verb %s of api %s: %s",
+					desc->verbs[i].verb->verb, binding->api,
+					desc->verbs[i].verb->permissions);
+				goto error2;
+			}
+		}
+	}
 
-	/* for log purpose, a fake binding is needed here */
+	/* init the interface */
+	afb_ditf_init(&desc->ditf, binding->api);
 
 	/* init the binding */
 	if (binding->init) {
-		NOTICE("binding %s [%s] calling init function", binding->api, path);
-		rc = binding->init(&desc->interface);
+		INFO("binding %s calling init function", binding->api);
+		rc = binding->init(&desc->ditf.interface);
 		if (rc < 0) {
-			ERROR("binding %s [%s] initialisation function failed...", binding->api, path);
+			ERROR("binding %s initialisation function failed...", binding->api);
 			goto error2;
 		}
 	}
 
 	/* records the binding */
-	desc->apilength = strlen(binding->api);
-	if (afb_apis_add(binding->api, (struct afb_api){
-			.closure = desc,
-			.call = call_cb,
-			.service_start = service_start_cb }) < 0) {
-		ERROR("binding [%s] can't be registered...", path);
+	afb_api.closure = desc;
+	afb_api.itf = &so_v2_api_itf;
+	if (afb_apiset_add(apiset, binding->api, afb_api) < 0) {
+		ERROR("binding %s can't be registered to set %s...", binding->api, afb_apiset_name(apiset));
 		goto error2;
 	}
-	NOTICE("binding %s loaded with API prefix %s", path, binding->api);
+	NOTICE("binding %s added to set %s", binding->api, afb_apiset_name(apiset));
 	return 1;
 
 error2:
+	count = desc->count;
+	while (count)
+		if (desc->verbs[--count].perm)
+			afb_perm_unref(desc->verbs[count].perm);
 	free(desc);
 error:
 	return -1;
 }
 
+int afb_api_so_v2_add(const char *path, void *handle, struct afb_apiset *apiset)
+{
+	const struct afb_binding_v2 *binding;
+
+	/* retrieves the register function */
+	binding = dlsym(handle, afb_api_so_v2_descriptor);
+	if (!binding)
+		return 0;
+
+	INFO("binding [%s] looks like an AFB binding V2", path);
+
+	/* basic checks */
+	if (binding->api == NULL || *binding->api == 0) {
+		ERROR("binding [%s] bad api name...", path);
+		goto error;
+	}
+	if (!afb_api_is_valid_name(binding->api)) {
+		ERROR("binding [%s] invalid api name...", path);
+		goto error;
+	}
+	if (binding->specification == NULL || *binding->specification == 0) {
+		ERROR("binding [%s] bad specification...", path);
+		goto error;
+	}
+	if (binding->verbs == NULL) {
+		ERROR("binding [%s] no verbs...", path);
+		goto error;
+	}
+
+	return afb_api_so_v2_add_binding(binding, handle, apiset);
+
+ error:
+	return -1;
+}
+