X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=plugins%2Fafm-main-plugin%2Futils-jbus.c;h=67e3ce4ceac6957a6bdcccb362e8df254d285f24;hb=3a6db27dec6fee245708074c301b42e1cbedd716;hp=d58def90ca1cecdf057a476146bb8e905e6322d1;hpb=84e91aa612523ebedcd1d58d2f2f9c30be4d405b;p=src%2Fapp-framework-binder.git diff --git a/plugins/afm-main-plugin/utils-jbus.c b/plugins/afm-main-plugin/utils-jbus.c index d58def90..67e3ce4c 100644 --- a/plugins/afm-main-plugin/utils-jbus.c +++ b/plugins/afm-main-plugin/utils-jbus.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #include @@ -77,6 +79,9 @@ struct jbus { struct jrespw *waiters; char *path; char *name; + int watchnr; + int watchfd; + int watchflags; }; /*********************** STATIC COMMON METHODS *****************/ @@ -156,7 +161,11 @@ static int add_signal( /* record the signal */ if (jbus->signals == NULL) { +#if 0 + if (0 >= asprintf(&rule, "type='signal',interface='%s',path='%s'", jbus->name, jbus->path)) +#else if (0 >= asprintf(&rule, "type='signal',sender='%s',interface='%s',path='%s'", jbus->name, jbus->name, jbus->path)) +#endif return -1; dbus_bus_add_match(jbus->connection, rule, NULL); free(rule); @@ -259,7 +268,9 @@ static DBusHandlerResult incoming_resp(DBusConnection *connection, DBusMessage * *prv = jrw->next; /* retrieve the string value */ - if (!dbus_message_get_args(message, NULL, DBUS_TYPE_STRING, &str, DBUS_TYPE_INVALID)) { + if (dbus_message_get_args(message, NULL, DBUS_TYPE_STRING, &str, DBUS_TYPE_INVALID)) + status = 0; + else { status = -1; str = NULL; reply = NULL; @@ -376,6 +387,61 @@ static DBusHandlerResult incoming(DBusConnection *connection, DBusMessage *messa return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; } +static void watchset(DBusWatch *watch, struct jbus *jbus) +{ + unsigned int flags; + int wf, e; + + flags = dbus_watch_get_flags(watch); + e = dbus_watch_get_enabled(watch); + wf = jbus->watchflags; + if (e) { + if (flags & DBUS_WATCH_READABLE) + wf |= POLLIN; + if (flags & DBUS_WATCH_WRITABLE) + wf |= POLLOUT; + } + else { + if (flags & DBUS_WATCH_READABLE) + wf &= ~POLLIN; + if (flags & DBUS_WATCH_WRITABLE) + wf &= ~POLLOUT; + } + jbus->watchflags = wf; +} + +static void watchdel(DBusWatch *watch, void *data) +{ + struct jbus *jbus = data; + + assert(jbus->watchnr > 0); + assert(jbus->watchfd == dbus_watch_get_unix_fd(watch)); + jbus->watchnr--; +} + +static void watchtoggle(DBusWatch *watch, void *data) +{ + struct jbus *jbus = data; + + assert(jbus->watchnr > 0); + assert(jbus->watchfd == dbus_watch_get_unix_fd(watch)); + watchset(watch, jbus); +} + +static dbus_bool_t watchadd(DBusWatch *watch, void *data) +{ + struct jbus *jbus = data; + if (jbus->watchnr == 0) { + jbus->watchfd = dbus_watch_get_unix_fd(watch); + jbus->watchflags = 0; + } + else if (jbus->watchfd != dbus_watch_get_unix_fd(watch)) + return FALSE; + jbus->watchnr++; + watchset(watch, jbus); + return TRUE; +} + /************************** MAIN FUNCTIONS *****************************************/ struct jbus *create_jbus(int session, const char *path) @@ -391,7 +457,6 @@ struct jbus *create_jbus(int session, const char *path) } jbus->refcount = 1; jbus->path = strdup(path); - jbus->name = NULL; if (jbus->path == NULL) { errno = ENOMEM; goto error2; @@ -417,12 +482,10 @@ struct jbus *create_jbus(int session, const char *path) /* connect */ jbus->connection = dbus_bus_get(session ? DBUS_BUS_SESSION : DBUS_BUS_SYSTEM, NULL); - if (jbus->connection == NULL) { + if (jbus->connection == NULL + || !dbus_connection_add_filter(jbus->connection, incoming, jbus, NULL) + || !dbus_connection_set_watch_functions(jbus->connection, watchadd, watchdel, watchtoggle, jbus, NULL)) goto error2; - } - if (!dbus_connection_add_filter(jbus->connection, incoming, jbus, NULL)) { - goto error2; - } return jbus; @@ -441,7 +504,8 @@ void jbus_unref(struct jbus *jbus) { struct jservice *srv; if (!--jbus->refcount) { - dbus_connection_unref(jbus->connection); + if (jbus->connection != NULL) + dbus_connection_unref(jbus->connection); while((srv = jbus->services) != NULL) { jbus->services = srv->next; free(srv->method); @@ -512,7 +576,8 @@ int jbus_send_signal_s(struct jbus *jbus, const char *name, const char *content) if (message == NULL) goto error; - if (!dbus_message_append_args(message, DBUS_TYPE_STRING, &content, DBUS_TYPE_INVALID)) { + if (!dbus_message_set_sender(message, jbus->name) + || !dbus_message_append_args(message, DBUS_TYPE_STRING, &content, DBUS_TYPE_INVALID)) { dbus_message_unref(message); goto error; } @@ -562,12 +627,89 @@ int jbus_start_serving(struct jbus *jbus) } } +int jbus_fill_pollfds(struct jbus **jbuses, int njbuses, struct pollfd *fds) +{ + int i, r; + + for (r = i = 0 ; i < njbuses ; i++) { + if (jbuses[i]->watchnr) { + fds[r].fd = jbuses[i]->watchfd; + fds[r].events = jbuses[i]->watchflags; + r++; + } + } + return r; +} + +int jbus_dispatch_pollfds(struct jbus **jbuses, int njbuses, struct pollfd *fds, int maxcount) +{ + int i, r, n; + DBusDispatchStatus sts; + + for (r = n = i = 0 ; i < njbuses && n < maxcount ; i++) { + if (jbuses[i]->watchnr && fds[r].fd == jbuses[i]->watchfd) { + if (fds[r].revents) { + dbus_connection_read_write(jbuses[i]->connection, 0); + sts = dbus_connection_get_dispatch_status(jbuses[i]->connection); + while(sts == DBUS_DISPATCH_DATA_REMAINS && n < maxcount) { + sts = dbus_connection_dispatch(jbuses[i]->connection); + n++; + } + } + r++; + } + } + return n; +} + +int jbus_dispatch_multiple(struct jbus **jbuses, int njbuses, int maxcount) +{ + int i, r; + DBusDispatchStatus sts; + + for (i = r = 0 ; i < njbuses && r < maxcount ; i++) { + dbus_connection_read_write(jbuses[i]->connection, 0); + sts = dbus_connection_get_dispatch_status(jbuses[i]->connection); + while(sts == DBUS_DISPATCH_DATA_REMAINS && r < maxcount) { + sts = dbus_connection_dispatch(jbuses[i]->connection); + r++; + } + } + return r; +} + +int jbus_read_write_dispatch_multiple(struct jbus **jbuses, int njbuses, int toms, int maxcount) +{ + int n, r, s; + struct pollfd *fds; + + if (njbuses < 0 || njbuses > 100) { + errno = EINVAL; + return -1; + } + fds = alloca(njbuses * sizeof * fds); + assert(fds != NULL); + + r = jbus_dispatch_multiple(jbuses, njbuses, maxcount); + if (r) + return r; + n = jbus_fill_pollfds(jbuses, njbuses, fds); + for(;;) { + s = poll(fds, n, toms); + if (s >= 0) + break; + if (errno != EINTR) + return r ? r : s; + toms = 0; + } + n = jbus_dispatch_pollfds(jbuses, njbuses, fds, maxcount - r); + return n >= 0 ? r + n : r ? r : n; +} + int jbus_read_write_dispatch(struct jbus *jbus, int toms) { - if (dbus_connection_read_write_dispatch(jbus->connection, toms)); - return 0; - errno = EPIPE; - return -1; + int r = jbus_read_write_dispatch_multiple(&jbus, 1, toms, 1000); + return r < 0 ? r : 0; } int jbus_call_ss(struct jbus *jbus, const char *method, const char *query, void (*onresp)(int, const char*, void*), void *data) @@ -682,8 +824,7 @@ int main() s2 = jbus_add_service_j(jbus, "incr", incr); s3 = jbus_start_serving(jbus); printf("started %d %d %d\n", s1, s2, s3); - while (!jbus_read_write_dispatch (jbus, -1)) - ; + while (!jbus_read_write_dispatch (jbus, -1)); } #endif #ifdef CLIENT @@ -710,8 +851,7 @@ int main() jbus_read_write_dispatch (jbus, 1); } printf("[[[%s]]]\n", jbus_call_ss_sync(jbus, "ping", "\"formidable!\"")); - while (!jbus_read_write_dispatch (jbus, -1)) - ; + while (!jbus_read_write_dispatch (jbus, -1)); } #endif