X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=lib%2Fxdsconfig%2Ffileconfig.go;h=90c1aad34c5fe5de41baa1d5b8b7d671c73cddc2;hb=75a75542d27d8485fc4c1749b51bd8e26320e982;hp=7370ed0a1a2c204c435959f1afa576acb05d8d4d;hpb=a840678ea8b627e8a0f952c07a268e4b0be8ee9c;p=src%2Fxds%2Fxds-server.git

diff --git a/lib/xdsconfig/fileconfig.go b/lib/xdsconfig/fileconfig.go
index 7370ed0..90c1aad 100644
--- a/lib/xdsconfig/fileconfig.go
+++ b/lib/xdsconfig/fileconfig.go
@@ -2,33 +2,37 @@ package xdsconfig
 
 import (
 	"encoding/json"
-	"fmt"
 	"os"
 	"os/user"
 	"path"
 	"path/filepath"
-	"regexp"
 	"strings"
+
+	common "github.com/iotbzh/xds-common/golib"
 )
 
 type SyncThingConf struct {
-	Home       string `json:"home"`
-	GuiAddress string `json:"gui-address"`
-	GuiAPIKey  string `json:"gui-apikey"`
+	BinDir          string `json:"binDir"`
+	Home            string `json:"home"`
+	GuiAddress      string `json:"gui-address"`
+	GuiAPIKey       string `json:"gui-apikey"`
+	RescanIntervalS int    `json:"rescanIntervalS"`
 }
 
 type FileConfig struct {
-	WebAppDir    string        `json:"webAppDir"`
-	ShareRootDir string        `json:"shareRootDir"`
-	HTTPPort     string        `json:"httpPort"`
-	SThgConf     SyncThingConf `json:"syncthing"`
+	WebAppDir    string         `json:"webAppDir"`
+	ShareRootDir string         `json:"shareRootDir"`
+	SdkRootDir   string         `json:"sdkRootDir"`
+	HTTPPort     string         `json:"httpPort"`
+	SThgConf     *SyncThingConf `json:"syncthing"`
+	LogsDir      string         `json:"logsDir"`
 }
 
 // getConfigFromFile reads configuration from a config file.
 // Order to determine which config file is used:
 //  1/ from command line option: "--config myConfig.json"
 //  2/ $HOME/.xds/config.json file
-//  3/ <current_dir>/agent-config.json file
+//  3/ <current_dir>/config.json file
 //  4/ <xds-server executable dir>/config.json file
 
 func updateConfigFromFile(c *Config, confFile string) error {
@@ -73,80 +77,49 @@ func updateConfigFromFile(c *Config, confFile string) error {
 	if err := json.NewDecoder(fd).Decode(&fCfg); err != nil {
 		return err
 	}
-	c.fileConf = fCfg
 
 	// Support environment variables (IOW ${MY_ENV_VAR} syntax) in config.json
-	// TODO: better to use reflect package to iterate on fields and be more generic
-	var rep string
-	if rep, err = resolveEnvVar(fCfg.WebAppDir); err != nil {
-		return err
+	for _, field := range []*string{
+		&fCfg.WebAppDir,
+		&fCfg.ShareRootDir,
+		&fCfg.SdkRootDir,
+		&fCfg.LogsDir,
+		&fCfg.SThgConf.Home,
+		&fCfg.SThgConf.BinDir} {
+
+		var err error
+		if *field, err = common.ResolveEnvVar(*field); err != nil {
+			return err
+		}
 	}
-	fCfg.WebAppDir = path.Clean(rep)
 
-	if rep, err = resolveEnvVar(fCfg.ShareRootDir); err != nil {
-		return err
+	// Use config file settings else use default config
+	if fCfg.WebAppDir == "" {
+		fCfg.WebAppDir = c.FileConf.WebAppDir
 	}
-	fCfg.ShareRootDir = path.Clean(rep)
-
-	if rep, err = resolveEnvVar(fCfg.SThgConf.Home); err != nil {
-		return err
+	if fCfg.ShareRootDir == "" {
+		fCfg.ShareRootDir = c.FileConf.ShareRootDir
 	}
-	fCfg.SThgConf.Home = path.Clean(rep)
-
-	// Config file settings overwrite default config
-
-	if fCfg.WebAppDir != "" {
-		c.WebAppDir = strings.Trim(fCfg.WebAppDir, " ")
+	if fCfg.SdkRootDir == "" {
+		fCfg.SdkRootDir = c.FileConf.SdkRootDir
+	}
+	if fCfg.HTTPPort == "" {
+		fCfg.HTTPPort = c.FileConf.HTTPPort
 	}
-	// Is it a full path ?
-	if !strings.HasPrefix(c.WebAppDir, "/") && exePath != "" {
+
+	// Resolve webapp dir (support relative or full path)
+	fCfg.WebAppDir = strings.Trim(fCfg.WebAppDir, " ")
+	if !strings.HasPrefix(fCfg.WebAppDir, "/") && exePath != "" {
 		// Check first from current directory
 		for _, rootD := range []string{cwd, exePath} {
-			ff := path.Join(rootD, c.WebAppDir, "index.html")
-			if exists(ff) {
-				c.WebAppDir = path.Join(rootD, c.WebAppDir)
+			ff := path.Join(rootD, fCfg.WebAppDir, "index.html")
+			if common.Exists(ff) {
+				fCfg.WebAppDir = path.Join(rootD, fCfg.WebAppDir)
 				break
 			}
 		}
 	}
 
-	if fCfg.ShareRootDir != "" {
-		c.ShareRootDir = fCfg.ShareRootDir
-	}
-
-	if fCfg.HTTPPort != "" {
-		c.HTTPPort = fCfg.HTTPPort
-	}
-
+	c.FileConf = fCfg
 	return nil
 }
-
-// resolveEnvVar Resolved environment variable regarding the syntax ${MYVAR}
-func resolveEnvVar(s string) (string, error) {
-	re := regexp.MustCompile("\\${(.*)}")
-	vars := re.FindAllStringSubmatch(s, -1)
-	res := s
-	for _, v := range vars {
-		val := os.Getenv(v[1])
-		if val == "" {
-			return res, fmt.Errorf("ERROR: %s env variable not defined", v[1])
-		}
-
-		rer := regexp.MustCompile("\\${" + v[1] + "}")
-		res = rer.ReplaceAllString(res, val)
-	}
-
-	return res, nil
-}
-
-// exists returns whether the given file or directory exists or not
-func exists(path string) bool {
-	_, err := os.Stat(path)
-	if err == nil {
-		return true
-	}
-	if os.IsNotExist(err) {
-		return false
-	}
-	return true
-}