X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;f=lib%2Fagent%2Fapiv1-version.go;h=be726724916a069b6c65fd125c2548fb7bb5872b;hb=7c7d90a781082c6bd22d12a5e2451ca61a5198af;hp=6b4923f177df1908dac369af025332bbebb699b8;hpb=4695555e178bcabe54c5bf82117c9c4cef5440b5;p=src%2Fxds%2Fxds-agent.git

diff --git a/lib/agent/apiv1-version.go b/lib/agent/apiv1-version.go
index 6b4923f..be72672 100644
--- a/lib/agent/apiv1-version.go
+++ b/lib/agent/apiv1-version.go
@@ -1,28 +1,17 @@
 package agent
 
 import (
+	"fmt"
 	"net/http"
 
 	"github.com/gin-gonic/gin"
-	common "github.com/iotbzh/xds-common/golib"
+	"github.com/iotbzh/xds-agent/lib/xaapiv1"
 )
 
-type version struct {
-	ID            string `json:"id"`
-	Version       string `json:"version"`
-	APIVersion    string `json:"apiVersion"`
-	VersionGitTag string `json:"gitTag"`
-}
-
-type apiVersion struct {
-	Client version   `json:"client"`
-	Server []version `json:"servers"`
-}
-
 // getInfo : return various information about server
 func (s *APIService) getVersion(c *gin.Context) {
-	response := apiVersion{
-		Client: version{
+	response := xaapiv1.XDSVersion{
+		Client: xaapiv1.VersionData{
 			ID:            "",
 			Version:       s.Config.Version,
 			APIVersion:    s.Config.APIVersion,
@@ -30,12 +19,14 @@ func (s *APIService) getVersion(c *gin.Context) {
 		},
 	}
 
-	svrVer := []version{}
+	svrVer := []xaapiv1.VersionData{}
 	for _, svr := range s.xdsServers {
-		res := version{}
+		res := xaapiv1.VersionData{}
 		if err := svr.GetVersion(&res); err != nil {
-			common.APIError(c, "Cannot retrieve version of XDS server ID %s : %v", svr.ID, err.Error())
-			return
+			errMsg := fmt.Sprintf("Cannot retrieve version of XDS server ID %s : %v", svr.ID, err.Error())
+			s.Log.Warning(errMsg)
+			res.ID = svr.ID
+			res.Version = errMsg
 		}
 		svrVer = append(svrVer, res)
 	}