X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=src%2Fwgtpkg-zip.c;h=75cb164ea9b355ec6ea333c814a99c52502b9873;hb=c0fc18e47e49dd4e3cc2f09452a19297dad63f9c;hp=9e51538d1c58750ea592d4a243fca593e2e17ac6;hpb=bf7b5918fcc07713a29b9ca32f766b65b15a4ec2;p=src%2Fapp-framework-main.git

diff --git a/src/wgtpkg-zip.c b/src/wgtpkg-zip.c
index 9e51538..75cb164 100644
--- a/src/wgtpkg-zip.c
+++ b/src/wgtpkg-zip.c
@@ -1,6 +1,8 @@
 /*
  Copyright 2015 IoT.bzh
 
+ author: José Bollo <jose.bollo@iot.bzh>
+
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at
@@ -25,9 +27,9 @@
 #include <assert.h>
 #include <dirent.h>
 #include <string.h>
-#include <syslog.h>
 #include <unistd.h>
 
+#include "verbose.h"
 #include "wgtpkg.h"
 
 
@@ -65,18 +67,18 @@ static int create_directory(char *file, int mode)
 	char *last = strrchr(file, '/');
 	if (last != NULL)
 		*last = 0;
-	rc = mkdir(file, mode);
+	rc = mkdirat(workdirfd, file, mode);
 	if (rc) {
 		if (errno == EEXIST)
 			rc = 0;
 		else if (errno == ENOENT) {
 			rc = create_directory(file, mode);
 			if (!rc)
-				rc = mkdir(file, mode);
+				rc = mkdirat(workdirfd, file, mode);
 		}
 	}
 	if (rc)
-		syslog(LOG_ERR, "can't create directory %s", file);
+		ERROR("can't create directory %s", file);
 	if (last != NULL)
 		*last = '/';
 	return rc;
@@ -84,13 +86,13 @@ static int create_directory(char *file, int mode)
 
 static int create_file(char *file, int fmode, int dmode)
 {
-	int fd = creat(file, fmode);
+	int fd = openat(workdirfd, file, O_CREAT|O_WRONLY|O_TRUNC, fmode);
 	if (fd < 0 && errno == ENOENT) {
 		if (!create_directory(file, dmode))
-			fd = creat(file, fmode);
+			fd = openat(workdirfd, file, O_CREAT|O_WRONLY|O_TRUNC, fmode);
 	}
 	if (fd < 0)
-		syslog(LOG_ERR, "can't create file %s", file);
+		ERROR("can't create file %s", file);
 	return fd;
 }
 
@@ -111,13 +113,13 @@ int zread(const char *zipfile, unsigned long long maxsize)
 	/* open the zip file */
 	zip = zip_open(zipfile, ZIP_CHECKCONS, &err);
 	if (!zip) {
-		syslog(LOG_ERR, "Can't connect to file %s", zipfile);
+		ERROR("Can't connect to file %s", zipfile);
 		return -1;
 	}
 
 	z64 = zip_get_num_entries(zip, 0);
 	if (z64 < 0 || z64 > UINT_MAX) {
-		syslog(LOG_ERR, "too many entries in %s", zipfile);
+		ERROR("too many entries in %s", zipfile);
 		goto error;
 	}
 	count = (unsigned int)z64;
@@ -129,22 +131,22 @@ int zread(const char *zipfile, unsigned long long maxsize)
 		err = zip_stat_index(zip, index, ZIP_FL_ENC_GUESS, &zstat);
 		/* check the file name */
 		if (!is_valid_filename(zstat.name)) {
-			syslog(LOG_ERR, "invalid entry %s found in %s", zstat.name, zipfile);
+			ERROR("invalid entry %s found in %s", zstat.name, zipfile);
 			goto error;
 		}
 		if (zstat.name[0] == '/') {
-			syslog(LOG_ERR, "absolute entry %s found in %s", zstat.name, zipfile);
+			ERROR("absolute entry %s found in %s", zstat.name, zipfile);
 			goto error;
 		}
 		len = strlen(zstat.name);
 		if (len == 0) {
-			syslog(LOG_ERR, "empty entry found in %s", zipfile);
+			ERROR("empty entry found in %s", zipfile);
 			goto error;
 		}
 		if (zstat.size == 0) {
 			/* directory name */
 			if (zstat.name[len - 1] != '/') {
-				syslog(LOG_ERR, "bad directory name %s in %s", zstat.name, zipfile);
+				ERROR("bad directory name %s in %s", zstat.name, zipfile);
 				goto error;
 			}
 			/* record */
@@ -152,7 +154,7 @@ int zread(const char *zipfile, unsigned long long maxsize)
 		} else {
 			/* directory name */
 			if (zstat.name[len - 1] == '/') {
-				syslog(LOG_ERR, "bad file name %s in %s", zstat.name, zipfile);
+				ERROR("bad file name %s in %s", zstat.name, zipfile);
 				goto error;
 			}
 			/* get the size */
@@ -167,7 +169,7 @@ int zread(const char *zipfile, unsigned long long maxsize)
 
 	/* check the size */
 	if (maxsize && esize > maxsize) {
-		syslog(LOG_ERR, "extracted size %zu greater than allowed size %llu", esize, maxsize);
+		ERROR("extracted size %zu greater than allowed size %llu", esize, maxsize);
 		goto error;
 	}
 
@@ -187,7 +189,7 @@ int zread(const char *zipfile, unsigned long long maxsize)
 			/* file name */
 			zfile = zip_fopen_index(zip, fdesc->zindex, 0);
 			if (!zfile) {
-				syslog(LOG_ERR, "Can't open %s in %s", zstat.name, zipfile);
+				ERROR("Can't open %s in %s", zstat.name, zipfile);
 				goto error;
 			}
 			fd = create_file((char*)zstat.name, MODE_OF_FILE_CREATION, MODE_OF_DIRECTORY_CREATION);
@@ -198,12 +200,12 @@ int zread(const char *zipfile, unsigned long long maxsize)
 			while (z64) {
 				sizr = zip_fread(zfile, buffer, sizeof buffer);
 				if (sizr < 0) {
-					syslog(LOG_ERR, "error while reading %s in %s", zstat.name, zipfile);
+					ERROR("error while reading %s in %s", zstat.name, zipfile);
 					goto errorzf;
 				}
 				sizw = write(fd, buffer, sizr);
 				if (sizw < 0) {
-					syslog(LOG_ERR, "error while writing %s", zstat.name);
+					ERROR("error while writing %s", zstat.name);
 					goto errorzf;
 				}
 				z64 -= sizw;
@@ -233,23 +235,28 @@ struct zws {
 
 static int zwr(struct zws *zws, int offset)
 {
-	int len, err;
+	int len, err, fd;
 	DIR *dir;
 	struct dirent *ent;
 	zip_int64_t z64;
 	struct zip_source *zsrc;
+	FILE *fp;
 
-	if (offset == 0)
-		dir = opendir(".");
-	else {
-		dir = opendir(zws->name);
-		zws->name[offset++] = '/';
+	fd = openat(workdirfd, offset ? zws->name : ".", O_DIRECTORY|O_RDONLY);
+	if (fd < 0) {
+		ERROR("opendir %.*s failed in zwr", offset, zws->name);
+		return -1;
 	}
+	dir = fdopendir(fd);
 	if (!dir) {
-		syslog(LOG_ERR, "opendir %.*s failed in zwr", offset, zws->name);
+		close(fd);
+		ERROR("opendir %.*s failed in zwr", offset, zws->name);
 		return -1;
 	}
 
+	if (offset != 0)
+		zws->name[offset++] = '/';
+
 	ent = readdir(dir);
 	while (ent != NULL) {
 		len = strlen(ent->d_name);
@@ -257,20 +264,20 @@ static int zwr(struct zws *zws, int offset)
 			(ent->d_name[1] == '.' && len == 2)))
 			;
 		else if (offset + len >= sizeof(zws->name)) {
-			syslog(LOG_ERR, "name too long in zwr");
+			ERROR("name too long in zwr");
 			errno = ENAMETOOLONG;
 			goto error;
 		} else {
 			memcpy(zws->name + offset, ent->d_name, 1+len);
 			if (!is_valid_filename(ent->d_name)) {
-				syslog(LOG_ERR, "invalid name %s", zws->name);
+				ERROR("invalid name %s", zws->name);
 				goto error;
 			}
 			switch (ent->d_type) {
 			case DT_DIR:
 				z64 = zip_dir_add(zws->zip, zws->name, ZIP_FL_ENC_UTF_8);
 				if (z64 < 0) {
-					syslog(LOG_ERR, "zip_dir_add of %s failed", zws->name);
+					ERROR("zip_dir_add of %s failed", zws->name);
 					goto error;
 				}
 				err = zwr(zws, offset + len);
@@ -278,14 +285,26 @@ static int zwr(struct zws *zws, int offset)
 					goto error;
 				break;
 			case DT_REG:
-				zsrc = zip_source_file(zws->zip, zws->name, 0, 0);
+				fd = openat(workdirfd, zws->name, O_RDONLY);
+				if (fd < 0) {
+					ERROR("openat of %s failed", zws->name);
+					goto error;
+				}
+				fp = fdopen(fd, "r");
+				if (fp == NULL) {
+					ERROR("fdopen of %s failed", zws->name);
+					close(fd);
+					goto error;
+				}
+				zsrc = zip_source_filep(zws->zip, fp, 0, 0);
 				if (zsrc == NULL) {
-					syslog(LOG_ERR, "zip_source_file of %s failed", zws->name);
+					ERROR("zip_source_file of %s failed", zws->name);
+					fclose(fp);
 					goto error;
 				}
 				z64 = zip_file_add(zws->zip, zws->name, zsrc, ZIP_FL_ENC_UTF_8);
 				if (z64 < 0) {
-					syslog(LOG_ERR, "zip_file_add of %s failed", zws->name);
+					ERROR("zip_file_add of %s failed", zws->name);
 					zip_source_free(zsrc);
 					goto error;
 				}
@@ -312,7 +331,7 @@ int zwrite(const char *zipfile)
 
 	zws.zip = zip_open(zipfile, ZIP_CREATE|ZIP_TRUNCATE, &err);
 	if (!zws.zip) {
-		syslog(LOG_ERR, "Can't open %s for write", zipfile);
+		ERROR("Can't open %s for write", zipfile);
 		return -1;
 	}