Move member from obd2_signals_t class to

[apps/low-level-can-service.git] / src / diagnostic / diagnostic-message.cpp

diff --git a/src/diagnostic/diagnostic-message.cpp b/src/diagnostic/diagnostic-message.cpp
index 8b2273e..5a8f9e5 100644 (file)
--- a/src/diagnostic/diagnostic-message.cpp
+++ b/src/diagnostic/diagnostic-message.cpp
@@ -33,8 +33,6 @@ const char *UNIT_NAMES[10] = {
        "NM"
 };
 
-std::string obd2_signal_t::prefix_ = "diagnostic_messages.";
-
 obd2_signal_t::obd2_signal_t(uint8_t pid, const char* generic_name, const int min, const int max, enum UNIT unit, int frequency, bool supported)
        :       pid_{pid}, generic_name_{generic_name}, min_{min}, max_{max}, unit_{unit}, frequency_{frequency}, supported_{supported}
 {
@@ -52,12 +50,7 @@ const std::string& obd2_signal_t::get_generic_name() const
 
 const std::string obd2_signal_t::get_name() const
 {
-       return prefix_ + "." + generic_name_;
-}
-
-const std::string& obd2_signal_t::get_prefix()
-{
-       return prefix_;
+       return active_diagnostic_request_t::get_prefix() + "." + generic_name_;
 }
 
 int obd2_signal_t::get_frequency() const
@@ -65,11 +58,6 @@ int obd2_signal_t::get_frequency() const
        return frequency_;
 }
 
-void obd2_signal_t::set_prefix(const std::string& val)
-{
-       prefix_ = val;
-}
-
 /**
  * @brief Build a DiagnosticRequest struct to be passed
  *  to diagnostic manager instance.
@@ -87,72 +75,16 @@ const DiagnosticRequest obd2_signal_t::build_diagnostic_request()
                        /*DiagnosticRequestType: */DiagnosticRequestType::DIAGNOSTIC_REQUEST_TYPE_PID };
 }
 
-bool obd2_signal_t::is_obd2_response(can_message_t can_message)
-{
-       /*
-       if(can_message.get_id() >= 0x7E8 && can_message.get_id() <= 0x7EF)
-       {
-               openxc_VehicleMessage message = {0};
-               message.has_type = true;
-               message.type = openxc_VehicleMessage_Type_DIAGNOSTIC;
-               message.has_diagnostic_response = true;
-               message.diagnostic_response = {0};
-               message.diagnostic_response.has_bus = true;
-               message.diagnostic_response.bus = bus->address;
-               message.diagnostic_response.has_message_id = true;
-               //7DF should respond with a random message id between 7e8 and 7ef
-               //7E0 through 7E7 should respond with a id that is 8 higher (7E0->7E8)
-               if(can_message.get_id() == 0x7DF)
-               {
-                       message.diagnostic_response.message_id = rand()%(0x7EF-0x7E8 + 1) + 0x7E8;
-               }
-               else if(commandRequest->message_id >= 0x7E0 && commandRequest->message_id <= 0x7E7)
-               {
-                       message.diagnostic_response.message_id = commandRequest->message_id + 8;
-               }
-               message.diagnostic_response.has_mode = true;
-               message.diagnostic_response.mode = commandRequest->mode;
-               if(commandRequest->has_pid)
-               {
-                       message.diagnostic_response.has_pid = true;
-                       message.diagnostic_response.pid = commandRequest->pid;
-               }
-               message.diagnostic_response.has_value = true;
-               message.diagnostic_response.value = rand() % 100;
-               pipeline::publish(&message, &getConfiguration()->pipeline);
-       }
-       else //If it's outside the range, the command_request will return false
-       {
-               debug("Sent message ID is outside the valid range for emulator (7DF to 7E7)");
-               status=false;
-       }
-       return false;
-       */
-       return false;
-}      
-
 /**
 * @brief Check if a request is an OBD-II PID request.
 *
 * @return true if the request is a mode 1 request and it has a 1 byte PID.
 */
-bool obd2_signal_t::is_obd2_request(DiagnosticRequest* request)
+bool obd2_signal_t::is_obd2_request(const DiagnosticRequest* request)
 {
        return request->mode == 0x1 && request->has_pid && request->pid < 0xff;
 }
 
-/**
-* @brief Check if requested signal name is an obd2 pid
-* 
-* @return true if name began with obd2 else false.
-*/
-bool obd2_signal_t::is_obd2_signal(const std::string& name)
-{
-       if(name.find_first_of(prefix_.c_str(), 0, prefix_.size()))
-               return true;
-       return false;
-}
-
 /**
 * @brief Decode the payload of an OBD-II PID.
 *