Change TARGET variable name and remove CMakeTools
[apps/agl-service-can-low-level.git] / src / can-bus.cpp
index 8511bb1..f35319a 100644 (file)
@@ -43,7 +43,7 @@ extern "C"
 *
 *********************************************************************************/
 
-can_bus_t::can_bus_t(int& conf_file)
+can_bus_t::can_bus_t(int conf_file)
        : conf_file_{conf_file}
 {
 }
@@ -58,38 +58,41 @@ void can_bus_t::can_decode_message()
 
        decoder_t decoder;
 
-       DEBUG(binder_interface, "Beginning of decoding thread.");
-       while(is_decoding())
+       while(is_decoding_)
        {
                {
                        std::unique_lock<std::mutex> can_message_lock(can_message_mutex_);
                        new_can_message_.wait(can_message_lock);
                        can_message = next_can_message();
-               }
-
-               /* First we have to found which CanSignal it is */
-               search_key = build_DynamicField((double)can_message.get_id());
-               signals = find_can_signals(search_key);
+               
+                       /* First we have to found which CanSignal it is */
+                       search_key = build_DynamicField((double)can_message.get_id());
+                       signals = find_can_signals(search_key);
 
-               /* Decoding the message ! Don't kill the messenger ! */
-               for(auto& sig : signals)
-               {
+                       /* Decoding the message ! Don't kill the messenger ! */
+                       for(auto& sig : signals)
                        {
-                               std::lock_guard<std::mutex> subscribed_signals_lock(get_subscribed_signals_mutex());
-                               std::map<std::string, struct afb_event> subscribed_signals = get_subscribed_signals();
-                               const auto& it_event = subscribed_signals.find(sig.genericName);
-                               
-                               if(it_event != subscribed_signals.end() && afb_event_is_valid(it_event->second))
                                {
-                                       decoded_message = decoder.translateSignal(sig, can_message, getSignals());
-
-                                       openxc_SimpleMessage s_message = build_SimpleMessage(sig.genericName, decoded_message);
-                                       vehicle_message = build_VehicleMessage_with_SimpleMessage(openxc_DynamicField_Type::openxc_DynamicField_Type_NUM, s_message);
-
-                                       std::lock_guard<std::mutex> decoded_can_message_lock(decoded_can_message_mutex_);
-                                       push_new_vehicle_message(vehicle_message);
+                                       std::lock_guard<std::mutex> subscribed_signals_lock(get_subscribed_signals_mutex());
+                                       std::map<std::string, struct afb_event>& s = get_subscribed_signals();
+                                       
+                                       /* DEBUG message to make easier debugger STL containers...
+                                       DEBUG(binder_interface, "Operator[] key char: %s, event valid? %d", sig.genericName, afb_event_is_valid(s[sig.genericName]));
+                                       DEBUG(binder_interface, "Operator[] key string: %s, event valid? %d", sig.genericName, afb_event_is_valid(s[std::string(sig.genericName)]));
+                                       DEBUG(binder_interface, "Nb elt matched char: %d", (int)s.count(sig.genericName));
+                                       DEBUG(binder_interface, "Nb elt matched string: %d", (int)s.count(std::string(sig.genericName))); */
+                                       if( s.find(sig.genericName) != s.end() && afb_event_is_valid(s[sig.genericName]))
+                                       {
+                                               decoded_message = decoder.translateSignal(sig, can_message, getSignals());
+
+                                               openxc_SimpleMessage s_message = build_SimpleMessage(sig.genericName, decoded_message);
+                                               vehicle_message = build_VehicleMessage_with_SimpleMessage(openxc_DynamicField_Type::openxc_DynamicField_Type_NUM, s_message);
+
+                                               std::lock_guard<std::mutex> decoded_can_message_lock(decoded_can_message_mutex_);
+                                               push_new_vehicle_message(vehicle_message);
+                                               new_decoded_can_message_.notify_one();
+                                       }
                                }
-                               new_decoded_can_message_.notify_one();
                        }
                }
        }
@@ -101,26 +104,23 @@ void can_bus_t::can_event_push()
        openxc_SimpleMessage s_message;
        json_object* jo;
        
-       DEBUG(binder_interface, "Beginning of the pushing thread");
-       while(is_pushing())
+       while(is_pushing_)
        {
                {
                        std::unique_lock<std::mutex> decoded_can_message_lock(decoded_can_message_mutex_);
                        new_decoded_can_message_.wait(decoded_can_message_lock);
                        v_message = next_vehicle_message();
-               }
-
-               s_message = get_simple_message(v_message);
 
-               {
-                       std::lock_guard<std::mutex> subscribed_signals_lock(get_subscribed_signals_mutex());
-                       std::map<std::string, struct afb_event> subscribed_signals = get_subscribed_signals();
-                       const auto& it_event = subscribed_signals.find(s_message.name);
-                       if(it_event != subscribed_signals.end() && afb_event_is_valid(it_event->second))
+                       s_message = get_simple_message(v_message);
                        {
-                               jo = json_object_new_object();
-                               jsonify_simple(s_message, jo);
-                               afb_event_push(it_event->second, jo);
+                               std::lock_guard<std::mutex> subscribed_signals_lock(get_subscribed_signals_mutex());
+                               std::map<std::string, struct afb_event>& s = get_subscribed_signals();
+                               if(s.find(std::string(s_message.name)) != s.end() && afb_event_is_valid(s[std::string(s_message.name)]))
+                               {
+                                       jo = json_object_new_object();
+                                       jsonify_simple(s_message, jo);
+                                       afb_event_push(s[std::string(s_message.name)], jo);
+                               }
                        }
                }
        }
@@ -128,28 +128,21 @@ void can_bus_t::can_event_push()
 
 void can_bus_t::start_threads()
 {
-       th_decoding_ = std::thread(&can_bus_t::can_decode_message, this);
        is_decoding_ = true;
-       th_pushing_ = std::thread(&can_bus_t::can_event_push, this);
+       th_decoding_ = std::thread(&can_bus_t::can_decode_message, this);
+       if(!th_decoding_.joinable())
+               is_decoding_ = false;
+       
        is_pushing_ = true;
+       th_pushing_ = std::thread(&can_bus_t::can_event_push, this);
+       if(!th_pushing_.joinable())
+               is_pushing_ = false;
 }
 
 void can_bus_t::stop_threads()
 {
        is_decoding_ = false;
        is_pushing_ = false;
-       th_decoding_.join();
-       th_pushing_.join();
-}
-
-bool can_bus_t::is_decoding()
-{
-       return is_decoding_;
-}
-
-bool can_bus_t::is_pushing()
-{
-       return is_pushing_;
 }
 
 int can_bus_t::init_can_dev()
@@ -167,12 +160,13 @@ int can_bus_t::init_can_dev()
 
                for(const auto& device : devices_name)
                {
-                       can_bus_dev_t can_bus_device_handler(device);
-                       if (can_bus_device_handler.open() == 0)
+                       can_devices_m_[device] = std::make_shared<can_bus_dev_t>(device);
+                       if (can_devices_m_[device]->open() == 0)
                        {
                                i++;
                                DEBUG(binder_interface, "Start reading thread");
-                               can_bus_device_handler.start_reading(*this);
+                               NOTICE(binder_interface, "%s device opened and reading", device.c_str());
+                               can_devices_m_[device]->start_reading(*this);
                        }
                        else
                                ERROR(binder_interface, "Can't open device %s", device.c_str());
@@ -247,12 +241,11 @@ can_message_t can_bus_t::next_can_message()
        {
                can_msg = can_message_q_.front();
                can_message_q_.pop();
-               DEBUG(binder_interface, "next_can_message: Here is the next can message : id %d, length %d", can_msg.get_id(), can_msg.get_length());
+               DEBUG(binder_interface, "next_can_message: Here is the next can message : id %X, length %X, data %02X%02X%02X%02X%02X%02X%02X%02X", can_msg.get_id(), can_msg.get_length(),
+                       can_msg.get_data()[0], can_msg.get_data()[1], can_msg.get_data()[2], can_msg.get_data()[3], can_msg.get_data()[4], can_msg.get_data()[5], can_msg.get_data()[6], can_msg.get_data()[7]);
                return can_msg;
        }
        
-       NOTICE(binder_interface, "next_can_message: End of can message queue");
-       has_can_message_ = false;
        return can_msg;
 }
 
@@ -273,15 +266,17 @@ openxc_VehicleMessage can_bus_t::next_vehicle_message()
                return v_msg;
        }
        
-       NOTICE(binder_interface, "next_vehicle_message: End of vehicle message queue");
-       has_vehicle_message_ = false;
        return v_msg;
 }
 
 void can_bus_t::push_new_vehicle_message(const openxc_VehicleMessage& v_msg)
 {
        vehicle_message_q_.push(v_msg);
-       has_vehicle_message_ = true;
+}
+
+std::map<std::string, std::shared_ptr<can_bus_dev_t>> can_bus_t::get_can_devices()
+{
+       return can_devices_m_;
 }
 
 /********************************************************************************
@@ -357,11 +352,11 @@ int can_bus_dev_t::close()
        return can_socket_;
 }
 
-canfd_frame can_bus_dev_t::read()
+std::pair<struct canfd_frame&, size_t> can_bus_dev_t::read()
 {
        ssize_t nbytes;
        //int maxdlen;
-       canfd_frame canfd_frame;
+       struct canfd_frame cfd;
 
        /* Test that socket is really opened */
        if (can_socket_ < 0)
@@ -370,54 +365,41 @@ canfd_frame can_bus_dev_t::read()
                is_running_ = false;
        }
 
-       nbytes = ::read(can_socket_, &canfd_frame, CANFD_MTU);
+       nbytes = ::read(can_socket_, &cfd, CANFD_MTU);
 
-       switch(nbytes)
+       /* if we did not fit into CAN sized messages then stop_reading. */
+       if (nbytes != CANFD_MTU && nbytes != CAN_MTU)
        {
-               case CANFD_MTU:
-                       DEBUG(binder_interface, "read_can: Got an CAN FD frame with length %d", canfd_frame.len);
-                       //maxdlen = CANFD_MAX_DLEN;
-                       break;
-               case CAN_MTU:
-                       DEBUG(binder_interface, "read_can: Got a legacy CAN frame with length %d", canfd_frame.len);
-                       //maxdlen = CAN_MAX_DLEN;
-                       break;
-               default:
-                       if (errno == ENETDOWN)
-                                       ERROR(binder_interface, "read_can: %s binder_interface down", device_name_);
-                       ERROR(binder_interface, "read_can: Error reading CAN bus");
-                       ::memset(&canfd_frame, 0, sizeof(canfd_frame));
-                       is_running_ = false;
-                       break;
+               if (errno == ENETDOWN)
+                       ERROR(binder_interface, "read: %s CAN device down", device_name_);
+               ERROR(binder_interface, "read: Incomplete CAN(FD) frame");
+               ::memset(&cfd, 0, sizeof(cfd));
        }
        
-       return canfd_frame;
-}
-
-bool can_bus_dev_t::is_running()
-{
-       return is_running_;
+       DEBUG(binder_interface, "read: Found id: %X, length: %X, data %02X%02X%02X%02X%02X%02X%02X%02X", cfd.can_id, cfd.len,
+                                                       cfd.data[0], cfd.data[1], cfd.data[2], cfd.data[3], cfd.data[4], cfd.data[5], cfd.data[6], cfd.data[7]);
+       return std::pair<struct canfd_frame&, size_t>(cfd, nbytes);
 }
 
 void can_bus_dev_t::start_reading(can_bus_t& can_bus)
 {
        DEBUG(binder_interface, "Launching reading thread");
-       th_reading_ = std::thread(&can_bus_dev_t::can_reader, this, std::ref(can_bus));
        is_running_ = true;
+       th_reading_ = std::thread(&can_bus_dev_t::can_reader, this, std::ref(can_bus));
+       if(!th_reading_.joinable())
+               is_running_ = false;
 }
 
 void can_bus_dev_t::stop_reading()
 {
        is_running_ = false;
-       th_reading_.join();
 }
 
 void can_bus_dev_t::can_reader(can_bus_t& can_bus)
 {
        can_message_t can_message;
 
-       DEBUG(binder_interface, "Beginning of reading thread");
-       while(is_running())
+       while(is_running_)
        {
                can_message.convert_from_canfd_frame(read());