Bug Fix : role in WMClientContext is not set
[apps/agl-service-windowmanager.git] / src / app.cpp
index 386524d..d11ec8a 100644 (file)
@@ -35,7 +35,7 @@
 #include <regex>
 #include <thread>
 
-#include "wm-client.hpp"
+#include "wm_client.hpp"
 #include "applist.hpp"
 
 extern "C"
@@ -453,21 +453,22 @@ void App::stop_timer()
     }
 }
 
-bool App::lm_release(const struct WMAction &action)
+WMError App::lm_release(const struct WMAction &action)
 {
     //auto const &surface_id = this->lookup_id(drawing_name);
+    WMError ret = WMError::LAYOUT_CHANGE_FAIL;
     unsigned req_num = g_app_list.currentRequestNumber();
     auto const &surface_id = this->lookup_id(action.role.c_str());
     if (!surface_id)
     {
         HMI_SEQ_ERROR(req_num, "Surface does not exist");
-        return false;
+        return ret;
     }
 
     if (*surface_id == this->layers.main_surface)
     {
         HMI_SEQ_ERROR(req_num, "Cannot deactivate main_surface");
-        return false;
+        return ret;
     }
 
     auto o_state = *this->layers.get_layout_state(*surface_id);
@@ -475,7 +476,7 @@ bool App::lm_release(const struct WMAction &action)
     if (o_state == nullptr)
     {
         HMI_SEQ_ERROR(req_num, "Could not find layer for surface");
-        return false;
+        return ret;
     }
 
     struct LayoutState &state = *o_state;
@@ -483,7 +484,7 @@ bool App::lm_release(const struct WMAction &action)
     if (state.main == -1)
     {
         HMI_SEQ_ERROR(req_num, "No surface active");
-        return false;
+        return ret;
     }
 
     // Check against main_surface, main_surface_name is the configuration item.
@@ -491,12 +492,12 @@ bool App::lm_release(const struct WMAction &action)
     {
         HMI_SEQ_DEBUG(req_num, "Refusing to deactivate main_surface %d", *surface_id);
         //reply(nullptr);
-        return true;
+        return WMError::SUCCESS;
     }
     if ((state.main == *surface_id) && (state.sub == *surface_id))
     {
         HMI_SEQ_ERROR(req_num, "Surface is not active");
-        return false;
+        return ret;
     }
 
     if (state.main == *surface_id)
@@ -546,10 +547,10 @@ bool App::lm_release(const struct WMAction &action)
                 this->enqueue_flushdraw(state.main);
             });
     }
-    return true;
+    return WMError::SUCCESS;
 }
 
-bool App::lm_layout_change(const struct WMAction &action)
+WMError App::lm_layout_change(const struct WMAction &action)
 {
     const char *msg = this->check_surface_exist(action.role.c_str());
 
@@ -559,21 +560,27 @@ bool App::lm_layout_change(const struct WMAction &action)
     if (msg)
     {
         HMI_SEQ_DEBUG(g_app_list.currentRequestNumber(), msg);
-        //g_app_list.removeRequest(req_num);
-        return false;
+        return WMError::LAYOUT_CHANGE_FAIL;
     }
     this->lm_layout_change(action.role.c_str());
-    return true;
+    return WMError::SUCCESS;
 }
 
-bool App::do_transition(unsigned req_num)
+WMError App::do_transition(unsigned req_num)
 {
     /*
     * Check Policy
     */
     // get current trigger
-    auto trigger = g_app_list.getRequest(req_num);
+    bool found;
     bool is_activate = true;
+    auto trigger = g_app_list.getRequest(req_num, &found);
+    if(!found)
+    {
+        WMError err = WMError::NO_ENTRY;
+        HMI_SEQ_ERROR(req_num, errorDescription(err));
+        return err;
+    }
 
     /*  get new status from Policy Manager
 
@@ -595,10 +602,10 @@ bool App::do_transition(unsigned req_num)
     {
         is_activate = false;
     }
-    bool ret = g_app_list.setAction(req_num, trigger.appid, trigger.role, trigger.area, is_activate);
+    WMError ret = g_app_list.setAction(req_num, trigger.appid, trigger.role, trigger.area, is_activate);
     g_app_list.reqDump();
 
-    if (!ret)
+    if (ret != WMError::SUCCESS)
     {
         HMI_SEQ_ERROR(req_num, "Failed to set action");
         return ret;
@@ -606,8 +613,14 @@ bool App::do_transition(unsigned req_num)
 
     // layer manager task
     bool sync_draw_happen = false;
-    for (const auto &y : g_app_list.getActions(req_num))
+    for (const auto &y : g_app_list.getActions(req_num, &found))
     {
+        if (!found)
+        {
+            WMError err = WMError::NO_ENTRY;
+            HMI_SEQ_ERROR(req_num, "%s : Action is not set", errorDescription(err));
+            return err;
+        }
         /*
         do_task(y);
         */
@@ -619,9 +632,10 @@ bool App::do_transition(unsigned req_num)
         {
             sync_draw_happen = true;
             ret = lm_layout_change(y);
-            if (!ret)
+            if (ret != WMError::SUCCESS)
             {
-                HMI_SEQ_ERROR(req_num, "Failed layout change: %s", y.appid.c_str());
+                HMI_SEQ_ERROR(req_num, "%s: appid: %s, role: %s, area: %s",
+                    errorDescription(ret), y.appid.c_str(), y.role.c_str(), y.area.c_str());
                 g_app_list.removeRequest(req_num);
                 break;
                 // TODO: if transition fails, what should we do?
@@ -642,11 +656,11 @@ bool App::do_transition(unsigned req_num)
         }
     }
 
-    if (!ret)
+    if (ret != WMError::SUCCESS)
     {
         //this->emit_error(req_num, 0 /*error_num*/, "error happens"); // test
     }
-    else if (ret && sync_draw_happen)
+    else if (sync_draw_happen)
     {
         this->set_timer();
     }
@@ -759,17 +773,20 @@ void App::lm_layout_change(const char *drawing_name)
                         compositor::rect area_rect_main = this->area_info[state.main];
                         compositor::rect area_rect_sub = this->area_info[*surface_id];
                         // >>> HACK
-                        HMI_WARNING("wm", "HACK!!!");
-                        std::string hack_appid = "hack";
+                        HMI_WARNING("wm", "HACK!!! mediaplayer and hvac is only supported for split");
+                        std::string request_role = drawing_name;
+                        //std::string request_app = transform(request_role.begin(), request_role.end(), request_role.begin(), tolower); //hvac or mediaplayer
+                        std::string hack_appid = "navigation";
                         std::string hack_role = main;
                         std::string hack_area = str_area_main;
                         g_app_list.setAction(g_app_list.currentRequestNumber(), hack_appid, hack_role, hack_area, true);
-                        g_app_list.setEndDrawFinished(g_app_list.currentRequestNumber(), hack_appid, hack_role); // This process is illegal
+                        //g_app_list.setEndDrawFinished(g_app_list.currentRequestNumber(), request_role, request_role);
+                        //g_app_list.setEndDrawFinished(g_app_list.currentRequestNumber(), hack_appid, hack_role); // This process is illegal
                         // >>> HACK
                         this->emit_syncdraw(main.c_str(), str_area_main.c_str(),
                                             area_rect_main.x, area_rect_main.y,
                                             area_rect_main.w, area_rect_main.h);
-                        this->emit_syncdraw(drawing_name, str_area_sub.c_str(),
+                        this->emit_syncdraw(request_role.c_str(), str_area_sub.c_str(),
                                             area_rect_sub.x, area_rect_sub.y,
                                             area_rect_sub.w, area_rect_sub.h);
                         this->enqueue_flushdraw(state.main);
@@ -895,11 +912,11 @@ void App::api_activate_surface(char const *appid, char const *drawing_name, char
     /*
     * Do allocate tasks
     */
-    bool ret = this->do_transition(new_req);
+    WMError ret = this->do_transition(new_req);
 
-    if (!ret)
+    if (ret != WMError::SUCCESS)
     {
-        HMI_SEQ_ERROR(new_req, "failed to do_transition");
+        HMI_SEQ_ERROR(new_req, errorDescription(ret));
         //this->emit_error()
     }
 }
@@ -951,11 +968,11 @@ void App::api_deactivate_surface(char const *appid, char const *drawing_name, co
     /*
     * Do allocate tasks
     */
-    bool ret = this->do_transition(new_req);
+    WMError ret = this->do_transition(new_req);
 
-    if (!ret)
+    if (ret != WMError::SUCCESS)
     {
-        HMI_SEQ_ERROR(new_req, "failed to do_transition");
+        HMI_SEQ_ERROR(new_req, errorDescription(ret));
         //this->emit_error()
     }
 }
@@ -1002,7 +1019,15 @@ void App::lm_enddraw(const char *drawing_name)
 void App::do_enddraw(unsigned req_num)
 {
     // get actions
-    auto actions = g_app_list.getActions(req_num);
+    bool found;
+    auto actions = g_app_list.getActions(req_num, &found);
+    if (!found)
+    {
+        WMError err = WMError::NO_ENTRY;
+        HMI_SEQ_ERROR(req_num, errorDescription(err));
+        return;
+    }
+
     HMI_SEQ_INFO(req_num, "do endDraw");
 
     for (const auto &act : actions)
@@ -1024,7 +1049,10 @@ void App::process_request()
 {
     unsigned req = g_app_list.currentRequestNumber();
     HMI_SEQ_DEBUG(req, "Do next request");
-    do_transition(req);
+    WMError rc = do_transition(req);
+    if(rc != WMError::SUCCESS){
+        HMI_SEQ_ERROR(req, errorDescription(rc));
+    }
 }
 
 void App::api_enddraw(char const *appid, char const *drawing_name)