Add a draft protobuf format for diagnostic requests.

[apps/agl-service-can-low-level.git] / openxc.proto

diff --git a/openxc.proto b/openxc.proto
index 72cd33f..259bdfb 100644 (file)
--- a/openxc.proto
+++ b/openxc.proto
@@ -4,27 +4,52 @@ option java_package = "com.openxc";
 option java_outer_classname = "BinaryMessages";
 
 message VehicleMessage {
-    enum Type { RAW = 1; TRANSLATED = 2; }
+    enum Type { RAW = 1; TRANSLATED = 2; DIAGNOSTIC = 3; }
 
     optional Type type = 1;
     optional RawMessage raw_message = 2;
     optional TranslatedMessage translated_message = 3;
+    optional DiagnosticResponse diagnostic_response = 4;
 }
 
 message RawMessage {
     optional int32 bus = 1;
     optional uint32 message_id = 2;
-    optional uint64 data = 3;
+    optional bytes data = 3;
 }
 
-message DiagnosticMessage {
+message ControlCommand {
+    enum Type { VERSION = 1; DEVICE_ID = 2; DIAGNOSTIC = 3; }
+
+    optional Type type = 1;
+    optional DiagnosticRequest diagnostic_request = 2;
+}
+
+message DiagnosticRequest {
+    optional int32 bus = 1;
+    optional uint32 message_id = 2;
+    optional uint32 mode = 3;
+    optional uint32 pid = 4;
+    // TODO we are capping this at 8 bytes for now - need to change when we
+    // support multi-frame responses
+    optional bytes payload = 5;
+    optional bool parse_payload = 6;
+    optional double factor = 7;
+    optional double offset = 8;
+    optional double frequency = 9;
+}
+
+message DiagnosticResponse {
     optional int32 bus = 1;
     optional uint32 message_id = 2;
     optional uint32 mode = 3;
     optional uint32 pid = 4;
     optional bool success = 5;
     optional uint32 negative_response_code = 6;
-    optional uint64 payload = 7;
+    // TODO we are capping this at 8 bytes for now - need to change when we
+    // support multi-frame responses
+    optional bytes payload = 7;
+    optional double value = 8;
 }
 
 message TranslatedMessage {