Cleaning the code for now unused functions
[apps/agl-service-can-low-level.git] / low-can-binding / diagnostic / diagnostic-manager.hpp
index 1124ff9..26c869e 100644 (file)
@@ -27,7 +27,7 @@
 #include "../can/can-bus.hpp"
 #include "active-diagnostic-request.hpp"
 
-///  Each CAN bus needs its own set of shim functions, so this should
+///  Each CAN bus requires its own set of shim functions, so this should
 /// match the maximum CAN controller count.
 ///
 #define DIAGNOSTIC_RESPONSE_ARBITRATION_ID_OFFSET 0x8
@@ -35,7 +35,7 @@
 class active_diagnostic_request_t;
 
 ///
-/// @brief The core structure for running the diagnostics module by the binding.
+/// @brief The core structure for running the diagnostics module of the binding.
 ///
 /// This stores details about the active requests and shims required to connect
 /// the diagnostics library to the CAN device.
@@ -74,13 +74,13 @@ public:
        active_diagnostic_request_t* find_recurring_request(DiagnosticRequest& request);
 
        // Subscription parts
-       active_diagnostic_request_t* add_request(DiagnosticRequest* request, const std::string& name,
+       /*active_diagnostic_request_t* add_request(DiagnosticRequest* request, const std::string& name,
                bool waitForMultipleResponses, const DiagnosticResponseDecoder decoder,
-               const DiagnosticResponseCallback callback);
+               const DiagnosticResponseCallback callback);*/
        bool validate_optional_request_attributes(float frequencyHz);
        active_diagnostic_request_t* add_recurring_request(DiagnosticRequest* request, const char* name,
                bool waitForMultipleResponses, const DiagnosticResponseDecoder decoder,
-               const DiagnosticResponseCallback callback, float frequencyHz);
+               const DiagnosticResponseCallback callback, float frequencyHz, bool permanent);
 
        // Decoding part
        openxc_VehicleMessage relay_diagnostic_response(active_diagnostic_request_t* adr, const DiagnosticResponse& response, const uint64_t timestamp);