Remove in function rx_filter_can, the variable val was not used
[apps/agl-service-can-low-level.git] / low-can-binding / binding / low-can-subscription.cpp
index bb48888..df5a8f4 100644 (file)
 #include "application.hpp"
 #include "canutil/write.h"
 #include "../utils/socketcan-bcm.hpp"
+#include "../can/can-encoder.hpp"
+
+#ifdef USE_FEATURE_ISOTP
+#include "../utils/socketcan-isotp.hpp"
+#endif
+
 #ifdef USE_FEATURE_J1939
 #include "../utils/socketcan-j1939/socketcan-j1939-data.hpp"
 #endif
@@ -95,8 +101,13 @@ int low_can_subscription_t::set_event()
  */
 int low_can_subscription_t::subscribe(afb_req_t request)
 {
-       if(set_event() < 0)
-               return -1;
+       if(! afb_event_is_valid(event_))
+       {
+               if(set_event() < 0)
+               {
+                       return -1;
+               }
+       }
        return afb_req_subscribe(request, event_);
 }
 
@@ -128,7 +139,7 @@ bool low_can_subscription_t::is_signal_subscription_corresponding(const std::sha
        return signal_ == signal && event_filter_ == event_filter;
 }
 
-const std::vector<std::shared_ptr<diagnostic_message_t> > low_can_subscription_t::get_diagnostic_message() const
+const vect_ptr_diag_msg_t low_can_subscription_t::get_diagnostic_message() const
 {
        return diagnostic_message_;
 }
@@ -205,6 +216,16 @@ float low_can_subscription_t::get_max() const
        return event_filter_.max;
 }
 
+canid_t low_can_subscription_t::get_rx_id() const
+{
+       return event_filter_.rx_id;
+}
+
+canid_t low_can_subscription_t::get_tx_id() const
+{
+       return event_filter_.tx_id;
+}
+
 std::shared_ptr<utils::socketcan_t> low_can_subscription_t::get_socket()
 {
        return socket_;
@@ -225,23 +246,37 @@ void low_can_subscription_t::set_max(float max)
        event_filter_.max = max;
 }
 
+void low_can_subscription_t::set_rx_id(canid_t rx_id)
+{
+       event_filter_.rx_id = rx_id;
+}
+
+void low_can_subscription_t::set_tx_id(canid_t tx_id)
+{
+       event_filter_.tx_id = tx_id;
+}
+
 void low_can_subscription_t::set_index(int index)
 {
        index_ = index;
 }
 
+void low_can_subscription_t::set_signal(std::shared_ptr<signal_t> signal)
+{
+       signal_ = signal;
+}
+
+
 /// @brief Based upon which object is a subscribed CAN signal or diagnostic message
 /// it will open the socket with the required CAN bus device name.
 ///
 /// @return INVALID_SOCKET on failure, else positive integer
-int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, const std::string& bus_name, socket_type type)
+int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, const std::string& bus_name,  uint32_t flags)
 {
        int ret = -1;
        if(! subscription.socket_)
        {
-               switch (type)
-               {
-               case socket_type::BCM:
+               if(flags&BCM_PROTOCOL)
                {
                        if( subscription.signal_ != nullptr)
                        {
@@ -259,10 +294,39 @@ int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, co
                                        ret = subscription.socket_->open(bus_name);
                        }
                        subscription.index_ = (int)subscription.socket_->socket();
-                       break;
                }
+#ifdef USE_FEATURE_ISOTP
+               else if(flags&ISOTP_PROTOCOL)
+               {
+                       if(subscription.signal_ != nullptr)
+                       {
+                               canid_t rx = NO_CAN_ID;
+                               canid_t tx = NO_CAN_ID;
+                               if(flags&ISOTP_SEND)
+                               {
+                                       rx = subscription.get_rx_id();
+                                       tx = subscription.signal_->get_message()->get_id();
+                               }
+                               else if(flags&ISOTP_RECEIVE)
+                               {
+                                       rx = subscription.signal_->get_message()->get_id();
+                                       tx = subscription.get_tx_id();
+                               }
+                               std::shared_ptr<utils::socketcan_isotp_t> socket = std::make_shared<utils::socketcan_isotp_t>();
+                               ret = socket->open(subscription.signal_->get_message()->get_bus_device_name(),rx,tx);
+                               subscription.socket_ = socket;
+                       }
+                       else if(!bus_name.empty())
+                       {
+                               std::shared_ptr<utils::socketcan_isotp_t> socket = std::make_shared<utils::socketcan_isotp_t>();
+                               ret = socket->open(bus_name, subscription.get_rx_id(),subscription.get_tx_id());
+                               subscription.socket_ = socket;
+                       }
+                       subscription.index_ = (int)subscription.socket_->socket();
+               }
+#endif
 #ifdef USE_FEATURE_J1939
-               case socket_type::J1939_ADDR_CLAIM:
+               else if(flags&J1939_ADDR_CLAIM_PROTOCOL)
                {
                        pgn_t pgn = J1939_NO_PGN;
                        if(!bus_name.empty())
@@ -272,9 +336,8 @@ int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, co
                                subscription.socket_ = socket;
                        }
                        subscription.index_ = (int)subscription.socket_->socket();
-                       break;
                }
-               case socket_type::J1939:
+               else if(flags&J1939_PROTOCOL)
                {
                        pgn_t pgn = J1939_NO_PGN;
                        if(subscription.signal_ != nullptr)
@@ -291,15 +354,12 @@ int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, co
                                subscription.socket_ = socket;
                        }
                        subscription.index_ = (int)subscription.socket_->socket();
-                       break;
                }
 #endif
-               default:
+               else
                {
                        AFB_ERROR("Socket format not supported");
                        return INVALID_SOCKET;
-                       break;
-               }
                }
        }
        else{
@@ -326,6 +386,7 @@ struct bcm_msg low_can_subscription_t::make_bcm_head(uint32_t opcode, uint32_t c
        bcm_msg.msg_head.ival2.tv_sec = frequency_thinning.tv_sec ;
        bcm_msg.msg_head.ival2.tv_usec = frequency_thinning.tv_usec;
 
+
        return bcm_msg;
 }
 
@@ -348,13 +409,24 @@ void low_can_subscription_t::add_one_bcm_frame(struct canfd_frame& cfd, struct b
        bcm_msg.msg_head.nframes++;
 }
 
+/// @brief Take an existing bcm_msg struct and add a can_frame.
+/// Currently only 1 uniq can_frame can be added, it's not possible to build
+/// a multiplexed message with several can_frame.
+void low_can_subscription_t::remove_last_bcm_frame(struct bcm_msg& bcm_msg)
+{
+       struct canfd_frame cf;
+       memset(&cf,0,sizeof(cf));
+       bcm_msg.fd_frames[bcm_msg.msg_head.nframes] = cf;
+       bcm_msg.msg_head.nframes--;
+}
+
 #ifdef USE_FEATURE_J1939
 int low_can_subscription_t::create_rx_filter_j1939(low_can_subscription_t &subscription, std::shared_ptr<signal_t> sig)
 {
        subscription.signal_= sig;
 
        // Make sure that socket is opened.
-       if(open_socket(subscription,"",socket_type::J1939) < 0)
+       if(open_socket(subscription,"",J1939_PROTOCOL) < 0)
        {
                        return -1;
        }
@@ -362,61 +434,126 @@ int low_can_subscription_t::create_rx_filter_j1939(low_can_subscription_t &subsc
 }
 #endif
 
+int low_can_subscription_t::create_rx_filter_isotp(low_can_subscription_t &subscription, std::shared_ptr<signal_t> sig)
+{
+       subscription.signal_= sig;
+
+       // Make sure that socket is opened.
+       if(open_socket(subscription,"",ISOTP_PROTOCOL|ISOTP_RECEIVE) < 0)
+       {
+                       return -1;
+       }
+       return 0;
+}
+
 /// @brief Create a RX_SETUP receive job to be used by the BCM socket for a CAN signal
 /// subscription
 ///
 /// @return 0 if ok else -1
 int low_can_subscription_t::create_rx_filter_can(low_can_subscription_t &subscription, std::shared_ptr<signal_t> sig)
 {
-       uint32_t flags;
-       float val;
+       uint32_t flags_bcm;
        struct timeval freq, timeout = {0, 0};
        struct canfd_frame cfd;
        subscription.signal_= sig;
+       bool is_fd = sig->get_message()->is_fd();
+
+       std::vector<uint8_t> data;
+       uint32_t length_msg = sig->get_message()->get_length();
+
+       if(length_msg == 0)
+       {
+               AFB_ERROR("Error in the length of message with id %d",sig->get_message()->get_id());
+               return -1;
+       }
+
+       for(int i = 0; i<length_msg;i++)
+       {
+               data.push_back(0);
+       }
+
+       encoder_t::encode_data(subscription.signal_,data,true,false,true);
 
-       if (sig->get_message()->is_fd())
+       can_message_t cm;
+
+       if (is_fd)
        {
-               flags = SETTIMER|RX_NO_AUTOTIMER|CAN_FD_FRAME;
+               flags_bcm = SETTIMER|RX_NO_AUTOTIMER|CAN_FD_FRAME;
                cfd.len = CANFD_MAX_DLEN;
+               cm = can_message_t( CANFD_MAX_DLEN,
+                                                       sig->get_message()->get_id(),
+                                                       length_msg,
+                                                       false,
+                                                       sig->get_message()->get_flags(),
+                                                       data,
+                                                       0);
        }
        else
        {
-               flags = SETTIMER|RX_NO_AUTOTIMER;
+               flags_bcm = SETTIMER|RX_NO_AUTOTIMER;
                cfd.len = CAN_MAX_DLEN;
+               cm = can_message_t( CAN_MAX_DLEN,
+                                                       sig->get_message()->get_id(),
+                                                       length_msg,
+                                                       false,
+                                                       sig->get_message()->get_flags(),
+                                                       data,
+                                                       0);
        }
-       val = (float)(1 << subscription.signal_->get_bit_size()) - 1;
-       if(! bitfield_encode_float(val,
-                                  subscription.signal_->get_bit_position(),
-                                  subscription.signal_->get_bit_size(),
-                                  1,
-                                  subscription.signal_->get_offset(),
-                                  cfd.data,
-                                  cfd.len))
-               return -1;
 
        frequency_clock_t f = subscription.event_filter_.frequency == 0 ? subscription.signal_->get_frequency() : frequency_clock_t(subscription.event_filter_.frequency);
        freq = f.get_timeval_from_period();
 
-       struct bcm_msg bcm_msg = subscription.make_bcm_head(RX_SETUP, subscription.signal_->get_message()->get_id(), flags, timeout, freq);
-       subscription.add_one_bcm_frame(cfd, bcm_msg);
+       struct bcm_msg bcm_msg = subscription.make_bcm_head(RX_SETUP, subscription.signal_->get_message()->get_id(), flags_bcm, timeout, freq);
+
+       std::vector<canfd_frame> cfd_vect = cm.convert_to_canfd_frame_vector();
+
+       if(cfd_vect.size() > 1) //multi
+       {
+               AFB_ERROR("Not implemented yet");
+               return -1;
+       }
+       else if(cfd_vect.size() == 1)
+       {
+               canfd_frame cf = cfd_vect[0];
+               for(int i=0;i<cfd.len;i++)
+               {
+                       cfd.data[i] = cf.data[i];
+               }
+               subscription.add_one_bcm_frame(cfd, bcm_msg);
+       }
+       else
+       {
+               AFB_ERROR("No data available");
+               return -1;
+       }
 
        return create_rx_filter_bcm(subscription, bcm_msg);
 }
 
 int low_can_subscription_t::create_rx_filter(std::shared_ptr<signal_t> sig)
 {
-       #ifdef USE_FEATURE_J1939
-       if(sig->get_message()->is_j1939())
+       if(!sig->get_message()->is_isotp() && !sig->get_message()->is_j1939())
+       {
+               return low_can_subscription_t::create_rx_filter_can(*this, sig);
+       }
+#ifdef USE_FEATURE_ISOTP
+       else if(sig->get_message()->is_isotp())
+       {
+               return low_can_subscription_t::create_rx_filter_isotp(*this,sig);
+       }
+#endif
+#ifdef USE_FEATURE_J1939
+       else if(sig->get_message()->is_j1939())
        {
                return low_can_subscription_t::create_rx_filter_j1939(*this, sig);
        }
+#endif
        else
        {
-       #endif
-               return low_can_subscription_t::create_rx_filter_can(*this, sig);
-       #ifdef USE_FEATURE_J1939
+               AFB_ERROR("Signal can't be j1939 and isotp");
+               return -1;
        }
-       #endif
 }
 
 
@@ -447,7 +584,7 @@ int low_can_subscription_t::create_rx_filter(std::shared_ptr<diagnostic_message_
 int low_can_subscription_t::create_rx_filter_bcm(low_can_subscription_t &subscription, struct bcm_msg& bcm_msg)
 {
        // Make sure that socket is opened.
-       if(subscription.open_socket(subscription,"",socket_type::BCM) < 0)
+       if(subscription.open_socket(subscription,"",BCM_PROTOCOL) < 0)
                {return -1;}
 
        // If it's not an OBD2 CAN ID then just add a simple RX_SETUP job
@@ -485,17 +622,41 @@ int low_can_subscription_t::tx_send(low_can_subscription_t &subscription, messag
 {
        can_message_t *cm = static_cast<can_message_t*>(message);
 
-       struct bcm_msg bcm_msg = subscription.make_bcm_head(TX_SEND, cm->get_id(),cm->get_flags());
-       canfd_frame cfd = cm->convert_to_canfd_frame();
-       subscription.add_one_bcm_frame(cfd, bcm_msg);
+       struct bcm_msg bcm_msg = subscription.make_bcm_head(TX_SEND, cm->get_id(),cm->get_flags()|TX_CP_CAN_ID); // TX_CP_CAN_ID -> copy in cfd the id of bcm
+       cm->set_bcm_msg(bcm_msg);
+
+       std::vector<canfd_frame> cfd_vect = cm->convert_to_canfd_frame_vector();
 
-       if(subscription.open_socket(subscription, bus_name,socket_type::BCM) < 0)
+       if(subscription.open_socket(subscription, bus_name, BCM_PROTOCOL) < 0)
        {
                        return -1;
        }
 
-       cm->set_bcm_msg(bcm_msg);
-       subscription.socket_->write_message(*cm);
+       struct bcm_msg &bcm_cm = cm->get_bcm_msg();
+
+
+
+       if(cfd_vect.size() > 1)
+       {
+               AFB_ERROR("Multi frame BCM not implemented");
+               return -1;
+       }
+       else if(cfd_vect.size() == 1) // raw or fd
+       {
+               subscription.add_one_bcm_frame(cfd_vect[0], bcm_cm);
+
+               if(subscription.socket_->write_message(*cm) < 0)
+               {
+                       AFB_ERROR("Error write message id : %d",cfd_vect[0].can_id);
+                       return -1;
+               }
+       }
+       else // error
+       {
+               AFB_ERROR("Error no data available");
+               return -1;
+       }
+
        if(! subscription.socket_.get())
        {
                        return -1;
@@ -510,7 +671,7 @@ int low_can_subscription_t::j1939_send(low_can_subscription_t &subscription, mes
        //struct bcm_msg bcm_msg = subscription.make_bcm_head(TX_SEND, cfd.can_id);
        //subscription.add_one_bcm_frame(cfd, bcm_msg);
 
-       if(subscription.open_socket(subscription, bus_name, socket_type::J1939) < 0)
+       if(subscription.open_socket(subscription, bus_name, J1939_PROTOCOL) < 0)
        {
                return -1;
        }
@@ -525,4 +686,25 @@ int low_can_subscription_t::j1939_send(low_can_subscription_t &subscription, mes
 
        return 0;
 }
-#endif
\ No newline at end of file
+#endif
+
+
+int low_can_subscription_t::isotp_send(low_can_subscription_t &subscription, message_t *message, const std::string& bus_name)
+{
+       //struct bcm_msg bcm_msg = subscription.make_bcm_head(TX_SEND, cfd.can_id);
+       //subscription.add_one_bcm_frame(cfd, bcm_msg);
+
+       if(subscription.open_socket(subscription, bus_name, ISOTP_PROTOCOL|ISOTP_SEND) < 0)
+       {
+               return -1;
+       }
+
+       can_message_t *cm = static_cast<can_message_t*>(message);
+       if(subscription.socket_->write_message(*cm) < 0)
+       {
+               AFB_ERROR("Error write iso tp message");
+               return -1;
+       }
+
+       return 0;
+}
\ No newline at end of file