Static code review fixes.
[apps/agl-service-can-low-level.git] / CAN-binder / low-can-binding / diagnostic / diagnostic-message.hpp
index 675e189..65ed9c0 100644 (file)
@@ -64,11 +64,11 @@ class diagnostic_message_t
 
        public:
                const char* generic_name = generic_name_.c_str();
-               diagnostic_message_t(uint8_t pid, const std::string generic_name, const int min, const int max, enum UNIT unit, float frequency,
+               diagnostic_message_t(uint8_t pid, const std::string& generic_name, const int min, const int max, enum UNIT unit, float frequency,
                                                                                        DiagnosticResponseDecoder decoder, DiagnosticResponseCallback callback, bool supported);
 
                uint32_t get_pid();
-               const std::string& get_generic_name() const;
+               const std::string get_generic_name() const;
                const std::string get_name() const;
                float get_frequency() const;
                DiagnosticResponseDecoder get_decoder() const;