Static code review fixes.

[apps/agl-service-can-low-level.git] / CAN-binder / low-can-binding / diagnostic / diagnostic-message.cpp

diff --git a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp
index 6f61557..df093b0 100644 (file)
--- a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp
+++ b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp
@@ -18,7 +18,7 @@
 
 #include "diagnostic-message.hpp"
 
-#include "../configuration.hpp"
+#include "../binding/configuration.hpp"
 #include "../utils/signals.hpp"
 
 const char *UNIT_NAMES[10] = {
@@ -34,10 +34,10 @@ const char *UNIT_NAMES[10] = {
        "NM"
 };
 
-diagnostic_message_t::diagnostic_message_t(uint8_t pid, const std::string generic_name, const int min,
+diagnostic_message_t::diagnostic_message_t(uint8_t pid, const std::string& generic_name, const int min,
        const int max, enum UNIT unit, float frequency, DiagnosticResponseDecoder decoder,
        DiagnosticResponseCallback callback, bool supported)
-       : pid_{pid}, generic_name_{generic_name}, min_{min}, max_{max}, unit_{unit},
+       : parent_{nullptr}, pid_{pid}, generic_name_{generic_name}, min_{min}, max_{max}, unit_{unit},
        frequency_{frequency}, decoder_{decoder}, callback_{callback}, supported_{supported}
 {}
 
@@ -46,7 +46,7 @@ uint32_t diagnostic_message_t::get_pid()
        return (uint32_t)pid_;
 }
 
-const std::string& diagnostic_message_t::get_generic_name() const
+const std::string diagnostic_message_t::get_generic_name() const
 {
        return generic_name_;
 }
@@ -80,6 +80,11 @@ void diagnostic_message_t::set_supported(bool value)
        supported_ = value;
 }
 
+void diagnostic_message_t::set_parent(can_message_set_t* parent)
+{
+       parent_ = parent;
+}
+
 ///
 /// @brief Build a DiagnosticRequest struct to be passed
 ///  to diagnostic manager instance.