Improve objects construction.

[apps/agl-service-can-low-level.git] / CAN-binder / low-can-binding / can / can-message-definition.cpp

diff --git a/CAN-binder/low-can-binding/can/can-message-definition.cpp b/CAN-binder/low-can-binding/can/can-message-definition.cpp
index e947026..19f06fb 100644 (file)
--- a/CAN-binder/low-can-binding/can/can-message-definition.cpp
+++ b/CAN-binder/low-can-binding/can/can-message-definition.cpp
@@ -17,12 +17,12 @@
 
 #include "can-message-definition.hpp"
 
-can_message_definition_t::can_message_definition_t(const std::string bus)
+can_message_definition_t::can_message_definition_t(const std::string& bus)
        : parent_{nullptr}, bus_{bus}, last_value_{CAN_MESSAGE_SIZE}
 {}
 
 can_message_definition_t::can_message_definition_t(
-       const std::string bus,
+       const std::string& bus,
        uint32_t id,
        frequency_clock_t frequency_clock,
        bool force_send_changed)
@@ -35,7 +35,7 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-       const std::string bus,
+       const std::string& bus,
        uint32_t id,
        can_message_format_t format,
        frequency_clock_t frequency_clock,
@@ -50,7 +50,7 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-       const std::string bus,
+       const std::string& bus,
        uint32_t id,
        can_message_format_t format,
        frequency_clock_t frequency_clock,
@@ -67,7 +67,7 @@ can_message_definition_t::can_message_definition_t(
 {
        for(auto& sig: can_signals_)
        {
-               sig->set_parent(std::make_shared<can_message_definition_t>(*this));
+               sig->set_parent(this);
        }
 }
 
@@ -82,7 +82,7 @@ can_message_definition_t::can_message_definition_t(
        can_signals_{b.can_signals_}
        {}*/
 
-const std::string& can_message_definition_t::get_bus_name() const
+const std::string can_message_definition_t::get_bus_name() const
 {
        return bus_;
 }
@@ -92,12 +92,12 @@ uint32_t can_message_definition_t::get_id() const
        return id_;
 }
 
-std::vector<std::shared_ptr<can_signal_t> > can_message_definition_t::get_can_signals()
+std::vector<std::shared_ptr<can_signal_t> >& can_message_definition_t::get_can_signals()
 {
        return can_signals_;
 }
 
-void can_message_definition_t::set_parent(std::shared_ptr<can_message_set_t> parent)
+void can_message_definition_t::set_parent(can_message_set_t* parent)
 {
        parent_= parent;
 }