Static code review fixes.

[apps/low-level-can-service.git] / CAN-binder / low-can-binding / can / can-bus.hpp

diff --git a/CAN-binder/low-can-binding/can/can-bus.hpp b/CAN-binder/low-can-binding/can/can-bus.hpp
index 94aa042..16d8cf6 100644 (file)
--- a/CAN-binder/low-can-binding/can/can-bus.hpp
+++ b/CAN-binder/low-can-binding/can/can-bus.hpp
@@ -26,11 +26,8 @@
 
 #include "openxc.pb.h"
 #include "can-message.hpp"
-#include "can-bus-dev.hpp"
-#include "can-signals.hpp"
 #include "../utils/config-parser.hpp"
-#include "../diagnostic/diagnostic-manager.hpp"
-#include "../low-can-binding.hpp"
+#include "../binding/low-can-hat.hpp"
 
 // TODO actual max is 32 but dropped to 24 for memory considerations
 #define MAX_ACCEPTANCE_FILTERS 24
@@ -39,6 +36,8 @@
 
 #define CAN_ACTIVE_TIMEOUT_S 30
 
+class diagnostic_manager_t;
+
 /// @brief Object used to handle decoding and manage event queue to be pushed.
 ///
 /// This object is also used to initialize can_bus_dev_t object after reading
@@ -51,13 +50,9 @@ class can_bus_t
 private:
        utils::config_parser_t conf_file_; ///< configuration file handle used to initialize can_bus_dev_t objects.
 
-       int process_can_signals(can_message_t& can_message);
+       int process_can_signals(const can_message_t& can_message);
        int process_diagnostic_signals(diagnostic_manager_t& manager, const can_message_t& can_message);
 
-       int can_reader();
-       std::thread th_reading_; ///< Thread handling read the socket can device filling can_message_q_ queue of can_bus_t
-       bool is_reading_ = false; ///< boolean telling whether or not reading is running or not
-
        void can_decode_message();
        std::thread th_decoding_; ///< thread that'll handle decoding a can frame
        bool is_decoding_ = false; ///< boolean member controling thread while loop
@@ -74,14 +69,14 @@ private:
        std::mutex decoded_can_message_mutex_;  ///< mutex protecting the vehicle_message_q_ queue.
        std::queue <openxc_VehicleMessage> vehicle_message_q_; ///< queue that'll store openxc_VehicleMessage to pushed
 
-       static std::map<std::string, std::shared_ptr<can_bus_dev_t>> can_devices_; ///< Can device map containing all can_bus_dev_t objects initialized during init_can_dev function
-
+       std::vector<std::pair<std::string, std::string> > can_devices_;
 public:
-       can_bus_t(utils::config_parser_t conf_file);
+       explicit can_bus_t(utils::config_parser_t conf_file);
        can_bus_t(can_bus_t&&);
 
-       int init_can_dev();
-       std::vector<std::string> read_conf();
+       void set_can_devices();
+       int get_can_device_index(const std::string& bus_name) const;
+       const std::string get_can_device_name(const std::string& id_name) const;
 
        void start_threads();
        void stop_threads();
@@ -93,9 +88,4 @@ public:
 
        openxc_VehicleMessage next_vehicle_message();
        void push_new_vehicle_message(const openxc_VehicleMessage& v_msg);
-
-       int create_rx_filter(const can_signal_t& signal);
-
-       const std::map<std::string, std::shared_ptr<can_bus_dev_t>>& get_can_devices() const;
-       static std::shared_ptr<can_bus_dev_t> get_can_device(std::string bus);
 };