Static code review fixes.

[apps/low-level-can-service.git] / CAN-binder / low-can-binding / can / can-bus.hpp

diff --git a/CAN-binder/low-can-binding/can/can-bus.hpp b/CAN-binder/low-can-binding/can/can-bus.hpp
index 7fe6ebf..16d8cf6 100644 (file)
--- a/CAN-binder/low-can-binding/can/can-bus.hpp
+++ b/CAN-binder/low-can-binding/can/can-bus.hpp
@@ -26,9 +26,7 @@
 
 #include "openxc.pb.h"
 #include "can-message.hpp"
-#include "can-signals.hpp"
 #include "../utils/config-parser.hpp"
-#include "../diagnostic/diagnostic-manager.hpp"
 #include "../binding/low-can-hat.hpp"
 
 // TODO actual max is 32 but dropped to 24 for memory considerations
@@ -38,6 +36,8 @@
 
 #define CAN_ACTIVE_TIMEOUT_S 30
 
+class diagnostic_manager_t;
+
 /// @brief Object used to handle decoding and manage event queue to be pushed.
 ///
 /// This object is also used to initialize can_bus_dev_t object after reading
@@ -71,12 +71,12 @@ private:
 
        std::vector<std::pair<std::string, std::string> > can_devices_;
 public:
-       can_bus_t(utils::config_parser_t conf_file);
+       explicit can_bus_t(utils::config_parser_t conf_file);
        can_bus_t(can_bus_t&&);
 
        void set_can_devices();
-       int get_can_device_index(std::string bus_name) const;
-       const std::string get_can_device_name(std::string id_name) const;
+       int get_can_device_index(const std::string& bus_name) const;
+       const std::string get_can_device_name(const std::string& id_name) const;
 
        void start_threads();
        void stop_threads();