Static code review fixes.

[apps/low-level-can-service.git] / CAN-binder / low-can-binding / binding / configuration.hpp

diff --git a/CAN-binder/low-can-binding/binding/configuration.hpp b/CAN-binder/low-can-binding/binding/configuration.hpp
index a3bb189..fc53d38 100644 (file)
--- a/CAN-binder/low-can-binding/binding/configuration.hpp
+++ b/CAN-binder/low-can-binding/binding/configuration.hpp
@@ -65,15 +65,15 @@ class configuration_t
 
                uint8_t get_active_message_set() const;
 
-               const std::vector<std::shared_ptr<can_message_set_t> >& get_can_message_set();
+               std::vector<std::shared_ptr<can_message_set_t> > get_can_message_set();
 
-               std::vector<std::shared_ptr<can_signal_t> > get_can_signals();
+               std::vector<std::shared_ptr<can_signal_t> > get_all_can_signals();
 
-               std::vector<std::shared_ptr<diagnostic_message_t> > get_diagnostic_messages();
+               std::vector<std::shared_ptr<diagnostic_message_t> >& get_diagnostic_messages();
 
                const std::vector<std::string>& get_signals_prefix() const;
 
-               std::vector<std::shared_ptr<can_message_definition_t> > get_can_message_definition();
+               std::vector<std::shared_ptr<can_message_definition_t> >& get_can_message_definition();
 
                uint32_t get_signal_id(diagnostic_message_t& sig) const;
 
@@ -81,8 +81,8 @@ class configuration_t
 
                void set_active_message_set(uint8_t id);
 
-               std::shared_ptr<diagnostic_message_t> get_diagnostic_message(std::string message_name) const;
-               DiagnosticRequest* get_request_from_diagnostic_message(std::string message_name) const;
+               std::shared_ptr<diagnostic_message_t> get_diagnostic_message(const std::string& message_name) const;
+               DiagnosticRequest* get_request_from_diagnostic_message(const std::string& message_name) const;
 /*
                /// TODO: implement this function as method into can_bus class
                /// @brief Pre initialize actions made before CAN bus initialization