Code Review
/
apps
/
low-level-can-service.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Use '\0' for NULL in c strings.
[apps/low-level-can-service.git]
/
tests
/
test_send.c
diff --git
a/tests/test_send.c
b/tests/test_send.c
index
ca1842a
..
3a18ff3
100644
(file)
--- a/
tests/test_send.c
+++ b/
tests/test_send.c
@@
-6,7
+6,6
@@
#include <stdarg.h>
extern IsoTpShims SHIMS;
#include <stdarg.h>
extern IsoTpShims SHIMS;
-extern IsoTpHandle HANDLE;
extern void message_sent(const IsoTpMessage* message, const bool success);
extern void message_sent(const IsoTpMessage* message, const bool success);
@@
-30,12
+29,12
@@
extern void setup();
START_TEST (test_send_empty_payload)
{
uint16_t arbitration_id = 0x2a;
START_TEST (test_send_empty_payload)
{
uint16_t arbitration_id = 0x2a;
- IsoTpHandle handle = isotp_send(&SHIMS, arbitration_id, NULL, 0, message_sent);
+ IsoTp
Send
Handle handle = isotp_send(&SHIMS, arbitration_id, NULL, 0, message_sent);
fail_unless(handle.success);
fail_unless(handle.completed);
ck_assert_int_eq(last_message_sent_arb_id, arbitration_id);
fail_unless(last_message_sent_status);
fail_unless(handle.success);
fail_unless(handle.completed);
ck_assert_int_eq(last_message_sent_arb_id, arbitration_id);
fail_unless(last_message_sent_status);
- ck_assert_int_eq(last_message_sent_payload[0],
NULL
);
+ ck_assert_int_eq(last_message_sent_payload[0],
'\0'
);
ck_assert_int_eq(last_message_sent_payload_size, 0);
ck_assert_int_eq(last_can_frame_sent_arb_id, arbitration_id);
ck_assert_int_eq(last_message_sent_payload_size, 0);
ck_assert_int_eq(last_can_frame_sent_arb_id, arbitration_id);
@@
-49,8
+48,7
@@
START_TEST (test_send_single_frame)
{
const uint8_t payload[] = {0x12, 0x34};
uint16_t arbitration_id = 0x2a;
{
const uint8_t payload[] = {0x12, 0x34};
uint16_t arbitration_id = 0x2a;
- IsoTpHandle handle = isotp_send(&SHIMS, arbitration_id, payload,
- sizeof(payload), message_sent);
+ isotp_send(&SHIMS, arbitration_id, payload, sizeof(payload), message_sent);
ck_assert_int_eq(last_message_sent_arb_id, arbitration_id);
fail_unless(last_message_sent_status);
ck_assert_int_eq(last_message_sent_payload[0], 0x12);
ck_assert_int_eq(last_message_sent_arb_id, arbitration_id);
fail_unless(last_message_sent_status);
ck_assert_int_eq(last_message_sent_payload[0], 0x12);
@@
-71,7
+69,7
@@
START_TEST (test_send_multi_frame)
const uint8_t payload[] = {0x12, 0x34, 0x56, 0x78, 0x90, 0x01, 0x23,
0x45, 0x67, 0x89};
uint16_t arbitration_id = 0x2a;
const uint8_t payload[] = {0x12, 0x34, 0x56, 0x78, 0x90, 0x01, 0x23,
0x45, 0x67, 0x89};
uint16_t arbitration_id = 0x2a;
- IsoTpHandle handle = isotp_send(&SHIMS, arbitration_id, payload, sizeof(payload),
+ IsoTp
Send
Handle handle = isotp_send(&SHIMS, arbitration_id, payload, sizeof(payload),
message_sent);
fail_unless(handle.completed);
fail_if(handle.success);
message_sent);
fail_unless(handle.completed);
fail_if(handle.success);