Code Review
/
src
/
app-framework-binder.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix concurrency issue in handling references
[src/app-framework-binder.git]
/
src
/
afb-session.c
diff --git
a/src/afb-session.c
b/src/afb-session.c
index
523cbf0
..
536cdbc
100644
(file)
--- a/
src/afb-session.c
+++ b/
src/afb-session.c
@@
-324,7
+324,7
@@
struct afb_session *afb_session_get (const char *uuid, int *created)
struct afb_session *afb_session_addref(struct afb_session *session)
{
if (session != NULL)
struct afb_session *afb_session_addref(struct afb_session *session)
{
if (session != NULL)
-
session->refcount++
;
+
__atomic_add_fetch(&session->refcount, 1, __ATOMIC_RELAXED)
;
return session;
}
return session;
}
@@
-332,11
+332,12
@@
void afb_session_unref(struct afb_session *session)
{
if (session != NULL) {
assert(session->refcount != 0);
{
if (session != NULL) {
assert(session->refcount != 0);
- --session->refcount;
- if (session->refcount == 0 && session->uuid[0] == 0) {
- destroy (session);
- pthread_mutex_destroy(&session->mutex);
- free(session);
+ if (!__atomic_sub_fetch(&session->refcount, 1, __ATOMIC_RELAXED)) {
+ if (session->uuid[0] == 0) {
+ destroy (session);
+ pthread_mutex_destroy(&session->mutex);
+ free(session);
+ }
}
}
}
}
}
}