Code Review
/
apps
/
agl-service-can-low-level.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
format: remove uneeded brackets.
[apps/agl-service-can-low-level.git]
/
low-can-binding
/
can
/
message-definition.cpp
diff --git
a/low-can-binding/can/message-definition.cpp
b/low-can-binding/can/message-definition.cpp
index
114307e
..
8184e98
100644
(file)
--- a/
low-can-binding/can/message-definition.cpp
+++ b/
low-can-binding/can/message-definition.cpp
@@
-68,24
+68,23
@@
const std::string message_definition_t::get_name() const{
uint32_t message_definition_t::get_id() const
{
uint32_t message_definition_t::get_id() const
{
- return id_ & CAN_EFF_MASK ?
- id_ | CAN_EFF_FLAG :
- id_;
+ return is_j1939() || ((id_ & CAN_SFF_MASK) == id_) ?
+ id_ : id_ | CAN_EFF_FLAG ;
}
bool message_definition_t::is_fd() const
{
}
bool message_definition_t::is_fd() const
{
- return (flags_
&
FD_FRAME);
+ return (flags_
& CAN_PROTOCOL_WITH_
FD_FRAME);
}
bool message_definition_t::is_j1939() const
{
}
bool message_definition_t::is_j1939() const
{
- return (flags_
&
J1939_PROTOCOL);
+ return (flags_
&
J1939_PROTOCOL);
}
bool message_definition_t::is_isotp() const
{
}
bool message_definition_t::is_isotp() const
{
- return (flags_
&
ISOTP_PROTOCOL);
+ return (flags_
&
ISOTP_PROTOCOL);
}
vect_ptr_signal_t& message_definition_t::get_signals()
}
vect_ptr_signal_t& message_definition_t::get_signals()
@@
-112,3
+111,7
@@
uint32_t message_definition_t::get_flags() const
{
return flags_;
}
{
return flags_;
}
+
+bool message_definition_t::frame_layout_is_bigendian() const{
+ return (flags_ & FRAME_LAYOUT_IS_BIGENDIAN);
+}