Code Review
/
src
/
app-framework-binder.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
afb-xreq: Remove field 'listener'
[src/app-framework-binder.git]
/
include
/
afb
/
afb-req-x2.h
diff --git
a/include/afb/afb-req-x2.h
b/include/afb/afb-req-x2.h
index
bd4bc76
..
21bbc09
100644
(file)
--- a/
include/afb/afb-req-x2.h
+++ b/
include/afb/afb-req-x2.h
@@
-1,5
+1,5
@@
/*
/*
- * Copyright (C) 2016
, 2017, 2018
"IoT.bzh"
+ * Copyright (C) 2016
-2019
"IoT.bzh"
* Author: José Bollo <jose.bollo@iot.bzh>
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Author: José Bollo <jose.bollo@iot.bzh>
*
* Licensed under the Apache License, Version 2.0 (the "License");
@@
-458,6
+458,8
@@
int afb_req_x2_session_set_LOA(
* Establishes for the client link identified by 'req' a subscription
* to the 'event'.
*
* Establishes for the client link identified by 'req' a subscription
* to the 'event'.
*
+ * Establishing subscription MUST be called BEFORE replying to the request.
+ *
* @param req the request
* @param event the event to subscribe
*
* @param req the request
* @param event the event to subscribe
*
@@
-476,6
+478,8
@@
int afb_req_x2_subscribe(
* link identified by 'req'.
* Returns 0 in case of successful subscription or -1 in case of error.
*
* link identified by 'req'.
* Returns 0 in case of successful subscription or -1 in case of error.
*
+ * Revoking subscription MUST be called BEFORE replying to the request.
+ *
* @param req the request
* @param event the event to revoke
*
* @param req the request
* @param event the event to revoke
*
@@
-642,7
+646,7
@@
void afb_req_x2_verbose(
{
va_list args;
va_start(args, fmt);
{
va_list args;
va_start(args, fmt);
- afb_req_x2_verbose(req, level, file, line, func, fmt, args);
+ afb_req_x2_v
v
erbose(req, level, file, line, func, fmt, args);
va_end(args);
}
va_end(args);
}
@@
-739,6
+743,9
@@
struct json_object *afb_req_x2_get_client_info(
* 4. 'info' a string handling some info (can be NULL)
* 5. 'req' the req
*
* 4. 'info' a string handling some info (can be NULL)
* 5. 'req' the req
*
+ * NOTE: For convenience, *json_object_put* is called on 'object' after the
+ * callback returns. So, it is wrong to call *json_object_put* in the callback.
+ *
* @param req The request
* @param api The api name of the method to call
* @param verb The verb name of the method to call
* @param req The request
* @param api The api name of the method to call
* @param verb The verb name of the method to call