Code Review
/
apps
/
agl-service-can-low-level.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Static code review fixes.
[apps/agl-service-can-low-level.git]
/
CAN-binder
/
low-can-binding
/
can
/
can-message-set.cpp
diff --git
a/CAN-binder/low-can-binding/can/can-message-set.cpp
b/CAN-binder/low-can-binding/can/can-message-set.cpp
index
1877f3a
..
a41f008
100644
(file)
--- a/
CAN-binder/low-can-binding/can/can-message-set.cpp
+++ b/
CAN-binder/low-can-binding/can/can-message-set.cpp
@@
-18,46
+18,41
@@
#include "can-message-set.hpp"
#include "can-message-set.hpp"
+#include "../can/can-message-definition.hpp"
+
can_message_set_t::can_message_set_t(
uint8_t index,
const std::string& name,
can_message_set_t::can_message_set_t(
uint8_t index,
const std::string& name,
- uint8_t can_bus_count,
- unsigned short can_message_count,
- unsigned short can_signal_count,
- unsigned short can_command_count,
- unsigned short obd2_signal_count,
- std::vector<std::shared_ptr<can_message_definition_t> > can_messages_definition)
+ const std::vector<std::shared_ptr<can_message_definition_t> >& can_messages_definition,
+ const std::vector<std::shared_ptr<diagnostic_message_t> >& diagnostic_messages)
: index_{index}
, name_{name}
: index_{index}
, name_{name}
- , can_bus_count_{can_bus_count}
- , can_message_count_{can_message_count}
- , can_signal_count_{can_signal_count}
- , can_command_count_{can_command_count}
- , obd2_signal_count_{obd2_signal_count}
, can_messages_definition_{can_messages_definition}
, can_messages_definition_{can_messages_definition}
-{
- for(auto& cmd : can_messages_definition_)
- {
- cmd->set_parent(std::make_shared<can_message_set_t>(this));
- }
-}
+ , diagnostic_messages_{diagnostic_messages}
+{}
/// @brief Return vector holding all message definition handled by this message set.
/// @brief Return vector holding all message definition handled by this message set.
-std::vector<std::shared_ptr<can_message_definition_t> > can_message_set_t::get_can_message_definition()
+std::vector<std::shared_ptr<can_message_definition_t> >
&
can_message_set_t::get_can_message_definition()
{
return can_messages_definition_;
}
{
return can_messages_definition_;
}
-std::vector<std::shared_ptr<can_signal_t> > can_message_set_t::get_can_signals() const
+std::vector<std::shared_ptr<can_signal_t> > can_message_set_t::get_
all_
can_signals() const
{
{
- std::vector<std::shared_ptr<can_signal_t> > can_signals
(can_signal_count_)
;
+ std::vector<std::shared_ptr<can_signal_t> > can_signals;
for(const auto& cmd: can_messages_definition_)
{
for(const auto& cmd: can_messages_definition_)
{
+ std::vector<std::shared_ptr<can_signal_t> >& cmd_signals = cmd->get_can_signals();
can_signals.insert( can_signals.end(),
can_signals.insert( can_signals.end(),
-
cmd->get_can_signals()
.begin(),
-
cmd->get_can_signals()
.end()
+
cmd_signals
.begin(),
+
cmd_signals
.end()
);
}
return can_signals;
);
}
return can_signals;
+}
+
+std::vector<std::shared_ptr<diagnostic_message_t> >& can_message_set_t::get_diagnostic_messages()
+{
+ return diagnostic_messages_;
}
\ No newline at end of file
}
\ No newline at end of file