From a8243956b0fd410bf16143b3e781144ad8964244 Mon Sep 17 00:00:00 2001 From: Max Ihlenfeldt Date: Tue, 13 Jun 2023 14:36:23 +0000 Subject: [PATCH 17/33] [meta-browser] Don't pass disable-auto-upgrade-debug-info to linker The version of aarch64-oe-linux-ld.lld we use on dunfell, kirkstone, and mickledore doesn't support this flag. Thus, we mustn't pass it if we want to avoid an "Unknown command line argument" linker error that stops the build. Upstream-Status: Inappropriate Signed-off-by: Max Ihlenfeldt --- build/config/compiler/BUILD.gn | 8 -------- 1 file changed, 8 deletions(-) diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index 5762f0b4e6b0a..c73b7ca6325d8 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -767,14 +767,6 @@ config("compiler") { } ldflags += [ "-Wl,-mllvm,-import-instr-limit=$import_instr_limit" ] - - if (!is_chromeos) { - # TODO(https://crbug.com/972449): turn on for ChromeOS when that - # toolchain has this flag. - # We only use one version of LLVM within a build so there's no need to - # upgrade debug info, which can be expensive since it runs the verifier. - ldflags += [ "-Wl,-mllvm,-disable-auto-upgrade-debug-info" ] - } } # TODO(https://crbug.com/1211155): investigate why this isn't effective on -- 2.42.1