gerrit.automotivelinux Code Review - AGL/meta-agl-devel.git/blob

   1 Update PipeWire gstreamer plugins
   2
   3 Update PipeWire sink and source to handle drop of pwaudiosink and
   4 pwaudiosrc in favor of pipewire* replacements.  However, testing
   5 has found that Alexa does not work with pipewiresrc (input hangs
   6 after first interaction), so for now use "alsasrc device=pipewire"
   7 as a workaround as recommended by upstream.
   8
   9 Given that Amazon has dropped AGL support, this patch will need to
  10 be carried locally.
  11
  12 Upstream-Status: Inappropriate [no upstream]
  13 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
  14 ---
  15  lib/aal/src/gstreamer/player.c   | 2 +-
  16  lib/aal/src/gstreamer/recorder.c | 2 +-
  17  2 files changed, 2 insertions(+), 2 deletions(-)
  18
  19 diff --git a/lib/aal/src/gstreamer/player.c b/lib/aal/src/gstreamer/player.c
  20 index 5dd6627..5ff9402 100644
  21 --- a/lib/aal/src/gstreamer/player.c
  22 +++ b/lib/aal/src/gstreamer/player.c
  23 @@ -142,7 +142,7 @@ static aal_handle_t gstreamer_player_create(const aal_attributes_t* attr, aal_au
  24      } else {
  25  #ifdef USE_PIPEWIRE
  26          g_info("Using Pipewire device: %s\n", attr->device);
  27 -        sink = gstreamer_create_and_add_element(bin, "pwaudiosink", "sink");
  28 +        sink = gstreamer_create_and_add_element(bin, "pipewiresink", "sink");
  29          if (sink) {
  30              GstStructure* s = gst_structure_new("properties", "media.role", G_TYPE_STRING, attr->device, NULL);
  31              g_object_set(G_OBJECT(sink), "stream-properties", s, NULL);
  32 diff --git a/lib/aal/src/gstreamer/recorder.c b/lib/aal/src/gstreamer/recorder.c
  33 index ff6d464..a13b000 100644
  34 --- a/lib/aal/src/gstreamer/recorder.c
  35 +++ b/lib/aal/src/gstreamer/recorder.c
  36 @@ -69,7 +69,7 @@ static aal_handle_t gstreamer_recorder_create(const aal_attributes_t* attr, aal_
  37          strncpy(src_desc, "autoaudiosrc", sizeof(src_desc) - 1);
  38      } else {
  39  #ifdef USE_PIPEWIRE
  40 -        snprintf(src_desc, sizeof(src_desc), "pwaudiosrc stream-properties=\"properties,media.role=%s\"", attr->device);
  41 +        snprintf(src_desc, sizeof(src_desc), "alsasrc device=pipewire");
  42  #else
  43          g_info("Using ALSA device: %s\n", attr->device);
  44          snprintf(src_desc, sizeof(src_desc), "alsasrc device=%s", attr->device);