2 * Copyright © 2019 Collabora, Ltd.
4 * Permission is hereby granted, free of charge, to any person obtaining
5 * a copy of this software and associated documentation files (the
6 * "Software"), to deal in the Software without restriction, including
7 * without limitation the rights to use, copy, modify, merge, publish,
8 * distribute, sublicense, and/or sell copies of the Software, and to
9 * permit persons to whom the Software is furnished to do so, subject to
10 * the following conditions:
12 * The above copyright notice and this permission notice (including the
13 * next paragraph) shall be included in all copies or substantial
14 * portions of the Software.
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
17 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
18 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
19 * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
20 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
21 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
22 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
26 #include "ivi-compositor.h"
28 #include "shared/helpers.h"
33 #include <libweston/libweston.h>
34 #include <libweston-desktop/libweston-desktop.h>
36 #include "agl-shell-desktop-server-protocol.h"
38 #define AGL_COMP_DEBUG
40 static const char *ivi_roles_as_string[] = {
41 [IVI_SURFACE_ROLE_NONE] = "NONE",
42 [IVI_SURFACE_ROLE_BACKGROUND] = "BACKGROUND",
43 [IVI_SURFACE_ROLE_PANEL] = "PANEL",
44 [IVI_SURFACE_ROLE_DESKTOP] = "DESKTOP",
45 [IVI_SURFACE_ROLE_POPUP] = "POPUP",
46 [IVI_SURFACE_ROLE_SPLIT_H] = "SPLIT_H",
47 [IVI_SURFACE_ROLE_SPLIT_V] = "SPLIT_V",
48 [IVI_SURFACE_ROLE_FULLSCREEN] = "FULLSCREEN",
49 [IVI_SURFACE_ROLE_REMOTE] = "REMOTE",
53 ivi_layout_get_surface_role_name(struct ivi_surface *surf)
55 if (surf->role < 0 || surf->role >= ARRAY_LENGTH(ivi_roles_as_string))
56 return " unknown surface role";
58 return ivi_roles_as_string[surf->role];
62 ivi_background_init(struct ivi_compositor *ivi, struct ivi_output *output)
64 struct weston_output *woutput = output->output;
65 struct ivi_surface *bg = output->background;
66 struct weston_view *view;
69 weston_log("WARNING: Output does not have a background\n");
73 assert(bg->role == IVI_SURFACE_ROLE_BACKGROUND);
77 weston_view_set_output(view, woutput);
78 weston_view_set_position(view, woutput->x, woutput->y);
80 weston_log("(background) position view %p, x %d, y %d, on output %s\n", view,
81 woutput->x, woutput->y, output->name);
83 view->is_mapped = true;
84 view->surface->is_mapped = true;
86 weston_layer_entry_insert(&ivi->background.view_list, &view->layer_link);
90 ivi_panel_init(struct ivi_compositor *ivi, struct ivi_output *output,
91 struct ivi_surface *panel)
93 struct weston_output *woutput = output->output;
94 struct weston_desktop_surface *dsurface;
95 struct weston_view *view;
96 struct weston_geometry geom;
103 assert(panel->role == IVI_SURFACE_ROLE_PANEL);
104 dsurface = panel->dsurface;
106 geom = weston_desktop_surface_get_geometry(dsurface);
108 weston_log("(panel) geom.width %d, geom.height %d, geom.x %d, geom.y %d\n",
109 geom.width, geom.height, geom.x, geom.y);
111 switch (panel->panel.edge) {
112 case AGL_SHELL_EDGE_TOP:
113 output->area.y += geom.height;
114 output->area.height -= geom.height;
116 case AGL_SHELL_EDGE_BOTTOM:
117 y += woutput->height - geom.height;
118 output->area.height -= geom.height;
120 case AGL_SHELL_EDGE_LEFT:
121 output->area.x += geom.width;
122 output->area.width -= geom.width;
124 case AGL_SHELL_EDGE_RIGHT:
125 x += woutput->width - geom.width;
126 output->area.width -= geom.width;
133 weston_view_set_output(view, woutput);
134 weston_view_set_position(view, x, y);
136 weston_log("(panel) edge %d position view %p, x %d, y %d\n",
137 panel->panel.edge, view, x, y);
139 view->is_mapped = true;
140 view->surface->is_mapped = true;
142 weston_log("panel type %d inited on output %s\n", panel->panel.edge,
145 weston_layer_entry_insert(&ivi->panel.view_list, &view->layer_link);
149 * Initializes all static parts of the layout, i.e. the background and panels.
152 ivi_layout_init(struct ivi_compositor *ivi, struct ivi_output *output)
154 ivi_background_init(ivi, output);
158 output->area.width = output->output->width;
159 output->area.height = output->output->height;
161 ivi_panel_init(ivi, output, output->top);
162 ivi_panel_init(ivi, output, output->bottom);
163 ivi_panel_init(ivi, output, output->left);
164 ivi_panel_init(ivi, output, output->right);
166 weston_compositor_schedule_repaint(ivi->compositor);
168 weston_log("Usable area: %dx%d+%d,%d\n",
169 output->area.width, output->area.height,
170 output->area.x, output->area.y);
174 ivi_find_app(struct ivi_compositor *ivi, const char *app_id)
176 struct ivi_surface *surf;
179 wl_list_for_each(surf, &ivi->surfaces, link) {
180 id = weston_desktop_surface_get_app_id(surf->dsurface);
181 if (id && strcmp(app_id, id) == 0)
189 ivi_layout_activate_complete(struct ivi_output *output,
190 struct ivi_surface *surf)
192 struct ivi_compositor *ivi = output->ivi;
193 struct weston_output *woutput = output->output;
194 struct weston_view *view = surf->view;
196 if (weston_view_is_mapped(view)) {
197 weston_layer_entry_remove(&view->layer_link);
200 weston_view_set_output(view, woutput);
201 weston_view_set_position(view,
202 woutput->x + output->area.x,
203 woutput->y + output->area.y);
205 view->is_mapped = true;
206 view->surface->is_mapped = true;
208 if (output->active) {
209 output->active->view->is_mapped = false;
210 output->active->view->surface->is_mapped = false;
212 weston_layer_entry_remove(&output->active->view->layer_link);
214 output->previous_active = output->active;
215 output->active = surf;
217 weston_layer_entry_insert(&ivi->normal.view_list, &view->layer_link);
218 weston_view_update_transform(view);
220 weston_view_damage_below(view);
223 * the 'remote' role now makes use of this part so make sure we don't
224 * trip the enum such that we might end up with a modified output for
227 if (surf->role == IVI_SURFACE_ROLE_DESKTOP) {
228 if (surf->desktop.pending_output)
229 surf->desktop.last_output = surf->desktop.pending_output;
230 surf->desktop.pending_output = NULL;
233 weston_log("Activation completed for app_id %s, role %s, output %s\n",
234 weston_desktop_surface_get_app_id(surf->dsurface),
235 ivi_layout_get_surface_role_name(surf), output->name);
239 ivi_layout_find_with_app_id(const char *app_id, struct ivi_compositor *ivi)
241 struct ivi_output *out;
246 wl_list_for_each(out, &ivi->outputs, link) {
250 if (!strcmp(app_id, out->app_id))
258 static struct ivi_output *
259 ivi_layout_find_bg_output(struct ivi_compositor *ivi)
261 struct ivi_output *out;
263 wl_list_for_each(out, &ivi->outputs, link) {
264 if (out->background &&
265 out->background->role == IVI_SURFACE_ROLE_BACKGROUND)
273 ivi_layout_desktop_committed(struct ivi_surface *surf)
275 struct weston_desktop_surface *dsurf = surf->dsurface;
276 struct weston_geometry geom = weston_desktop_surface_get_geometry(dsurf);
277 struct ivi_policy *policy = surf->ivi->policy;
278 struct ivi_output *output;
279 const char *app_id = weston_desktop_surface_get_app_id(dsurf);
281 assert(surf->role == IVI_SURFACE_ROLE_DESKTOP ||
282 surf->role == IVI_SURFACE_ROLE_REMOTE);
285 * we can't make use here of the ivi_layout_get_output_from_surface()
286 * due to the fact that we'll always land here when a surface performs
287 * a commit and pending_output will not bet set. This works in tandem
288 * with 'activated_by_default' at this point to avoid tripping over
289 * to a surface that continuously updates its content
291 if (surf->role == IVI_SURFACE_ROLE_DESKTOP)
292 output = surf->desktop.pending_output;
294 output = surf->remote.output;
296 if (surf->role == IVI_SURFACE_ROLE_DESKTOP && !output) {
297 struct ivi_output *r_output;
299 if (policy && policy->api.surface_activate_by_default &&
300 !policy->api.surface_activate_by_default(surf, surf->ivi))
303 /* we can only activate it again by using the protocol */
304 if (surf->activated_by_default)
307 /* check first if there aren't any outputs being set */
308 r_output = ivi_layout_find_with_app_id(app_id, surf->ivi);
311 struct weston_view *view = r_output->fullscreen_view.fs->view;
312 if (view->is_mapped || view->surface->is_mapped)
313 remove_black_surface(r_output);
317 /* try finding an output with a background and use that */
319 r_output = ivi_layout_find_bg_output(surf->ivi);
321 /* if we couldn't still find an output by this point, there's
322 * something wrong so we abort with a protocol error */
324 wl_resource_post_error(surf->ivi->shell_client.resource,
325 AGL_SHELL_ERROR_INVALID_ARGUMENT,
326 "No valid output found to activate surface by default");
330 if (!surf->ivi->activate_by_default) {
331 weston_log("Refusing to activate surface role %d, app_id %s\n",
336 /* use the output of the bg to activate the app on start-up by
338 if (surf->view && r_output) {
339 if (app_id && r_output) {
340 weston_log("Surface with app_id %s, role %s activating by default\n",
341 weston_desktop_surface_get_app_id(surf->dsurface),
342 ivi_layout_get_surface_role_name(surf));
343 ivi_layout_activate(r_output, app_id);
344 surf->activated_by_default = true;
345 } else if (!app_id) {
347 * applications not setting an app_id, or
348 * setting an app_id but at a later point in
349 * time, might fall-back here so give them a
350 * chance to receive the configure event and
353 weston_log("Surface no app_id, role %s activating by default\n",
354 ivi_layout_get_surface_role_name(surf));
355 ivi_layout_activate_by_surf(r_output, surf);
356 surf->activated_by_default = true;
363 if (surf->role == IVI_SURFACE_ROLE_REMOTE && output) {
364 if (policy && policy->api.surface_activate_by_default &&
365 !policy->api.surface_activate_by_default(surf, surf->ivi))
368 /* we can only activate it again by using the protocol, but
369 * additionally the output is not reset when
370 * ivi_layout_activate_complete() terminates so we use the
371 * current active surface to avoid hitting this again and again
373 if (surf->activated_by_default && output->active == surf)
377 weston_log("Surface with app_id %s, role %s activating by default\n",
378 weston_desktop_surface_get_app_id(surf->dsurface),
379 ivi_layout_get_surface_role_name(surf));
380 ivi_layout_activate(output, app_id);
381 surf->activated_by_default = true;
386 if (!weston_desktop_surface_get_maximized(dsurf) ||
387 geom.width != output->area.width ||
388 geom.height != output->area.height)
391 ivi_layout_activate_complete(output, surf);
395 ivi_layout_fullscreen_committed(struct ivi_surface *surface)
397 struct ivi_compositor *ivi = surface->ivi;
398 struct ivi_policy *policy = ivi->policy;
400 struct weston_desktop_surface *dsurface = surface->dsurface;
401 struct weston_surface *wsurface =
402 weston_desktop_surface_get_surface(dsurface);
403 const char *app_id = weston_desktop_surface_get_app_id(dsurface);
405 struct ivi_output *output = surface->split.output;
406 struct weston_output *woutput = output->output;
408 struct weston_view *view = surface->view;
409 struct weston_geometry geom;
411 if (policy && policy->api.surface_activate_by_default &&
412 !policy->api.surface_activate_by_default(surface, surface->ivi) &&
413 !surface->activated_by_default)
416 if (surface->view->is_mapped)
419 geom = weston_desktop_surface_get_geometry(dsurface);
420 weston_log("(fs) geom x %d, y %d, width %d, height %d\n", geom.x, geom.y,
421 geom.width, geom.height);
423 assert(surface->role == IVI_SURFACE_ROLE_FULLSCREEN);
425 weston_desktop_surface_set_fullscreen(dsurface, true);
427 weston_view_set_output(view, woutput);
428 weston_view_set_position(view, woutput->x, woutput->y);
429 weston_layer_entry_insert(&ivi->fullscreen.view_list, &view->layer_link);
431 weston_view_update_transform(view);
432 weston_view_damage_below(view);
434 wsurface->is_mapped = true;
435 surface->view->is_mapped = true;
437 shell_advertise_app_state(ivi, app_id,
438 NULL, AGL_SHELL_DESKTOP_APP_STATE_ACTIVATED);
440 weston_log("Activation completed for app_id %s, role %s, output %s\n",
441 app_id, ivi_layout_get_surface_role_name(surface), output->name);
445 ivi_layout_desktop_resize(struct ivi_surface *surface,
446 struct weston_geometry area)
448 struct weston_desktop_surface *dsurf = surface->dsurface;
449 struct weston_view *view = surface->view;
453 int width = area.width;
454 int height = area.height;
456 weston_desktop_surface_set_size(dsurf,
459 weston_view_set_position(view, x, y);
460 weston_view_update_transform(view);
461 weston_view_damage_below(view);
465 ivi_layout_split_committed(struct ivi_surface *surface)
467 struct ivi_compositor *ivi = surface->ivi;
468 struct ivi_policy *policy = ivi->policy;
470 struct weston_desktop_surface *dsurface = surface->dsurface;
471 struct weston_surface *wsurface =
472 weston_desktop_surface_get_surface(dsurface);
473 const char *app_id = weston_desktop_surface_get_app_id(dsurface);
475 struct ivi_output *output = surface->split.output;
476 struct weston_output *woutput = output->output;
478 struct weston_view *view = surface->view;
479 struct weston_geometry geom;
487 if (policy && policy->api.surface_activate_by_default &&
488 !policy->api.surface_activate_by_default(surface, surface->ivi) &&
489 !surface->activated_by_default)
492 if (surface->view->is_mapped)
495 geom = weston_desktop_surface_get_geometry(dsurface);
497 assert(surface->role == IVI_SURFACE_ROLE_SPLIT_H ||
498 surface->role == IVI_SURFACE_ROLE_SPLIT_V);
500 /* save the previous area in order to recover it back when if this kind
501 * of surface is being destroyed/removed */
502 output->area_saved = output->area;
504 switch (surface->role) {
505 case IVI_SURFACE_ROLE_SPLIT_V:
506 geom.width = (output->area.width / 2);
508 x += woutput->width - geom.width;
509 output->area.width -= geom.width;
511 width = woutput->width - x;
512 height = output->area.height;
516 case IVI_SURFACE_ROLE_SPLIT_H:
517 geom.height = (output->area.height / 2);
520 output->area.y += geom.height;
521 output->area.height -= geom.height;
523 width = output->area.width;
524 height = output->area.height;
530 assert(!"Invalid split orientation\n");
533 weston_desktop_surface_set_size(dsurface,
536 /* resize the active surface first, output->area already contains
537 * correct area to resize to */
539 ivi_layout_desktop_resize(output->active, output->area);
541 weston_view_set_output(view, woutput);
542 weston_view_set_position(view, x, y);
543 weston_layer_entry_insert(&ivi->normal.view_list, &view->layer_link);
545 weston_view_update_transform(view);
546 weston_view_damage_below(view);
548 wsurface->is_mapped = true;
549 surface->view->is_mapped = true;
551 shell_advertise_app_state(ivi, app_id,
552 NULL, AGL_SHELL_DESKTOP_APP_STATE_ACTIVATED);
554 weston_log("Activation completed for app_id %s, role %s, output %s\n",
555 app_id, ivi_layout_get_surface_role_name(surface), output->name);
559 ivi_layout_popup_committed(struct ivi_surface *surface)
561 struct ivi_compositor *ivi = surface->ivi;
562 struct ivi_policy *policy = ivi->policy;
564 struct weston_desktop_surface *dsurface = surface->dsurface;
565 struct weston_surface *wsurface =
566 weston_desktop_surface_get_surface(dsurface);
567 const char *app_id = weston_desktop_surface_get_app_id(dsurface);
569 struct ivi_output *output = surface->popup.output;
570 struct weston_output *woutput = output->output;
572 struct weston_view *view = surface->view;
574 if (policy && policy->api.surface_activate_by_default &&
575 !policy->api.surface_activate_by_default(surface, surface->ivi) &&
576 !surface->activated_by_default)
579 if (surface->view->is_mapped)
582 assert(surface->role == IVI_SURFACE_ROLE_POPUP);
584 weston_view_set_output(view, woutput);
585 weston_view_set_position(view, surface->popup.x, surface->popup.y);
587 /* only clip the pop-up dialog window if we have a valid
588 * width and height being passed on. Users might not want to have one
589 * set-up so only enfore it is really passed on. */
590 if (surface->popup.bb.width > 0 && surface->popup.bb.height > 0)
591 weston_view_set_mask(view, surface->popup.bb.x, surface->popup.bb.y,
592 surface->popup.bb.width, surface->popup.bb.height);
594 weston_layer_entry_insert(&ivi->popup.view_list, &view->layer_link);
596 weston_view_update_transform(view);
597 weston_view_damage_below(view);
599 wsurface->is_mapped = true;
600 surface->view->is_mapped = true;
602 shell_advertise_app_state(ivi, app_id,
603 NULL, AGL_SHELL_DESKTOP_APP_STATE_ACTIVATED);
605 weston_log("Activation completed for app_id %s, role %s, output %s\n",
606 app_id, ivi_layout_get_surface_role_name(surface), output->name);
610 ivi_layout_popup_re_add(struct ivi_surface *surface)
612 assert(surface->role == IVI_SURFACE_ROLE_POPUP);
613 struct weston_view *view = surface->view;
615 if (weston_view_is_mapped(view)) {
616 struct weston_desktop_surface *dsurface = surface->dsurface;
617 struct weston_surface *wsurface =
618 weston_desktop_surface_get_surface(dsurface);
620 weston_layer_entry_remove(&view->layer_link);
622 wsurface->is_mapped = false;
623 view->is_mapped = false;
626 /* reset the activate by default in order to (still) allow the surface
627 * to be activaved using the request */
628 if (!surface->activated_by_default)
629 surface->activated_by_default = true;
631 ivi_layout_popup_committed(surface);
635 ivi_layout_surface_is_split_or_fullscreen(struct ivi_surface *surf)
637 struct ivi_compositor *ivi = surf->ivi;
638 struct ivi_surface *is;
640 if (surf->role != IVI_SURFACE_ROLE_SPLIT_H &&
641 surf->role != IVI_SURFACE_ROLE_SPLIT_V &&
642 surf->role != IVI_SURFACE_ROLE_FULLSCREEN)
645 /* reset the activate by default in order to (still) allow the surface
646 * to be activaved using the request */
647 if (!surf->activated_by_default)
648 surf->activated_by_default = true;
650 wl_list_for_each(is, &ivi->surfaces, link)
658 ivi_layout_activate_by_surf(struct ivi_output *output, struct ivi_surface *surf)
660 struct ivi_compositor *ivi = output->ivi;
661 struct weston_desktop_surface *dsurf;
662 struct weston_view *view;
663 struct weston_geometry geom;
664 struct ivi_policy *policy = output->ivi->policy;
666 dsurf = surf->dsurface;
669 const char *app_id = weston_desktop_surface_get_app_id(dsurf);
674 if (policy && policy->api.surface_activate &&
675 !policy->api.surface_activate(surf, surf->ivi)) {
679 #ifdef AGL_COMP_DEBUG
680 weston_log("Activating app_id %s, type %s\n", app_id,
681 ivi_layout_get_surface_role_name(surf));
684 if (surf->role == IVI_SURFACE_ROLE_POPUP) {
685 ivi_layout_popup_re_add(surf);
689 /* do not 're'-activate surfaces that are split or active */
690 if (surf == output->active ||
691 ivi_layout_surface_is_split_or_fullscreen(surf))
694 if (surf->role == IVI_SURFACE_ROLE_REMOTE) {
695 struct ivi_output *remote_output =
696 ivi_layout_find_with_app_id(app_id, ivi);
698 /* if already active on a remote output do not
699 * attempt to activate it again */
700 if (remote_output && remote_output->active == surf)
705 geom = weston_desktop_surface_get_geometry(dsurf);
707 if (surf->role == IVI_SURFACE_ROLE_DESKTOP)
708 surf->desktop.pending_output = output;
709 if (weston_desktop_surface_get_maximized(dsurf) &&
710 geom.width == output->area.width &&
711 geom.height == output->area.height) {
712 ivi_layout_activate_complete(output, surf);
716 weston_desktop_surface_set_maximized(dsurf, true);
717 weston_desktop_surface_set_size(dsurf,
719 output->area.height);
721 weston_log("Setting app_id %s, role %s, set to maximized (%dx%d)\n",
722 app_id, ivi_layout_get_surface_role_name(surf),
723 output->area.width, output->area.height);
725 * If the view isn't mapped, we put it onto the hidden layer so it will
726 * start receiving frame events, and will be able to act on our
729 if (!weston_view_is_mapped(view)) {
730 view->is_mapped = true;
731 view->surface->is_mapped = true;
733 weston_view_set_output(view, output->output);
734 weston_layer_entry_insert(&ivi->hidden.view_list, &view->layer_link);
735 /* force repaint of the entire output */
737 weston_log("Placed app_id %s, type %s in hidden layer\n",
738 app_id, ivi_layout_get_surface_role_name(surf));
743 ivi_layout_activate(struct ivi_output *output, const char *app_id)
745 struct ivi_surface *surf;
746 struct ivi_compositor *ivi = output->ivi;
751 surf = ivi_find_app(ivi, app_id);
755 ivi_layout_activate_by_surf(output, surf);
759 ivi_layout_get_output_from_surface(struct ivi_surface *surf)
761 struct ivi_output *ivi_output = NULL;
763 switch (surf->role) {
764 case IVI_SURFACE_ROLE_DESKTOP:
765 if (surf->desktop.pending_output)
766 ivi_output = surf->desktop.pending_output;
768 ivi_output = surf->desktop.last_output;
770 case IVI_SURFACE_ROLE_POPUP:
771 ivi_output = surf->popup.output;
773 case IVI_SURFACE_ROLE_BACKGROUND:
774 ivi_output = surf->bg.output;
776 case IVI_SURFACE_ROLE_PANEL:
777 ivi_output = surf->panel.output;
779 case IVI_SURFACE_ROLE_FULLSCREEN:
780 ivi_output = surf->fullscreen.output;
782 case IVI_SURFACE_ROLE_SPLIT_H:
783 case IVI_SURFACE_ROLE_SPLIT_V:
784 ivi_output = surf->split.output;
786 case IVI_SURFACE_ROLE_REMOTE:
787 ivi_output = surf->remote.output;
789 case IVI_SURFACE_ROLE_NONE:
798 ivi_layout_deactivate(struct ivi_compositor *ivi, const char *app_id)
800 struct ivi_surface *surf;
801 struct ivi_output *ivi_output;
802 struct ivi_policy *policy = ivi->policy;
807 surf = ivi_find_app(ivi, app_id);
811 if (policy && policy->api.surface_deactivate &&
812 !policy->api.surface_deactivate(surf, surf->ivi)) {
816 ivi_output = ivi_layout_get_output_from_surface(surf);
817 weston_log("Deactiving %s, role %s\n", app_id,
818 ivi_layout_get_surface_role_name(surf));
820 if (surf->role == IVI_SURFACE_ROLE_DESKTOP) {
821 struct ivi_surface *previous_active;
823 previous_active = ivi_output->previous_active;
824 if (!previous_active) {
825 /* we don't have a previous active it means we should
827 if (ivi_output->active) {
828 struct weston_view *view;
830 view = ivi_output->active->view;
831 view->is_mapped = false;
832 view->surface->is_mapped = false;
834 weston_layer_entry_remove(&view->layer_link);
835 weston_view_damage_below(view);
836 ivi_output->active = NULL;
839 struct weston_desktop_surface *dsurface;
840 const char *previous_active_app_id;
842 dsurface = previous_active->dsurface;
843 previous_active_app_id =
844 weston_desktop_surface_get_app_id(dsurface);
845 ivi_layout_activate(ivi_output, previous_active_app_id);
847 } else if (surf->role == IVI_SURFACE_ROLE_POPUP) {
848 struct weston_view *view = surf->view;
850 weston_layer_entry_remove(&view->layer_link);
851 weston_view_damage_below(view);