7ff86449ddd8cfb01c9b504dd3c32390d91f1218
[apps/agl-service-can-low-level.git] / src / diagnostic / diagnostic-manager.cpp
1 /*
2  * Copyright (C) 2015, 2016 "IoT.bzh"
3  * Author "Romain Forlot" <romain.forlot@iot.bzh>
4  *
5  * Licensed under the Apache License, Version 2.0 (the "License");
6  * you may not use this file except in compliance with the License.
7  * You may obtain a copy of the License at
8  *
9  *       http://www.apache.org/licenses/LICENSE-2.0
10  *
11  * Unless required by applicable law or agreed to in writing, software
12  * distributed under the License is distributed on an "AS IS" BASIS,
13  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14  * See the License for the specific language governing permissions and
15  * limitations under the License.
16  */
17
18 #include <systemd/sd-event.h>
19 #include <algorithm>
20
21 #include "diagnostic-manager.hpp"
22
23 #include "uds/uds.h"
24 #include "../utils/openxc-utils.hpp"
25 #include "../configuration.hpp"
26
27 #define MAX_RECURRING_DIAGNOSTIC_FREQUENCY_HZ 10
28 #define MAX_SIMULTANEOUS_DIAG_REQUESTS 50
29 #define TIMERFD_ACCURACY 0
30 #define MICRO 1000000
31
32 diagnostic_manager_t::diagnostic_manager_t()
33         : initialized_{false}
34 {}
35
36 /// @brief Diagnostic manager isn't initialized at launch but after
37 ///  CAN bus devices initialization. For the moment, it is only possible
38 ///  to have 1 diagnostic bus which are the first bus declared in the JSON
39 ///  description file. Configuration instance will return it.
40 ///
41 /// @desc this will initialize DiagnosticShims and cancel all active requests 
42 ///  if there are any.
43 bool diagnostic_manager_t::initialize()
44 {
45         // Mandatory to set the bus before intialize shims.
46         bus_ = configuration_t::instance().get_diagnostic_bus();
47
48         init_diagnostic_shims();
49         reset();
50
51         initialized_ = true;
52         DEBUG(binder_interface, "initialize: Diagnostic Manager initialized");
53         return initialized_;
54 }
55
56 /// @brief initialize shims used by UDS lib and set initialized_ to true.
57 ///  It is needed before used the diagnostic manager fully because shims are
58 ///  required by most member functions.
59 void diagnostic_manager_t::init_diagnostic_shims()
60 {
61         shims_ = diagnostic_init_shims(shims_logger, shims_send, NULL);
62         DEBUG(binder_interface, "init_diagnostic_shims: Shims initialized");
63 }
64
65 /// @brief Force cleanup all active requests.
66 void diagnostic_manager_t::reset()
67 {
68         DEBUG(binder_interface, "Clearing existing diagnostic requests");
69         cleanup_active_requests(true);
70 }
71
72 /// @brief send function use by diagnostic library. Only one bus used for now
73 ///  so diagnostic request is sent using the default diagnostic bus not matter of
74 ///  which is specified in the diagnostic message definition.
75 ///
76 /// @param[in] arbitration_id - CAN arbitration ID to use when send message. OBD2 broadcast ID
77 ///  is 0x7DF by example.
78 /// @param[in] data - The data payload for the message. NULL is valid if size is also 0.
79 /// @param[in] size - The size of the data payload, in bytes.
80 ///
81 /// @return true if the CAN message was sent successfully. 
82 bool diagnostic_manager_t::shims_send(const uint32_t arbitration_id, const uint8_t* data, const uint8_t size)
83 {
84         std::shared_ptr<can_bus_dev_t> can_bus_dev = can_bus_t::get_can_device(configuration_t::instance().get_diagnostic_manager().bus_);
85         return can_bus_dev->shims_send(arbitration_id, data, size);
86 }
87
88 /// @brief The type signature for an optional logging function, if the user
89 /// wishes to provide one. It should print, store or otherwise display the
90 /// message.
91 ///
92 /// message - A format string to log using the given parameters.
93 /// ... (vargs) - the parameters for the format string.
94 ///
95 void diagnostic_manager_t::shims_logger(const char* format, ...)
96 {
97         va_list args;
98         va_start(args, format);
99
100         char buffer[256];
101         vsnprintf(buffer, 256, format, args);
102
103         DEBUG(binder_interface, "shims_logger: %s", buffer);
104 }
105
106 /// @brief The type signature for a... OpenXC TODO: not used yet.
107 void diagnostic_manager_t::shims_timer()
108 {}
109
110 std::shared_ptr<can_bus_dev_t> diagnostic_manager_t::get_can_bus_dev()
111 {
112         return can_bus_t::get_can_device(bus_);
113 }
114
115 /// @brief Return diagnostic manager shims member.
116 DiagnosticShims& diagnostic_manager_t::get_shims()
117 {
118         return shims_;
119 }
120
121 /// @brief Search for a specific active diagnostic request in the provided requests list
122 /// and erase it from the vector. This is useful at unsubscription to clean up the list otherwize
123 /// all received CAN messages will be passed to DiagnosticRequestHandle of all active diagnostic request
124 /// contained in the vector but no event if connected to, so we will decode uneeded request.
125 ///
126 /// @param[in] entry - a pointer of an active_diagnostic_request instance to clean up
127 /// @param[in] requests_list - a vector where to make the search and cleaning.
128 void diagnostic_manager_t::find_and_erase(active_diagnostic_request_t* entry, std::vector<active_diagnostic_request_t*>& requests_list)
129 {
130         auto i = std::find(requests_list.begin(), requests_list.end(), entry);
131         if ( i != requests_list.end())
132                 requests_list.erase(i);
133 }
134
135 // @brief TODO: implement cancel_request if needed... Don't know.
136 void diagnostic_manager_t::cancel_request(active_diagnostic_request_t* entry)
137 {
138
139         /* TODO: implement acceptance filters.
140         if(entry.arbitration_id_ == OBD2_FUNCTIONAL_BROADCAST_ID) {
141                 for(uint32_t filter = OBD2_FUNCTIONAL_RESPONSE_START;
142                                 filter < OBD2_FUNCTIONAL_RESPONSE_START +
143                                         OBD2_FUNCTIONAL_RESPONSE_COUNT;
144                                 filter++) {
145                         removeAcceptanceFilter(entry.bus_, filter,
146                                         CanMessageFormat::STANDARD, getCanBuses(),
147                                         getCanBusCount());
148                 }
149         } else {
150                 removeAcceptanceFilter(entry.bus_,
151                                 entry.arbitration_id_ +
152                                         DIAGNOSTIC_RESPONSE_ARBITRATION_ID_OFFSET,
153                                 CanMessageFormat::STANDARD, getCanBuses(), getCanBusCount());
154         }*/
155 }
156
157 /// @brief Cleanup a specific request if it isn't running and get complete. As it is almost
158 /// impossible to get that state for a recurring request without waiting for that, you can 
159 /// force the cleaning operation.
160 ///
161 /// @param[in] entry - the request to clean
162 /// @param[in] force - Force the cleaning or not ?
163 void diagnostic_manager_t::cleanup_request(active_diagnostic_request_t* entry, bool force)
164 {
165         if(force || (entry->get_in_flight() && entry->request_completed()))
166         {
167                 entry->set_in_flight(false);
168
169                 char request_string[128] = {0};
170                 diagnostic_request_to_string(&entry->get_handle()->request,
171                         request_string, sizeof(request_string));
172                 if(entry->get_recurring())
173                 {
174                         find_and_erase(entry, recurring_requests_);
175                         if(force)
176                                 cancel_request(entry);
177                         DEBUG(binder_interface, "cleanup_request: Cancelling completed, recurring request: %s", request_string);
178                 }
179                 else
180                 {
181                         DEBUG(binder_interface, "cleanup_request: Cancelling completed, non-recurring request: %s", request_string);
182                         find_and_erase(entry, non_recurring_requests_);
183                         cancel_request(entry);
184                 }
185         }
186 }
187
188 /// @brief Clean up all requests lists, recurring and not recurring.
189 ///
190 /// @param[in] force - Force the cleaning or not ? If true, that will do
191 /// the same effect as a call to reset().
192 void diagnostic_manager_t::cleanup_active_requests(bool force)
193 {
194         for(auto& entry : non_recurring_requests_)
195                 if (entry != nullptr)
196                         cleanup_request(entry, force);
197
198         for(auto& entry : recurring_requests_)
199                 if (entry != nullptr)
200                         cleanup_request(entry, force);
201 }
202
203 /// @brief Will return the active_diagnostic_request_t pointer for theDiagnosticRequest or nullptr if
204 /// not found.
205 ///
206 /// @param[in] request - Search key, method will go through recurring list to see if it find that request
207 ///  holded by the DiagnosticHandle member.
208 active_diagnostic_request_t* diagnostic_manager_t::find_recurring_request(const DiagnosticRequest* request)
209 {
210         for (auto& entry : recurring_requests_)
211         {
212                 if(entry != nullptr)
213                 {
214                         if(diagnostic_request_equals(&entry->get_handle()->request, request))
215                         {
216                                 return entry;
217                                 break;
218                         }
219                 }
220         }
221         return nullptr;
222 }
223
224 /// @brief Add and send a new one-time diagnostic request.
225 ///
226 /// @desc A one-time (aka non-recurring) request can existing in parallel with a
227 /// recurring request for the same PID or mode, that's not a problem.
228 ///
229 /// For an example, see the docs for addRecurringRequest. This function is very
230 /// similar but leaves out the frequencyHz parameter.
231 ///
232 /// @param[in] request - The parameters for the request.
233 /// @param[in] name - Human readable name this response, to be used when
234 ///      publishing received responses. TODO: If the name is NULL, the published output
235 ///      will use the raw OBD-II response format.
236 /// @param[in] waitForMultipleResponses - If false, When any response is received
237 ///      for this request it will be removed from the active list. If true, the
238 ///      request will remain active until the timeout clock expires, to allow it
239 ///      to receive multiple response. Functional broadcast requests will always
240 ///      waint for the timeout, regardless of this parameter.
241 /// @param[in] decoder - An optional DiagnosticResponseDecoder to parse the payload of
242 ///      responses to this request. If the decoder is NULL, the output will
243 ///      include the raw payload instead of a parsed value.
244 /// @param[in] callback - An optional DiagnosticResponseCallback to be notified whenever a
245 ///      response is received for this request.
246 ///
247 /// @return true if the request was added successfully. Returns false if there
248 /// wasn't a free active request entry, if the frequency was too high or if the
249 /// CAN acceptance filters could not be configured,
250 bool diagnostic_manager_t::add_request(DiagnosticRequest* request, const std::string name,
251         bool wait_for_multiple_responses, const DiagnosticResponseDecoder decoder,
252         const DiagnosticResponseCallback callback)
253 {
254         cleanup_active_requests(false);
255
256         bool added = true;
257
258         if (non_recurring_requests_.size() <= MAX_SIMULTANEOUS_DIAG_REQUESTS)
259         {
260                 // TODO: implement Acceptance Filter
261                 //      if(updateRequiredAcceptanceFilters(bus, request)) {
262                         active_diagnostic_request_t* entry = new active_diagnostic_request_t(bus_, request, name,
263                                         wait_for_multiple_responses, decoder, callback, 0);
264                         entry->set_handle(shims_, request);
265
266                         char request_string[128] = {0};
267                         diagnostic_request_to_string(&entry->get_handle()->request, request_string,
268                                         sizeof(request_string));
269
270                         find_and_erase(entry, non_recurring_requests_);
271                         DEBUG(binder_interface, "Added one-time diagnostic request on bus %s: %s",
272                                         bus_, request_string);
273
274                         non_recurring_requests_.push_back(entry);
275         }
276         else
277         {
278                 WARNING(binder_interface, "There isn't enough request entry. Vector exhausted %d/%d", (int)non_recurring_requests_.size());
279                 non_recurring_requests_.resize(MAX_SIMULTANEOUS_DIAG_REQUESTS);
280                 added = false;
281         }
282         return added;
283 }
284
285 bool diagnostic_manager_t::validate_optional_request_attributes(float frequencyHz)
286 {
287         if(frequencyHz > MAX_RECURRING_DIAGNOSTIC_FREQUENCY_HZ) {
288                 DEBUG(binder_interface, "Requested recurring diagnostic frequency %d is higher than maximum of %d",
289                         frequencyHz, MAX_RECURRING_DIAGNOSTIC_FREQUENCY_HZ);
290                 return false;
291         }
292         return true;
293 }
294
295 /// @brief Add and send a new recurring diagnostic request.
296 ///
297 /// At most one recurring request can be active for the same arbitration ID, mode
298 /// and (if set) PID on the same bus at one time. If you try and call
299 /// addRecurringRequest with the same key, it will return an error.
300 ///
301 /// TODO: This also adds any neccessary CAN acceptance filters so we can receive the
302 /// response. If the request is to the functional broadcast ID (0x7df) filters
303 /// are added for all functional addresses (0x7e8 to 0x7f0).
304 ///
305 /// Example:
306 ///
307 ///     // Creating a functional broadcast, mode 1 request for PID 2.
308 ///     DiagnosticRequest request = {
309 ///         arbitration_id: 0x7df,
310 ///         mode: 1,
311 ///         has_pid: true,
312 ///         pid: 2
313 ///     };
314 ///
315 ///     // Add a recurring request, to be sent at 1Hz, and published with the
316 ///     // name "my_pid_request"
317 ///     addRecurringRequest(&getConfiguration()->diagnosticsManager,
318 ///          canBus,
319 ///          &request,
320 ///          "my_pid_request",
321 ///          false,
322 ///          NULL,
323 ///          NULL,
324 ///          1);
325 ///
326 /// @param[in] request - The parameters for the request.
327 /// @param[in] name - An optional human readable name this response, to be used when
328 ///      publishing received responses. If the name is NULL, the published output
329 ///      will use the raw OBD-II response format.
330 /// @param[in] waitForMultipleResponses - If false, When any response is received
331 ///      for this request it will be removed from the active list. If true, the
332 ///      request will remain active until the timeout clock expires, to allow it
333 ///      to receive multiple response. Functional broadcast requests will always
334 ///      waint for the timeout, regardless of this parameter.
335 /// @param[in] decoder - An optional DiagnosticResponseDecoder to parse the payload of
336 ///      responses to this request. If the decoder is NULL, the output will
337 ///      include the raw payload instead of a parsed value.
338 /// @param[in] callback - An optional DiagnosticResponseCallback to be notified whenever a
339 ///      response is received for this request.
340 /// @param[in] frequencyHz - The frequency (in Hz) to send the request. A frequency above
341 ///      MAX_RECURRING_DIAGNOSTIC_FREQUENCY_HZ is not allowed, and will make this
342 ///      function return false.
343 ///
344 /// @return true if the request was added successfully. Returns false if there
345 /// was too much already running requests, if the frequency was too high TODO:or if the
346 /// CAN acceptance filters could not be configured,
347 ///
348 bool diagnostic_manager_t::add_recurring_request(DiagnosticRequest* request, const char* name,
349                 bool wait_for_multiple_responses, const DiagnosticResponseDecoder decoder,
350                 const DiagnosticResponseCallback callback, float frequencyHz)
351 {
352         if(!validate_optional_request_attributes(frequencyHz))
353                 return false;
354
355         cleanup_active_requests(false);
356
357         bool added = true;
358         if(find_recurring_request(request) == nullptr)
359         {
360                 if(recurring_requests_.size() <= MAX_SIMULTANEOUS_DIAG_REQUESTS)
361                 {
362                         sd_event_source *source;
363                         // TODO: implement Acceptance Filter
364                         //if(updateRequiredAcceptanceFilters(bus, request)) {
365                         active_diagnostic_request_t* entry = new active_diagnostic_request_t(bus_, request, name,
366                                         wait_for_multiple_responses, decoder, callback, frequencyHz);
367                         entry->set_handle(shims_, request);
368
369                         char request_string[128] = {0};
370                         diagnostic_request_to_string(&entry->get_handle()->request, request_string,
371                                         sizeof(request_string));
372
373                         DEBUG(binder_interface, "add_recurring_request: Added recurring diagnostic request (freq: %f) on bus %s: %s",
374                                         frequencyHz, bus_.c_str(), request_string);
375
376                         uint64_t usec;
377                         sd_event_now(afb_daemon_get_event_loop(binder_interface->daemon), CLOCK_MONOTONIC, &usec);
378                         if(sd_event_add_time(afb_daemon_get_event_loop(binder_interface->daemon), &source,
379                                         CLOCK_MONOTONIC, usec, TIMERFD_ACCURACY, send_request, request) < 0)
380                         {
381                                 ERROR(binder_interface, "add_recurring_request: Request fails to be schedule through event loop");
382                                 added = false;
383                         }
384                         recurring_requests_.push_back(entry);
385                 }
386                 else
387                 {
388                         WARNING(binder_interface, "add_recurring_request: There isn't enough request entry. Vector exhausted %d/%d", (int)recurring_requests_.size(), MAX_SIMULTANEOUS_DIAG_REQUESTS);
389                         recurring_requests_.resize(MAX_SIMULTANEOUS_DIAG_REQUESTS);
390                         added = false;
391                 }
392         }
393         else
394         {
395                 DEBUG(binder_interface, "add_recurring_request: Can't add request, one already exists with same key");
396                 added = false;
397         }
398         return added;
399 }
400
401 /// @brief Returns true if there are two active requests running for the same arbitration ID.
402 bool diagnostic_manager_t::conflicting(active_diagnostic_request_t* request, active_diagnostic_request_t* candidate) const
403 {
404         return (candidate->get_in_flight() && candidate != request &&
405                         candidate->get_can_bus_dev() == request->get_can_bus_dev() &&
406                         candidate->get_id() == request->get_id());
407 }
408
409
410 /// @brief Returns true if there are no other active requests to the same arbitration ID.
411 bool diagnostic_manager_t::clear_to_send(active_diagnostic_request_t* request) const
412 {
413         for ( auto entry : non_recurring_requests_)
414         {
415                 if(conflicting(request, entry))
416                         return false;
417         }
418
419         for ( auto entry : recurring_requests_)
420         {
421                 if(conflicting(request, entry))
422                         return false;
423         }
424         return true;
425 }
426
427 /// @brief Systemd timer event callback use to send CAN messages at regular interval. Depending
428 /// on the diagnostic message frequency.
429 ///
430 /// This should be called from systemd binder event loop and the event is created on add_recurring_request
431 ///
432 /// @param[in] s - Systemd event source pointer used to reschedule the new iteration.
433 /// @param[in] usec - previous call timestamp in microseconds.
434 /// @param[in] userdata - the DiagnosticRequest struct, use to retrieve the active request from the list.
435 ///
436 /// @return positive integer if sent and rescheduled or negative value if something wrong. If an error occurs
437 /// event will be disabled.
438 int diagnostic_manager_t::send_request(sd_event_source *s, uint64_t usec, void *userdata)
439 {
440         diagnostic_manager_t& dm = configuration_t::instance().get_diagnostic_manager();
441         DiagnosticRequest* request = (DiagnosticRequest*)userdata;
442         active_diagnostic_request_t* adr = dm.find_recurring_request(request);
443
444 //      if(adr != nullptr && adr->get_can_bus_dev() == dm.get_can_bus_dev() && adr->should_send() &&
445 //              dm.clear_to_send(adr))
446         if(adr != nullptr && adr->get_can_bus_dev() == dm.get_can_bus_dev())
447         {
448                 adr->get_frequency_clock().tick();
449                 start_diagnostic_request(&dm.shims_, adr->get_handle());
450                 if(adr->get_handle()->completed && !adr->get_handle()->success)
451                 {
452                         DEBUG(binder_interface, "send_request: Fatal error sending diagnostic request");
453                         sd_event_source_unref(s);
454                         return -1;
455                 }
456                 adr->get_timeout_clock().tick();
457                 adr->set_in_flight(true);
458
459                 if(adr->get_recurring())
460                 {
461                         usec = usec + (uint64_t)(frequency_clock_t::frequency_to_period(adr->get_frequency_clock().get_frequency())*MICRO);
462                         DEBUG(binder_interface, "send_request: Event loop state: %d. usec: %ld", sd_event_get_state(afb_daemon_get_event_loop(binder_interface->daemon)), usec);
463                         if(sd_event_source_set_time(s, usec+1000000) >= 0)
464                                 if(sd_event_source_set_enabled(s, SD_EVENT_ON) >= 0)
465                                 {
466                                         sd_event_source_unref(s);
467                                         return -2;
468                                 }
469                         return 1;
470                 }
471         }
472         sd_event_source_unref(s);
473         ERROR(binder_interface, "send_request: Something goes wrong when submitting a new request to the CAN bus");
474         return -3;
475 }
476
477 /// @brief Will decode the diagnostic response and build the final openxc_VehicleMessage to return.
478 ///
479 /// @param[in] adr - A pointer to an active diagnostic request holding a valid diagnostic handle
480 /// @param[in] response - The response to decode from which the Vehicle message will be built and returned
481 ///
482 /// @return A filled openxc_VehicleMessage or a zeroed struct if there is an error.
483 openxc_VehicleMessage diagnostic_manager_t::relay_diagnostic_response(active_diagnostic_request_t* adr, const DiagnosticResponse& response)
484 {
485         openxc_VehicleMessage message = build_VehicleMessage();
486         float value = (float)diagnostic_payload_to_integer(&response);
487         if(adr->get_decoder() != nullptr)
488         {
489                 value = adr->get_decoder()(&response, value);
490         }
491
492         if((response.success && strnlen(adr->get_name().c_str(), adr->get_name().size())) > 0)
493         {
494                 // If name, include 'value' instead of payload, and leave of response
495                 // details.
496                 message = build_VehicleMessage(build_SimpleMessage(adr->get_name(), build_DynamicField(value)));
497         }
498         else
499         {
500                 // If no name, send full details of response but still include 'value'
501                 // instead of 'payload' if they provided a decoder. The one case you
502                 // can't get is the full detailed response with 'value'. We could add
503                 // another parameter for that but it's onerous to carry that around.
504                 message = build_VehicleMessage(adr, response, value);
505         }
506
507         // If not success but completed then the pid isn't supported
508         if(!response.success)
509         {
510                 std::vector<diagnostic_message_t*> found_signals;
511                 configuration_t::instance().find_diagnostic_messages( build_DynamicField(adr->get_name()), found_signals );
512                 found_signals.front()->set_supported(false);
513                 cleanup_request(adr, true);
514                 NOTICE(binder_interface, "relay_diagnostic_response: PID not supported or ill formed. Please unsubscribe from it. Error code : %d", response.negative_response_code);
515         }
516
517         if(adr->get_callback() != nullptr)
518         {
519                 adr->get_callback()(adr, &response, value);
520         }
521
522         return message;
523 }
524
525 /// @brief Will take the CAN message and pass it to the receive functions that will process
526 /// diagnostic handle for each active diagnostic request then depending on the result we will 
527 /// return pass the diagnostic response to decode it.
528 ///
529 /// @param[in] entry - A pointer to an active diagnostic request holding a valid diagnostic handle
530 /// @param[in] cm - A raw CAN message.
531 ///
532 /// @return A pointer to a filled openxc_VehicleMessage or a nullptr if nothing has been found.
533 openxc_VehicleMessage diagnostic_manager_t::relay_diagnostic_handle(active_diagnostic_request_t* entry, const can_message_t& cm)
534 {
535         DiagnosticResponse response = diagnostic_receive_can_frame(&shims_, entry->get_handle(), cm.get_id(), cm.get_data(), cm.get_length());
536         if(response.completed && entry->get_handle()->completed)
537         {
538                 if(entry->get_handle()->success)
539                         return relay_diagnostic_response(entry, response);
540         }
541         else if(!response.completed && response.multi_frame)
542         {
543                 // Reset the timeout clock while completing the multi-frame receive
544                 entry->get_timeout_clock().tick();
545         }
546
547         return build_VehicleMessage();
548 }
549
550 /// @brief Find the active diagnostic request with the correct DiagnosticRequestHandle
551 /// member that will understand the CAN message using diagnostic_receive_can_frame function
552 /// from UDS-C library. Then decode it with an ad-hoc method.
553 ///
554 /// @param[in] cm - Raw CAN message received
555 ///
556 /// @return VehicleMessage with decoded value.
557 openxc_VehicleMessage diagnostic_manager_t::find_and_decode_adr(const can_message_t& cm)
558 {
559         openxc_VehicleMessage vehicle_message = build_VehicleMessage();
560
561         for ( auto entry : non_recurring_requests_)
562         {
563                 vehicle_message = relay_diagnostic_handle(entry, cm);
564                 if (is_valid(vehicle_message))
565                         return vehicle_message;
566         }
567
568         for ( auto entry : recurring_requests_)
569         {
570                 vehicle_message = relay_diagnostic_handle(entry, cm);
571                 if (is_valid(vehicle_message))
572                         return vehicle_message;
573         }
574
575         return vehicle_message;
576 }
577
578 /// @brief Tell if the CAN message received is a diagnostic response.
579 /// Request broadcast ID use 0x7DF and assigned ID goes from 0x7E0 to Ox7E7. That allows up to 8 ECU to respond 
580 /// at the same time. The response is the assigned ID + 0x8, so response ID can goes from 0x7E8 to 0x7EF.
581 ///
582 /// @param[in] cm - CAN message received from the socket.
583 ///
584 /// @return True if the active diagnostic request match the response.
585 bool diagnostic_manager_t::is_diagnostic_response(const can_message_t& cm)
586 {
587         if (cm.get_id() >= 0x7e8 && cm.get_id() <= 0x7ef)
588                         return true;
589         return false;
590 }