1 From 04765936a0a8dd3ac3f530786fce6b5cea826d3e Mon Sep 17 00:00:00 2001
2 From: Roger Zanoni <rzanoni@igalia.com>
3 Date: Wed, 24 Feb 2021 13:50:27 +0100
4 Subject: [PATCH] [skia][build] fix skia no_sanitize build issues for gcc
6 Based on https://src.fedoraproject.org/rpms/chromium/blob/rawhide/f/chromium-skia-no_sanitize.patch
9 .../skia/include/private/SkFloatingPoint.h | 24 +++++++++++++++++++
10 1 file changed, 24 insertions(+)
12 diff --git a/src/third_party/skia/include/private/SkFloatingPoint.h b/src/third_party/skia/include/private/SkFloatingPoint.h
13 index 110dda2ae4..8223e9b57d 100644
14 --- a/src/third_party/skia/include/private/SkFloatingPoint.h
15 +++ b/src/third_party/skia/include/private/SkFloatingPoint.h
16 @@ -159,7 +159,15 @@ static inline int64_t sk_float_saturate2int64(float x) {
17 // Cast double to float, ignoring any warning about too-large finite values being cast to float.
18 // Clang thinks this is undefined, but it's actually implementation defined to return either
19 // the largest float or infinity (one of the two bracketing representable floats). Good enough!
20 +#if defined(__GNUC__) && __GNUC__ >= 8
21 +__attribute__((no_sanitize("float-cast-overflow")))
23 +# if defined(__GNUC__)
24 +__attribute__((no_sanitize_undefined))
26 [[clang::no_sanitize("float-cast-overflow")]]
29 static inline float sk_double_to_float(double x) {
30 return static_cast<float>(x);
32 @@ -226,12 +234,28 @@ static inline float sk_float_rsqrt(float x) {
33 // IEEE defines how float divide behaves for non-finite values and zero-denoms, but C does not
34 // so we have a helper that suppresses the possible undefined-behavior warnings.
36 +#if defined(__GNUC__) && __GNUC__ >= 8
37 +__attribute__((no_sanitize("float-divide-by-zero")))
39 +# if defined(__GNUC__)
40 +__attribute__((no_sanitize_undefined))
42 [[clang::no_sanitize("float-divide-by-zero")]]
45 static inline float sk_ieee_float_divide(float numer, float denom) {
49 +#if defined(__GNUC__) && __GNUC__ >= 8
50 +__attribute__((no_sanitize("float-cast-overflow")))
52 +# if defined(__GNUC__)
53 +__attribute__((no_sanitize_undefined))
55 [[clang::no_sanitize("float-divide-by-zero")]]
58 static inline double sk_ieee_double_divide(double numer, double denom) {